GithubHelp home page GithubHelp logo

codesandbox-ci-ui's People

Contributors

aj-foster avatar compuives avatar dependabot[bot] avatar lbogdan avatar michaeldeboey avatar saravieira avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

codesandbox-ci-ui's Issues

[Feature Request] Make bot comment text configurable

Hi, I hope I'm in the right repo here - this seems to be the most "CSB CI"-themed Repo.

We would love it if there were a way of configuring the text of the CodeSandbox-CI bot comment.

Especially the ability to have the package install instructions right in the comment would be incredibly valuable, as at the moment, we often have to add screenshots in hand-written comments to explain to contributors how to install the CI build.

CI doesn't build complete list of sandboxes

Hello, I couldn't find the dedicated codesandbox-ci repo, so please feel free to transfer this issue if I've just missed it ๐Ÿ˜…

Our complete list of sandboxes in react-spring is about 20. But only 10 seem to be built from the configuration, as seen in a recent PR but sometimes when there are more sandboxes in the issue or PR they are still built as can be seen in this PR.

Maybe i've done something wrong? Or maybe there's a maximum and it needs documenting? I did put this in the Discord, but received no reply.

[Feature Request] restrict CI build to exclude certain branches

Hi again, I still hope I'm in the correct repo :)

We'd like to exclude renovate/* branches from the CSB CI, as those renovate-PRs already add a lot of noise, and the checks from CSB add additional noise on top of that. Could you maybe add a configuration option for that?

Publish tarballs with .tgz extension

Not sure if this is appropriate here.

yarn v2 no longer installs packages from arbitrary urls.

Right now

diff --git a/package.json b/package.json
index 2f92273..b2e2b2a 100644
--- a/package.json
+++ b/package.json
@@ -3,6 +3,7 @@
   "version": "0.1.0",
   "private": true,
   "dependencies": {
+    "@material-ui/core": "https://pkg.csb.dev/mui-org/material-ui/commit/e9a9cdb2/@material-ui/core",
     "@testing-library/jest-dom": "^5.11.4",
     "@testing-library/react": "^11.1.0",
     "@testing-library/user-event": "^12.1.10",

fails with

$ yarn
โžค YN0000: โ”Œ Resolution step
โžค YN0001: โ”‚ Error: @material-ui/core@https://pkg.csb.dev/mui-org/material-ui/commit/e9a9cdb2/@material-ui/core isn't supported by any available resolver
    at i.getResolverByDescriptor (/home/eps1lon/Development/throwaway/cra4-mui5-react17/.yarn/releases/yarn-2.3.3.cjs:2:314629)

I asked in their discord and they confirmed that tarballs need the .tgz extension. I tried if this url already existed but got a 404: https://pkg.csb.dev/mui-org/material-ui/commit/e9a9cdb2/@material-ui/core.tgz

Alternatives:

  1. download as .tgz and install does not work since the codesandbox replaced dependency ranges with https://csb.*
  2. write custom yarn resolver

Missing module in sandbox from codesandbox ci

We're trying to use CS:CI for a React component for the first time and running into an interesting error that maybe y'all can help with.

Here's the base sandbox which is working fine:
https://codesandbox.io/s/npm-embeddable-explorer-zotwkv

Here's a PR which uses that sandbox in its sandbox config:
apollographql/embeddable-explorer#31

The packages in that build can be installed and work in an npm project. However, the actual sandbox fork says the module is missing. When I look into the sources, I don't see @apollo/explorer anywhere in the node_modules like I'd expect. Here's a screenshot of what I'm looking at:
image

In the original sandbox, the @apollo/explorer module does show up in the node_modules.
image

Hopefully that's helpful, let me know if you need any more info from us.

Restart build from UI if it fails

Github is currently having issues: https://www.githubstatus.com/incidents/2y6v4ltq26g7

However, this has made my build fail https://ci.codesandbox.io/status/Sage/carbon/pr/2764/builds/21874

yarn run v1.21.1
$ node dist/index.js
+ git clone https://github.com/Sage/carbon.git .
Cloning into '.'...
+ git fetch --force origin pull/2764/head:remotes/origin/pull/2764
fatal: unable to access 'https://github.com/Sage/carbon.git/': The requested URL returned error: 504
{ Error: Process rejected with status code 128
    at ChildProcess.<anonymous> (/app/dist/utils/exec.js:18:27)
    at ChildProcess.emit (events.js:198:13)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12) code: 128 }
error Command failed with exit code 128.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

There is no way to re-trigger this build, it would be great to be able to do this from the UI.

I'm happy to help with this if there is a way for me to contribute?

In particular, I need an API to restart the build.

Frequent "EACCES: permission denied" Error

I would like to raise a potential race condition or a rate-limiting issue with CI as well as a frustration point.

On mui-org, we frequently experience failing builds with the following: EACCES: permission denied, for instance: https://ci.codesandbox.io/status/mui-org/material-ui-x/pr/890/builds/95536. This seems to be correlated to an increase a build per minute. This happens for us systematically when dependabot opens a bunch of pull requests. The problem is made worse by #11.

Node 12 support

Seems like codesandbox is still on 10.23 (EOL end of this month).

I'm trying to do a gradual migration to 12.x and it won't even install even though I have a dedicated install command that runs yarn install --ignore-engines.

This indicates that you don't use the yarn version we checked into our repository (yarn install:codesandbox is working locally with node 10.23).

Failure: https://ci.codesandbox.io/status/mui-org/material-ui/pr/25306/builds/108812
Changes: mui/material-ui#25306

Glob patterns not fully supported

See build: https://ci.codesandbox.io/status/apollographql/apollo-server/pr/5999/builds/206909

We have a pretty large list of packages, and only one that needs to be excluded (it's private / unpublished). I tried to use the glob pattern packages/!(apollo-server-integration-testsuite) to ignore it, but it interprets the string literally and results in the error:
Error: Can't find package.json at /tmp/16f8ef8e/packages/!(apollo-server-integration-testsuite)/package.json

The docs/example does say globs are supported:

// Globs are supported.
"packages": ["packages/react", "packages/react-dom"],

Clear Yarn cache before `yarn install`

In https://github.com/mui/mui-x there's a dependency in package.json which is a git repo. In turns out that if a git repo has its history rewritten, e.g. by deleting a commit, Yarn will try to do a merge commit if it already has the repo cached and CodeSandbox CI will fail because it doesn't have the user and email to write the commit. Cleaning the cache before yarn install solves the problem locally but is there a way to do this inside CodeSandbox CI?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.