Suggestions for simplifying Docker Compose about cogstack-nifi

[vladd-bit]

Hello,

I will address this in the next release and focus on having a more adaptable ENV var config.

Some things that I should mention about the points made:

1. The reason I kept some vars in the docker compose for now was because of supporting multiple ES versions (opensearch and native), it totally makes sense to have it the way you mentioned. However, on the NiFi env var side of things, when I did the upgrade from 1.14 to 1.1(5/6).x I had noticed most variables were not picked up by the container as they are not configurable via env vars(reported as improvements on their tracker, https://issues.apache.org/jira/browse/NIFI-7060?jql=project%20%3D%20NIFI%20AND%20status%20%3D%20Open%20AND%20text%20~%20%22Environment%22 ), it required .prop file being changed (for example for the proxy context path), this is definitely on the scope though and I will just adapt the changes mentioned there.

2. Agreed.

3. Will review and merge.

4. Will revise this, need a new structure that fits both versions of ES.

5. Agreed.

6. I've only included those as they were specified in the default ES/open-ES setup samples. Will be removing them and including them under the ports section instead as they were used for other logging purposes.

[vladd-bit]

All of the things here have been addressed in the past commits. Documentation updates to follow. But now it is possible to fully dinamically switch ES versions by simply modifying the .env files in ./deploy and then executing the export_env_vars.sh, settings for the other services are now present in their respective .env files.

[sandertan]

Thanks a lot @vladd-bit ! I was planning to rebase our local branch on master this week, so this is perfect timing :)