coinbase / coinbase-bitmonet-sdk Goto Github PK

Please clarify how this is not a violation of Google's Terms of Service.

Would it be possible to add gradle files so this could easily be imported into Android Studio?

In the file CoinbasePaymentProcessor.java, constructJSONForSendMoney(final String item, final double amount) creates the json that will be submitted to the send_money endpoint of Coinbase.

This worked for me until Friday, and then I realized we were getting 404s back from Coinbase with this message: {"success":false,"errors":["Required parameter missing: transaction"]}

Looking at their documentation, it seems they've made it required to include a "transaction" object in this json. A quick fix would be to wrap what's currently provided in constructJSONForSendMoney in a "transaction", and then send that json.

When user has already been authorized, calling Bitmonet.requestWalletAuthorization(this); simply show a Toast message.

It would be nicer and cleaner to have the interface walletOAuthStatusListener(true); to be triggered, so that the code flow is the same for both logged in & non-logged in cases.

Licensing this under GPLv2 makes it impractical to use in a commercial/closed source project. Yeah I could possible load the dex and access it via reflection, and will likely do that if need be, but what a PITA.

Would appreciate an alternative apache or BSD license being available.

According to API docs, I set the redirect uri to be "urn:ietf:wg:oauth:2.0:oob"
The callback is having this format https://coinbase.com/oauth/authorize/ACCESS_TOKEN_HERE

While the current source code is looking for "?code=" pattern.

I have modified my own code to work with the newer format, but unsure if I should keep the old format for backward compatibility?