colingbos / genloader Goto Github PK
View Code? Open in Web Editor NEWMinecraft mod for ore generation loading - everything is accessible to the end user
License: MIT License
Minecraft mod for ore generation loading - everything is accessible to the end user
License: MIT License
I was reading through your code for disabling vanilla ore generation and came across this construct in vapourdrive.genloader.events.VanillaGenDisabler.genDisabler
:
if(ConfigOptions.disableVanillaOres)
{
event.setResult(Result.DENY);
}
I am curious as to why you are checking the state of the config option for every generation event instead of in vapourdrive.genloader.events.EventManager.init
ร la:
public static void init()
{
if(ConfigOptions.disableVanillaOres)
{
MinecraftForge.ORE_GEN_BUS.register(new VanillaGenDisabler());
}
}
Wouldn't this save some time during chunk population, since you would only be checking the conditional once at game load instead of every time the vanilla generator tried to do its thing? Is there a benefit to repeating the check each time that I am missing?
EDIT: There is also always the possibility that any time saved/efficiency gained would be insignificant (I have often fallen victim to premature optimization...), but I am mainly interested in any advantages conveyed by your current approach to this problem.
Currently it's not possible to replace the oreBiome stone types created by the Mineralogy Mod.
You can replace through the 'minecraft:stone' but not target specific regions generated by Mineralogy, like 'mineralogy:schitis' etc. Because it won't recognize these while generating the ores (Maybe the orgen runs too early?)
Would be really frat to get this feature! ๐
Hey there I just open this as a proper issue instead on relying on Curse comments, I just found this repository.
It would be really cool if the configuration would allow to define multiple replacement blocks.
So instead of having an Object we could make an Array like the weightedBlocks have.
Before:
[
{
"blockToReplace": {
"Block": "minecraft:stone",
"Properties": {
"variant": "stone"
}
},
"generatorPriority": "LATEST",
"generatorType": "STANDARDVARIABLECLUSTER",
"frequency": 1,
"minY": 0,
"maxY": 128,
"size": 100,
"weightedBlocks": [
{
"Weight": 30,
"Block": "gold_ore",
"Properties": {}
},
{
"Weight": 5,
"Block": "iron_ore",
"Properties": {}
},
],
"dimensions": [
0
],
"category": {
"name": "Compound Biome Ores",
"defaultEnabled": true
},
"chance": 0.15
}
]
After:
[
{
"blockToReplace": [
{
"Block": "minecraft:stone",
"Properties": {
"variant": "stone"
}
},
{
"Block": "minecraft:netherrack",
"Properties": {
"variant": "stone"
}
}
],
"generatorPriority": "LATEST",
"generatorType": "STANDARDVARIABLECLUSTER",
"frequency": 1,
"minY": 0,
"maxY": 128,
"size": 100,
"weightedBlocks": [
{
"Weight": 30,
"Block": "gold_ore",
"Properties": {}
},
{
"Weight": 5,
"Block": "iron_ore",
"Properties": {}
},
],
"dimensions": [
0
],
"category": {
"name": "Compound Biome Ores",
"defaultEnabled": true
},
"chance": 0.15
}
]
Can you allow the dimension matching to be set to a black or whitelist please? It's easier to set a blacklist for 1,-1 then it is to set 5+ dimensions (or a lot more when rftools/mystcraft is involved).
Thanks.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.