GithubHelp home page GithubHelp logo

genloader's People

Contributors

blackskyliner avatar colingbos avatar

Stargazers

avatar avatar avatar

Watchers

avatar

Forkers

searge-dp immortalcatz

genloader's Issues

Mineralogy compatibility

Currently it's not possible to replace the oreBiome stone types created by the Mineralogy Mod.
You can replace through the 'minecraft:stone' but not target specific regions generated by Mineralogy, like 'mineralogy:schitis' etc. Because it won't recognize these while generating the ores (Maybe the orgen runs too early?)

Would be really frat to get this feature! 👍

Efficiency of Checking the Config Every Time for Disabling Vanilla Generation

I was reading through your code for disabling vanilla ore generation and came across this construct in vapourdrive.genloader.events.VanillaGenDisabler.genDisabler:

if(ConfigOptions.disableVanillaOres)
            {
                event.setResult(Result.DENY);
            }

I am curious as to why you are checking the state of the config option for every generation event instead of in vapourdrive.genloader.events.EventManager.init à la:

public static void init()
    {
        if(ConfigOptions.disableVanillaOres)
            {
                MinecraftForge.ORE_GEN_BUS.register(new VanillaGenDisabler());
            }
    }

Wouldn't this save some time during chunk population, since you would only be checking the conditional once at game load instead of every time the vanilla generator tried to do its thing? Is there a benefit to repeating the check each time that I am missing?

EDIT: There is also always the possibility that any time saved/efficiency gained would be insignificant (I have often fallen victim to premature optimization...), but I am mainly interested in any advantages conveyed by your current approach to this problem.

Dimension Black/whitelist

Can you allow the dimension matching to be set to a black or whitelist please? It's easier to set a blacklist for 1,-1 then it is to set 5+ dimensions (or a lot more when rftools/mystcraft is involved).

Thanks.

Allow multiple blockToReplace in configuration.

Hey there I just open this as a proper issue instead on relying on Curse comments, I just found this repository.

It would be really cool if the configuration would allow to define multiple replacement blocks.
So instead of having an Object we could make an Array like the weightedBlocks have.

Before:

[
    {
        "blockToReplace": {
            "Block": "minecraft:stone",
            "Properties": {
                "variant": "stone"
            }
        },
        "generatorPriority": "LATEST",
        "generatorType": "STANDARDVARIABLECLUSTER",
        "frequency": 1,
        "minY": 0,
        "maxY": 128,
        "size": 100,
        "weightedBlocks": [
            {
                "Weight": 30,
                "Block": "gold_ore",
                "Properties": {}
            },
            {
                "Weight": 5,
                "Block": "iron_ore",
                "Properties": {}
            },
        ],
        "dimensions": [
            0
        ],
        "category": {
            "name": "Compound Biome Ores",
            "defaultEnabled": true
        },
        "chance": 0.15
    }
]

After:

[
    {
       "blockToReplace": [
            {
                "Block": "minecraft:stone",
                "Properties": {
                    "variant": "stone"
                }
            },
            {
                "Block": "minecraft:netherrack",
                "Properties": {
                    "variant": "stone"
                }
            }
        ],
        "generatorPriority": "LATEST",
        "generatorType": "STANDARDVARIABLECLUSTER",
        "frequency": 1,
        "minY": 0,
        "maxY": 128,
        "size": 100,
        "weightedBlocks": [
            {
                "Weight": 30,
                "Block": "gold_ore",
                "Properties": {}
            },
            {
                "Weight": 5,
                "Block": "iron_ore",
                "Properties": {}
            },
        ],
        "dimensions": [
            0
        ],
        "category": {
            "name": "Compound Biome Ores",
            "defaultEnabled": true
        },
        "chance": 0.15
    }
]

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.