colrdavidson / spall-web Goto Github PK

Should auto colors be the default setting? It's defaulting to light for me, where auto is the next in the cycle.

I have the most recent version of Odin and just downloaded Spall, but I'm unable to use it.

Whenever I try to load http://localhost:8000/spall.html I got this message:

Looking at browser console, I got this message:

LinkError: WebAssembly.instantiate(): Import #5 module="env" function="fmax": function import requires a callable
init @ spall.js:385

Then a little later there's another error:

Uncaught (in promise) Error: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received

spall.h has // SPDX-License-Identifier: 0BSD but the repo LICENSE file is MIT.

The examples mostly do not have license info, so one might assume they fall under MIT by default.

Would be nice to more clearly specify things to be one license or the other, or at least resolve the ambiguity.

Users should be able to highlight text in the stats pane and copy it to their clipboard

Hi again, got a minor fix here.

The second memcpy within spall_build_begin() needs to use trunc_name_len instead of name_len

https://github.com/colrdavidson/spall-web/blob/17783521e15f1a063bf16a4742bef061553d2de3/spall.h#LL276C35-L276C35

See attached file. Not sure why
rpgpt.zip

Here is the stacktrace:

RuntimeError: unreachable
    at runtime.bounds_check_error.handle_error-0 (00567362:0xd08e)
    at frame (00567362:0x3f253)
    at Object.value [as frame] (wasm_runtime.js:308:24)
    at doFrame (spall.js:682:29)
doFrame @ spall.js:684

Here is the file that failed it:
rpgpt.zip

Let me know if you need anything else, such as source code. Thanks for making spall!

• Support ingesting a custom binary format instead of only JSON
  • Maybe using media molecule serialization for backwards compatibility between versions there?
• Support RDTSC timestamps as units
  • Ingest a timestampsPerSecond value in the file for conversion
    • Optionally fallback to a system value determined by tracey if that's possible to do in wasm/js
• Detect ZIP file inputs and automatically extract them using a streaming decompressor API
• Dynamically set the maximum zoom level to the double precision limit (which depends on the scroll position)
  • no more jitter 😃

I've got this small trace (~11MB) that I can check with speedscope just fine, but when I upload it into the Spall Web demo, I get:

Your JSON file is invalid! got 6, expected [ or {

I don't see any issue with the json, though and since speedscope can load it just fine, I don't think it's that.

Anything I can do to help figure out what the problem is, here?

Here is the error:

C:\Users\Cameron\Documents\spall>python build.py
Compiling...
Failed to execute command:
        "C:\Users\Cameron\Documents\odin\odin\\bin\wasm-ld" "C:/Users/Cameron/Documents/spall/build/spall.wasm.o" -o "C:/Users/Cameron/Documents/spall/build/spall.wasm"  --allow-undefined  --import-memory --initial-memory=131072000 --max-memory=4294967296
Traceback (most recent call last):
  File "C:\Users\Cameron\Documents\spall\build.py", line 43, in <module>
    subprocess.run([
  File "C:\Users\Cameron\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['odin', 'build', 'src', '-collection:formats=formats', '-target:js_wasm32', '-target-features:+bulk-memory', '-extra-linker-flags:--import-memory --initial-memory=131072000 --max-memory=4294967296', '-out:build/spall.wasm', '-debug']' returned non-zero exit status 4294967295.

Is there an intended odin compiler version?

Great project!

I've tried examples (e.g. native_auto_tracing) and cannot load profile.spall. I'm getting this:

What I'm doing wrong?

Thanks for making this tool!

I had a go using spall_native_auto.h but the file it generates crashes the web view. Seems to happen even when I don't initialise any threads for profiling using spall_auto_thread_init().

I've attached the file. Let me know if you'd like anything more to reproduce it.

Just been trying this code and came upon a minor issue. The 64-bit version of builtin_ctz is needed: __builtin_ctzll
Otherwise there is an implicit conversion to 32-bits and therefore an incorrect result.

https://github.com/colrdavidson/spall-web/blob/3f6be8a7dc7f6b170d4f9f2db00ee0a6df2bbd54/examples/auto_tracing/instrument.c#LL47C2-L47C2