Comments (16)
At comma.ai, our goal is to be as open as possible without killing the company. For now, for business model purposes, we have decided to keep visiond closed. Just like how parts of Android are closed. This may change in the future. At least it's free.
from openpilot.
I assume you are not interested in getting help from open source community in the visiond space.
The features shown in the Youtube video is what attracted me the most, and I hoped that I could modify and contribute also on those.
Too bad :-(
from openpilot.
@mslavescu I think a more fair criticism would be that one should know the API for visiond
- so that other open-source implementations/alternatives could be built and plugged in. Given that everything outside visiond
is open, the API by extension is available for anyone interested in working on it.
This is like Android OS, the core is open source, but shipped versions may include Google Play Services which is closed and can and has been substituted by others like Amazon for their own variants. This is the beauty of OSS - let's appreciate it.
from openpilot.
Hmm, if you mean what's on the screen, a lot of what you are looking for is probably in ui.c
from openpilot.
Yeah this is quite a bummer but I'm not going to doubt the decisionmaking of someone with such a background. @geohot I've just got one question. This visiond, is it a compiled version of a machinelearning model? And what language is this binary file written in?
I'm asking because I'm deeply interested in AI since the past 2 years. I only ran my models on Python/Jupyter and Tensorflow/Keras.
from openpilot.
I understand the decision, I don't see how this project can be extended in open source way, if a main component, the one that decides where the car should go is not open source.
@geohot I'm talking about the computer vision and machine learning algos embeded in visiond, I belive that is the brain of this project, the rest is just plumbing, which is nice also, but most people will probably not use it.
The UI is nice, but is not something very hard to do, for example with STEMCA Inventor a 5th grader could probably build a UI with similar functionality in a few hours.
from openpilot.
re #4 (comment)
Is it not the case that the license of openpilot also applies to the visiond
blob?
If so, anyone is free to reverse it and modify it, redistribute the results, etc. Certainly that is not as useful as having the original source code, but this provides more freedom than some driver blobs.
from openpilot.
@slivingston I don't think so.
If you don't have the source you cannot realy modifiy it, regardless of license.
The visiond is not the only thing offered only in binary form, NEOS the modified Android version is in binary form also, looks like they are too lazy to release the source for that :-)
from openpilot.
@mslavescu it's much harder but it can be done (I've modified binaries myself as well back in my 'darker ages' / when I was a a kid xD)
from openpilot.
The API for visiond
: broadcast ModelData packets at 20hz. That's pretty much it controls wise. See https://github.com/commaai/openpilot/blob/master/common/services.py#L46
You are welcome to replace visiond
with an open source version.
from openpilot.
The same license applies to visiond. We encourage binary mods :-)
from openpilot.
Reproducing comma's visiond
is trivial from deep learning point of view, use the existing system by driving around under different conditions and generate ground truth data from 20hz I/O already provided by ModelData. Than, train another neural network model offline or on the cloud with visiond
ground truthing reference from ModelData braodcast packet, at least this will get a new neural network very close to visiond
behavior, than share the new neural network model for open source inference.
from openpilot.
@edvin1983 I would love to use such an implementation (on Android, optimized for Snapdragon 820) if you get a chance to build one.
from openpilot.
Slowly digging through openpilot a bit, curious how hard it is to get it running.
Also think it's kinda sad that openpilot is sold to the media as open source but visiond is not ?yet? open sourced.
I can understand that everyone is responsible for himself, and there are actually a couple of people out there which look on the code. (e.g. some found out that the CAN commands don't seem to be sanity checked at some point).
But what should we with that? Just hope that visiond works as expected without any chance to do a code analysis?
from openpilot.
I don't think they pitched it as "open", they pitched it as, "hey, you can build your very own" - which is true.
from openpilot.
Well, the name is 'openpilot', which emphasizes 'open' quite a bit. :)
from openpilot.
Related Issues (20)
- Ship Ubuntu 24.04 + mainline kernel to master HOT 1
- Bn
- card
- ui: map doesn't load if time is wrong at the start HOT 1
- Compatibility with Renault HOT 1
- Hyundai: relay malfunction in accessory mode with alpha long HOT 1
- qcomgpsd: fix accuracy logging
- GM Silverado: ECM faults HOT 1
- Take Control Immediately, CAN BUS Disconnected and Take Control, Controls are Lagging HOT 6
- [$500 bounty] test_models: add a test that fuzzes the tx messages HOT 1
- Hyundai Kona 2022 compatibility HOT 1
- long_mpc.py: code refactoring
- [$750 bounty] Replace PlotJuggler with Rerun HOT 1
- [$100 bounty] tools: split out dev apt dependencies HOT 1
- GM SDGM Harness
- `./cabana --panda` and `./cabana --panda-serial <panda-serial>` segfault, Cabana shows panda's serial while also saying "No panda found" HOT 3
- Remove pyenv HOT 3
- [$250 bounty] Update to Python 3.12 HOT 3
- master-ci: Display brightness not adapting to scene properly/Camera gain seems high and dark areas have high noise on display.
- [$100 bounty] Switch to uv package manager HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openpilot.