commandocoding / openid-selector Goto Github PK

Line 190/191 of openid-jquery.js currently looks like this:

-- 8< --
html += '<input id="' + id + '" type="text" style="' + style + '" name="' + id 
+ '" value="' + value + '" />'
+ '<input id="openid_submit" type="submit" value="' + this.signin_text + '"/>';
-- 8< --

ideally it would call a method with the parameters id and style, so it can be 
easily overwritten by injecting a user-defined method in the openid class.

What steps will reproduce the problem?
1. Combine the images to one sprite image
2. adjust CSS

What is the expected output? What do you see instead?
Reducing the requests. 

What version of the product are you using? On what operating system?
1.1

Please provide any additional information below.

Logging in through yahoo was not working.  I'm using the Zend Framework so
this is probably a bug in that code, but I only had to change the address
in the selector to fix it.

Using Yahoo's URL of http://yahoo.com/ was giving me an error about having
an invalid OpenId.  I changed it to http://me.yahoo.com/ and it works as
expected.  Hopefully this will be useful for anyone else trying to use Zend
and openid-selector.

Adding a setDemoMode(false) method will allow the client javascript code to
be more easily tested without having a server. It will be clear to see
which OpenID URL is going to be transmitted to the server.

What steps will reproduce the problem?
1. Click on Google (properly returns openid_identifier).
2. Click on Yahoo (returns the google openid_identifier instead of yahoo).
3. Click on Google (returns the yahoo openid_identifier instead of google).

What is the expected output? What do you see instead?

It gets out of sync after the first request. 


What version of the product are you using? On what operating system?

1.0 on FF3

Please provide any additional information below.

Not sure if this bug is only for non-username providers (Google, Yahoo) or 
if it applies to all providers. It appears related to using the cookie from 
the previous request, so something is out of sync.

Changing the line :

            hidden.value = url;

to :

            hidden.val(url);

fixes the issue.

I just rewrite this selector, now supports internacionalization and is
smaller (js: 2.8k compressed, 4.7k full)

Since i couldn't contact the author i made another project:

http://code.google.com/p/openid-realselector/

Hello,
As I don't know how to join you, i use this issue app to give you this news.
I've just made a wordpress plugin to use your OpenId Selector.

You can find it on this page : 
http://wordpress.org/extend/plugins/wp-openid-selector/

What steps will reproduce the problem?
1. ./generate-sprite.sh

What is the expected output? What do you see instead?
Initially it was saying "locale not found" because it was looking for the wrong 
file (js/openid-${LOCALE}.js instead of js/openid-jquery-${LOCALE}.js). After 
correcting that, it just hangs without any output, instead of generating the 
new images/openid-providers-en.png file.


What version of the product are you using? On what operating system?
The latest revision: r115. On Mac OS X 10.6.6

Please provide any additional information below.
The following changes will eliminate the problem:

1. line 37 : JSFILE=js/openid-jquery-${LOCALE}.js
2. line 53 : ./remcomments.sed < ${JSFILE} | sed -n '/providers_large/,/;/p' | 
sed -n '/: {/p' | sed 's/.*\t\(.*\) : {/\1/' | sed -E 's/:[[:space:]]    *{//'  
> tmp.txt

I've attached the modified file

Version 1.2 of openid-selector will be about localization. For this purpose we 
need your help in translating one (attached) file to your local language.

File that needs to be translated is attached (openid-jquery-en.js). Please 
translate "label" strings and attach your translated file in format 
openid-jquery-<2-char ISO language code>.js, i.e. openid-jquery-de.js for 
German, openid-jquery-fr.js for French, etc.

Russian and Ukrainian versions are already done.

I could REALLLLY use a destroy method..   In my use case, I'm loading this 
inside of the Boxy plugin (modal popup - loading this plugin "onShow") next to 
my standard login form.    the standard login occurs via AJAX and errors are 
returned to my popup and the form regenerated..  Since openID-selector was 
previously attached, when the response comes back, the openID-selector is 
broken.    I basically need to destroy the bindings for this plugin on 
ajaxFormSubmit, then re-init if theres a response that comes back..    

The interface already degrades pretty well when Javascript is not
available. The user simply gets a single text box that they can use to
submit their entire OpenID URL.

This can be improved upon simply for providers like Google and Yahoo where
the users just need to click on a button. We can provide a simple image
that is just an <a/> link to the server with ?provider=google or
?provider=yahoo.

These links would be part of a <div/> that is removed by Javascript before
the page is rendered. If there's no Javascript then there's nothing to
remove the <div/> and links will show up.

The providers that require a username are more difficult. These will have
to be removed.

what do you think about shadow and hover effects like on 
http://stackoverflow.com/users/login?

See the attached screenshot.
I'm using the latest trunk revision (r166) and Firefox 9.01 (Win7 x64).
I'm getting this problem both with openid.css and openid-shadow.css.
Right now I've commented #openid_highlight rule.

(Everything works fine with Chrome 16)

CMS Made Simple has an OpenID module that uses openid-selector as the frontend. 
Please add it to your list of CMS integrations on the front page.

More info at http://dev.cmsmadesimple.org/projects/openid

Take version 1.3 of February 2011

What steps will reproduce the problem?
1. Uncomment technorati, launchpad, etc.
2. Run generate-sprite.sh on Ubuntu 11.10
3. Fails with errors

The problem is this line:
./remcomments.sed < ${JSFILE} | sed -n '/providers_large/,/;/p' | sed -n '/: 
{/p' | sed 's/.*\t\(.*\) : {/\1/'  > tmp.txt


It should be extended by
| sed 's/://g;s/{//g;' | tr -d '[:blank:]'

making it 
./remcomments.sed < ${JSFILE} | sed -n '/providers_large/,/;/p' | sed -n '/: 
{/p' | sed 's/.*\t\(.*\) : {/\1/' | sed 's/://g;s/{//g;' | tr -d '[:blank:]' > 
tmp.txt

Else there are whitespaces and } and : in the result, instead of just a list of 
names for the images...

I wanted a version to use in my project that uses YUI. I might also want a 
version for Dojo later, so I've created a version that doesn't rely on any JS 
library. Tested in Firefox 7, Internet Explorer 9, Opera 11 and Chome 14.

Hi,

could you please also support the Google Closure Library 
(http://code.google.com/p/closure-library/)?

For some basic information about Google Closure, see 
http://stackoverflow.com/questions/1690197/what-does-google-closure-library-offe
r-over-jquery

Sincerely yours,
Martin

Tested using IE8 on Vista 64
Tested using IE7 on Vista 64

The .ico images are not displaying at all, as CSS backgrounds or when 
acccessed directly.

Confirmed at http://sourceforge.net/account/login.php as well as 
http://openid-selector.googlecode.com/svn/trunk/demo.html.

Screenshot attached.

What steps will reproduce the problem?
NOTE: This problem is visible when the login action occurs in a popup window, 
thus leaving the main login page open.

1. Select a provider that requires a user name (ie: AOL)
2. When prompted to login, cancel
3. Focus back to the main openid login screen
4. Select openID as the provider
5. At this point when inspecting in firebug there is now a hidden input with an 
id="openid_identifier" (Created when clicking submit when trying to login with 
AOL), AND secondary visable input with id="openid_identifier" (created on the 
form normally when openID provider is selected)

What is the expected output? What do you see instead?
The expected output is for there to be only one HTML element with 
id="openid_identifier". 
I see two instead.

What version of the product are you using? On what operating system?
1.3 / Windows

Please provide any additional information below.
The following diff will fix the issue (probably not the most elegant fix, but 
works)

useInputBox : function(provider) {
        var input_area = $('#openid_input_area');
        var html = '';
[...]
                 input_area.empty();
        + var duplicateHiddenObj = document.getElementById('openid_identifier');
        + if(duplicateHiddenObj != null){duplicateHiddenObj.parentNode.removeChild(duplicateHiddenObj);}

                input_area.append(html);
               $('#' + id).focus();
    },

[...]

What steps will reproduce the problem?
1. editing openid-jquery-en.js to enable/dosable some openid provider 
2. delete the assets cache
3. openid image and text inconsistence display. 
4. confusing when how to run generate-sprite.js???

What is the expected output? What do you see instead?
ordered 

What version of the product are you using? On what operating system?
windows

Please provide any additional information below.
please add manual to run generate-sprite.js instead of generate-sprite.sh or 
generate-sprite.rb

Stack overflow have extended your openid selectors to do oauth as well... will 
you be doing the same?

Im trying to implement the OpenId-Selector in an ASP.NET MVC 4 application. 


What steps will reproduce the problem?
1. I have unziped the package to /Plugins/OpenId-Selector
2. I have run the demo.html, it works fine.
3. I have copied the applicable html code to one of my views
4. Running the view, I see blank images.


What version of the product are you using? On what operating system?
Using Selector vs 1.3


Please provide any additional information below.
I think this might be due to my plugin based asset hierarchy. Simply put my 
image path is ~/Plugins/OpenId-Selector/images/*. Is there a way I can redirect 
the content path?

There's a typo in the license declaration in the header of the source files: 
licenced vs. licensed

What steps will reproduce the problem?
1. disable demo mode
2. choose openID
3. delete http:// from text field
4. Open Firebug (or equivalent) in debug mode
5. Click Sign in

What is the expected output? What do you see instead?
Expected: Nothing
Seeing: url is null error in Line 120 of openid-jquery.js:

if (url.indexOf("javascript:") == 0) {


What version of the product are you using? On what operating system?

1.3, any OS

Please provide any additional information below.

Fix is:
if (url && url.indexOf("javascript:") == 0) {

I see that there is an image for facebook in the image directory.  Yet it 
doesn't appear in the 
javascript file.  Is it intended to support Facebook?  I read that facebook is 
now embracing OpenID, 
but it's not clear how or if that's really in place or not.

It might be nice to at least note what the status of facebook integration is -- 
I'd like to offer that in 
my login panel if possible.

Hi,

thanks for this great piece of useful code.

I do not have easy access to a Windows machine and I needed to re-generate the 
sprite.

Did it in Ubuntu Linux with the attached scripts.  I hope they can be helpful 
to others.

They live in the same folder as generate-sprite.js and work the same way, i.e. 

$ generate-sprite.sh de

will generate the sprite for the de locale.

Best regards
Yuv

Xauth support to only show the most likely openid providers might be helpful. 

http://xauth.org/info/

Test whether Verisign's Seatbelt Firefox plugin currently interacts well
with the selector. At the moment, I don't see that the Verisign PIP URL
will be put into openid_identifier successfully.

There will be a range of browser plugins supporting OpenID released over
the next year or so. We should make sure they work well with the selector.

The 2.0 spec says: http://openid.net/specs/openid-authentication-2_0.html

The form field's "name" attribute SHOULD have the value
"openid_identifier", so that User-Agents can automatically determine that
this is an OpenID form. Browser extensions or other software that support
OpenID Authentication may not detect a Relying Party's support if this
attribute is not set appropriately. 

What steps will reproduce the problem?
1. attempt to login with aol
2. enter screenname
3. aol's openid login page has "screenname/" which doesn't work

What is the expected output? What do you see instead?
"screenname"


I fixed it by changing the javascript like this:
--- a/openid-selector/js/openid-jquery.js
+++ b/openid-selector/js/openid-jquery.js
@@ -17,7 +17,7 @@ var providers_large = {
     aol: {
         name: 'AOL',
         label: 'Enter your AOL screenname.',
-        url: 'http://openid.aol.com/{username}/'
+        url: 'http://openid.aol.com/{username}'
     },
     openid: {
         name: 'OpenID',

In addition to supporting form submission which will result in a browser 
redirect, the client selector should also support an AJAX workflow.

In this workflow, the user clicks on a provider and when AJAX is enabled a 
quick Javascript call is made to the server. The server makes an 
openid_immediate mode call to the provider to see if the user can be 
authenticated (because they logged in recently) without bothering to 
redirect the browser to the provider's page at all.

If the user can be authenticated in this way, the server updates the user's 
session and replies to the client selector to say that the user is now 
successfully logged in.

If the user can't be authorised, the AJAX method should be notified and the 
client selector can decide (based on whether a developer's method replies 
with true or false) whether to just prompt the user with an error message, 
ask for confirmation to redirect the browser or just go ahead and redirect 
the browser (default behaviour).

This feature will degrade nicely when Javascript is not available. It'll 
just not be available. The feature will be disabled by default.

In the best case scenario, this feature allows the user to be authenticated  
in a split-second without the browser page having to be refreshed at all.

We'll have to take care with providers like Google where you don't provide 
your username up front. The user may need a way of saying "log me into 
Google, but not as the user that I'm currently logged in with". This is a 
pretty rare use case, though.

What steps will reproduce the problem?
1. Use openid-selector under some chrome market app

What is the expected output? What do you see instead?
It should work just fine, but it doesn't. The page which is trying to submit 
the form to the provider does not work - returns error "Failed to load 
resource" inside the developer console.

What version of the product are you using? On what operating system?
Google Chrome 7.0.517.44 on Ubuntu Linux 10.10

Please provide any additional information below.
The interesting case is that it works when I open the target of the app iframe 
in a new tab. The only case when the form submission does not work is when it 
is invoked from within the chrome app. Perhaps a bug within Google Chrome app 
engine?

What steps will reproduce the problem?
1. Go to http://www.mindmelder.org/Users/Login
2. Click on OpenId
3. Click on Yahoo!
4. Invalid identifier is shown.

What is the expected output?

Redirect to Yahoo! login.


What version of the product are you using?

1.0

I think this may has something to do with cookies.

Hello,

Is there a way to allow users to authenticate in a popup window rather than 
redirecting them?

Thanks

Hello,

I installed openid-selector 1.0 (I really like the simplicity and
scalability of the interface) and php-openid 2.1.2 on my site. I ran some
tests. The auth works fine with my myopenid account. But I have 2 issues:
- Google returns "The server could not process your request." I cannot even
get to the login page and get a chance to use my Google account. What
should be done so that it works with Google?
- That works fine with my Yahoo account but there is an annoying message in
the Yahoo page that says "warning! This web site has not confirmed its
identity ...". Should I do something special with Yahoo so my site is not
flagged that way?

I realize those issues are not due to openid-selector since I get the same
problem when I use php-openid/consumer/index.php directly. But I am asking
you guys anyway as you may have run into this as well.

Many thanks,
MC

What steps will reproduce the problem?
1. Try to execute the demo (click on a logo)

What is the expected output? What do you see instead?
Expected: no idea.
What do you see instead: an error that examples/consumer/try_auth.php cannot be 
found.

What version of the product are you using? On what operating system?
1.0 on Kubuntu 10.04

Is it possible to create new 1.1 version of OpenID Selector based on version 
1.0 without Java OpenID Client? It should be a branch from version 1.0, fixing 
only above bugs, leaving current trunk code as version 2.0?

If you do not have time, I can do it. I have created a Drupal module 
integrating this project into Drupal core 
(http://www.gerixsoft.com/blog/drupal/openid-selector); while creating this 
module I have fixed the following bugs by myself:
http://code.google.com/p/openid-selector/issues/detail?id=9
http://code.google.com/p/openid-selector/issues/detail?id=10
http://code.google.com/p/openid-selector/issues/detail?id=11
http://code.google.com/p/openid-selector/issues/detail?id=12
and will fix
http://code.google.com/p/openid-selector/issues/detail?id=15
http://code.google.com/p/openid-selector/issues/detail?id=16
soon

But I do not want to keep this patched version for myself, but rather use 
"official" v1.1

Thanks,
Andriy

The page https://openid.net/get-an-openid/ lists yahoo japan and mixi as openid 
providers.

Maybe it makes sense to add them to js/openid-jp.js

yahoo_jp : {
                name : 'Yahoo JP',
                url : 'http://yahoo.co.jp/'
        },
mixi : {
                name : 'Mixi',
                url : 'http://mixi.co.jp/'
        },

Although I don't actually know whether those urls "work".

I'm not really sure what the best way to contribute to your project, and svn 
diff doesn't seem to include the picture in the diff.

Please let me know if you'd accept this. We'll likely be using this version of 
openid-selector in Snowy:
http://live.gnome.org/Snowy

I was happy to find this project, but needed a Prototype-compatible version.  
So, I downloaded the 1.2 ZIP file and made the necessary changes.  Attached is 
a patch file that replicates those changes, summarized here:

css/openid.css
Turns off the CSS entry hiding the openid_choice node.  Prototype, at least, 
can't override a 'display:none;' stylesheet entry.

demo-prototype.html
Retooling of demo.html to work with Prototype.

generate-sprite.rb
Retooling of generate-sprite.js to work with Ruby on a Linux or Mac system.  
Dependencies are listed in the file.

js/openid-prototype.js
Retooling of js/openid-jquery.js to work with Prototype.  I'm not a Prototype 
guru, so there's probably room for optimization of the code to be as 
streamlined as the jquery version.

js/prototype.js
Version 1.7_rc2 of the Prototype library.

I tried to minimize any changes to the existing code, only touching the CSS 
file because I had to.  However, If you distribute both versions together 
(and...why not?), it would probably be best to remove the "-jquery" component 
of the language-specific javascript filenames, as those aren't really 
library-dependent.

Anyway, hope this helps,
-Jonathan

I created a french local for openid-selector.

You can found the code on my github fork : 
https://github.com/krtek4/openid-selector/blob/master/js/locales/openid-fr.js

Please support Vietnamese language: http://pastebin.com/8JCMZJ2i

Thanks

What steps will reproduce the problem?
1. use Mac OS X
1b. change #! in remcomments to /usr/bin/sed
2. edit openid-en.js so only google yahoo and myopenid are 'providers_large'
3. put "echo ${LARGECMD}" on line 62.

What is the expected output? What do you see instead?
I think it should say
images.large/google images.large/yahoo images.large/myopenid tile 3x1 -geometry 
100x60>+0+0 large.bmp

instead:
images.large/google : {.gif images.large/yahoo : {.gif images.large/myopenid : 
{.gif -tile 3x1 -geometry 100x60>+0+0 large.bmp


What version of the product are you using? On what operating system?


Please provide any additional information below.

On firefox 3 in ubuntu only the google link does not work

It would be great to create a loading image that displays after the user has 
clicked on the selection.  This way users know that something is happening in 
the background.  I don't think you need to have a hide loading box since openid 
will redirect after complete.

I would be happy to create a solution for jquery if you want help.

There does not seem to be any way to contact the authors of this library.  I 
would like to ask permission to use the images provided by this project in 
order to construct an open source selector(not 100% openid) to be used with 
velruse, a python project.

What steps will reproduce the problem?
1. demo mode off
2. version 1.3, downloaded from google.code 2011-May-03, prototype.js 
compatible version
3. hooked to django via template customized for django-openid-auth
4. selector renders ok
5. click google or yahoo, button shows as depressed, "nothing" happens
6. click openid, enter a launchpad openid, works fine

What is the expected output? What do you see instead?
I expected depressing google or yahoo to immediately generate a form submission 
back to the server containing a request to login via openid using google or 
yahoo as the provider

What version of the product are you using? On what operating system?
1.3, downloaded 2011-May-03, clients tested are Google Chrome 10.0.648.204 and 
Firefox 3.6.16 on Ubuntu Linux 10.10

Please provide any additional information below.

I fixed this by changing the form handling a bit, see:

http://stackoverflow.com/questions/5867527/workaround-bug-in-openid-selector-pro
totype-js-version-that-disables-google-and

Also see attached file. 

Fixed version tested again with chrome and firefox.  Haven't tested IE yet.

What steps will reproduce the problem?

Open Latest zip -> view demo-uk.html

What is the expected output? What do you see instead?

English demo.

openid-jquery.js mixes tabs and spaces which breaks the indentation when viewed 
in editors with altered tab widths

I think 4 spaces is the best unit of indentation because it works in all 
editors exactly as intended.

only 4 spaces
http://javascript.crockford.com/code.html

only 2 spaces
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml#Code_forma
tting

only tabs
http://docs.jquery.com/JQuery_Core_Style_Guidelines

only tabs
http://github.com/mootools/mootools-core/wiki/syntax-and-coding-style-convention
s

Changing the else condition of the signin function to :

        } else {

            openid.provider_url = provider['url'];
            if (! onload) {
                $('#openid_form').submit();
            }
        }

Fixes it for me.

The problem is that the submit function overwrites the hidden url field
with your cookie's provider instead of the one the user clicked on.