communiteq / discourse-adsense Goto Github PK

It looks like there was a change recently in discourse that is not compatible with this plugin.

discourse/discourse@bb0cf87

As mentioned here.

I had a quick look and I guess that topic.js.handlebars needs to be updated. I don't know if you would want to somehow maintain backwards compatibility or I would have changed it myself.

I try entering my Adsense id(ca-pub-xxxxxxxxxxxxxxxx) in settings and it keeps giving me this error.

Sorry, an error has occurred.

Plugins nowadays use the app.yml, afaik.

Also I can't seem to find the plugins dir. I installed discourse through a docker image.

Hi, restoring adsense settings to default doesnt work.

Actual situation: when my adsense settings are already set and I want to click "restore to default" button, field is restored but button "green and red" show up and when I click on "green" button to save changes it doesnt work and give me an error:

For all adsense plugin buttons it is the same, for other discourse settings its all fine so its not Discourse itself problem I believe.

I'm using latest discourse version.

This was tested on 0.9.9.18 and on 1.0.0

Hello, this plugin breaks the spinner animation on Discourse.

https://meta.discourse.org/t/suggested-topics-displayed-as-en-undefined/23415/7?u=sb56637

I'm on Discourse 1.2.0.beta4, and I believe this breakage is new to beta4.

More details on this Discourse thread.

Sample URL that throws 400 Bad Request - http://googleads.g.doubleclick.net/pagead/ads?client=ca-3057518829752896&format=1200x90&output=html&h=90&slotname=8324390168&adk=2394456988&w=1200&lmt=1419260729&orig_w=728&flash=16.0.0&url=http%3A%2F%2Fforum.duggout.com%2Ft%2Ftamil-cricket-memes%2F92%2F1&dt=1419260729264&bpp=215&bdt=190543&shv=r20141209&cbv=r20141212&saldr=aa&correlator=123572129793&frm=20&ga_vid=339299047.1412183372&ga_sid=1419260705&ga_hid=1015909997&ga_fc=0&u_tz=330&u_his=5&u_java=1&u_h=1050&u_w=1680&u_ah=1028&u_aw=1676&u_cd=24&u_nplug=12&u_nmime=44&dff=helvetica&dfs=14&adx=238&ady=85&biw=1676&bih=481&eid=33995343%2C317150304&oid=3&rx=0&eae=0&fc=8&brdim=4%2C22%2C4%2C22%2C1676%2C22%2C1676%2C1028%2C1676%2C481&vis=1&abl=CS&ppjl=u&srr=1&fu=0&bc=1&ifi=1&xpc=WfMSdd7rX6&p=http%3A//forum.duggout.com&dtd=481

I want to show ads only at the top of topics, but not at the bottom of topics (due to #33) or at top of the topic list.

However, if only the "Show ads on top of the topic" checkbox is checked, no ads are displayed at all. Here is a screencast:

I have to check "Show ads on top of the topic list" as well in order to display topic top ads, but I don't want topic list ads.

Non docker information does not work. git link is httpS and needs .git at the end.

use the commands provided but paste your own git clone url.

Please see https://meta.discourse.org/t/upgrade-failed-due-to-adsense-plugin/28671/5

When upgrading to 1.3.0-beta8, there's an error during build which prevents the Discourse instance working.

Fixing the </br> to <br> or <br/> allows Discourse to build but then it only serves a blank white page

Any guidelines on using responsive ads? The README mentions desktop and mobile separately, but AdSense now offers auto-sizing ads.

Added the plugin through app.yml

hooks:
  after_code:
    - exec:
        cd: $home/plugins
        cmd:
          - mkdir -p plugins
          - git clone https://github.com/discourse/docker_manager.git
          - git clone https://github.com/discoursehosting/discourse-adsense.git

then apply the change with
/var/docker/launcher rebuild app
but the adsense menu is still not added to admin page.

anything I missed?

Discourse version 0.9.9.8

Any attempt to enter in information on the admin screen for any adsense entries results in a "Sorry, an error has occurred." message.

This plugin leads to a bug on Discourse 1.2.0.beta4 where it causes the "Suggested Topics" text to be displayed as "[en.undefined]":

https://meta.discourse.org/t/suggested-topics-displayed-as-en-undefined/23415

I disabled the Adsense plugin and rebuilt, and the bug goes away. Re-enabling the Adsense plugin makes the bug come back.

For those who are evaluating discourse, could you please add screens of the various display options to the readme?

During discourse upgrade there seemed to be an unexpected issue. Upon further reviewing the log, I found out a mention about an invalid
tag in the plugin. After that I tried to rebuild discourse from terminal, but not long after executing the rebuild command, it returned with an error about failing to install bootstrap. I then removed the git link from app.yml and ran the rebuild command again and then everything seemed to work as it should have. So I suppose there are some compatibility issues with this plugin. I hope this issue will be fixed soon, this was a great plugin (until it started showing problems :P)

P.S If you require, I can recreate the issue and submit a screenshot.

This issue keeps recurring - #7, #25, and now in my installation:

Ads functioned fine during a trial period. I then disabled them for a month, and now I can't enable them again. Whenever I check one of the checkboxes to show ads, I get that unhelpful error. Can something be done to expose more about what the actual error is?

I'm running v1.5.0.beta10 +14.

Hi there,

I just installed discourse-adsense on Discourse 1.2.0.beta3. I noticed that the page navigator sometimes ends up being placed right on top of the Adsense unit, which is probably a violation of the Adsense rules.

Thanks very much for this very necessary extension!

For very short topics (e.g. 1 message), it's jarring to see two ads surrounding the content.

Ideally, only one ad would be visible at one time, i.e. when loading a topic, the topic bottom ad should be below the fold or not present (and when scrolling down, the topic top ad would scroll out of view by the time the topic bottom ad becomes visible).

Hey there, i thought in the latest release the bug was fixed that I have to manually reload the page to see my adds! I tested it right now but some of my adds only show up after 'refreshing' the page. The top ad on top of the topic list always seems to show even without refreshing but the bottom ad and the top topic ad never seem to show without a proper refresh.

In a previous release this seemed to work fine. Could you please fix this? I'd be so happy :D

The plugin is not generating the specific line of code that Google Adsense is expecting to see in order to validate the site. How can this be fixed? See attached.