comparethemarket / chai-nock Goto Github PK

Hi,

I've been trying to get chai-nock to work with asynchronous code but have failed so far unfortunately.

Let's say I have a function that make a PUT request: async function makePost() and I try to verify the payload. When I try to test it with mocha like this:

describe("example", () => {
  it("should work", () => {
  const scope = nock(Url)
      .put(/.*/)
      .reply(200, "foo");

  makePost().should.be.fulfilled.and.eventually.deep.equal("foo");
  scope.should.have.been.requestedWith("my expected payload here");
});
});

Then this never works: I get errors from chai-nock that the request didn't match:

AssertionError: expected Nock to have been requested with exact body 'my expected payload here', but was requested with body undefined

To me that looks like the request is checked before the asynchronous function actually resolves. Unfortunately, I have not been able to properly defer the check. I have tried to use chai-as-promised, declaring the test function in it() as async and awaiting the result of makePost and probably various other things, but they all result in the same outcome (only sometimes it is masked by the fact that the assertion fails in a non-resolved promise that is only sometimes reported as a warning by node).

Is there a way how I could make this work? I really need to support async functions unfortunately.

Hi! We've started making beta releases toward the next major release of nock. Would you be up for giving one of them a shot in some tests for this library to help us ensure compatibility?

Note that v11, when it's released, will drop support for Node 6.