compivar / flixter

Project 1 - Flixter

Flixter is a movies app using the The Movie Database API.

Time spent: 15 hours spent in total

User Stories

The following required functionality is complete:

• User sees an app icon on the home screen and a styled launch screen.
• User can view a list of movies currently playing in theaters from The Movie Database.
• Poster images are loaded using the UIImageView category in the AFNetworking library.
• User sees a loading state while waiting for the movies API.
• User can pull to refresh the movie list.
• User sees an error message when there's a networking error.
• User can tap a tab bar button to view a grid layout of Movie Posters using a CollectionView.

The following optional features are implemented:

• User can tap a poster in the collection view to see a detail screen of that movie
• User can search for a movie.
• All images fade in as they are loading.
• User can view the large movie poster by tapping on a cell.
• For the large poster, load the low resolution image first and then switch to the high resolution image when complete.
• Customize the selection effect of the cell.
• Customize the navigation bar.
• Customize the UI.
• Run your app on a real device.

The following additional features are implemented:

• List anything else that you can get done to improve the app functionality!

Please list two areas of the assignment you'd like to discuss further with your peers during the next class (examples include better ways to implement something, how to extend your app in certain ways, etc):

1. I need to review fetching the images,titles, and descriptions from the movie database using the API because I do not understand API's very well.
2. I should discuss creating classes, identifiers, and connecting outlets because I just went through the motions. I am not comfortable working with these things by myself.

Video Walkthrough

Here's a walkthrough of implemented user stories:

GIF created with Kap.

Notes

Describe any challenges encountered while building the app. Installing Cocoa Pods was time consuming and confusing. Setting up Github was also time consuming and confusing. Understanding how Objective-C works in XCode was confusing

Credits

List an 3rd party libraries, icons, graphics, or other assets you used in your app.

• AFNetworking - networking task library

License

Copyright [2022] [Isaac Varela]

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

flixter's Issues

Project Feedback!

Nice work! The purpose of this project was to continue learning Objective-C and the Cocoa Touch (iOS) framework. You should be comfortable creating table views (one of the most common views in iOS) and working with array of dictionaries created from JSON (in this case from the Movies Database API).

A key part of these projects is that you work to polish the visuals and the small UI / UX touches. Developing your design sense is an important part of being a mobile engineer. You'll find that perfecting the UI / UX will often lead to interesting technical challenges as well because the libraries may not behave exactly as you want them to, so you'll have to learn how to achieve the effect that you want. A few other things to note:

• Did you use groups to organize your source files? It's pretty common to organize your source files into Groups, especially for larger projects. You can organize by type of class (i.e. View Controllers, Views, etc) or for larger apps by functionality (i.e. Home Screen, Search Screen, etc).
• Did you minimize the number of public methods and properties in your classes? You should always try to minimize the number of properties and methods that are in the header files. Only expose what you have to, e.g., properties and methods that must be accessed by other classes.
• Did you properly set the Content Mode for your ImageViews? By default the UIContentMode will stretch the image to match the dimensions of the image view, which is probably not what you want. The most common combination is to use Aspect Fill combined with clipping subviews.

Feedback

Style

This is a good reference for coding style: https://github.com/NYTimes/objective-c-style-guide

Class name and File names should start with Capital Letters. ✅

Properties and local variables MUST be camel-case with the leading word being lowercase. ✅

Properties should be accessed using self.propertyName instead of _propertyName. ✅

My personal opinion for your naming:

DetailsViewController should be name MovieDetailsViewController.
myArray is not a descriptive name. movies or movieArray would be a better name.

Remove unused files

ViewController.h and ViewController.m are not used, so you should remove them.

Reusing your details view controller

Think about how you can reuse the same detail view controller when you tap on a cell in your collection view.

Commit Messages

Commit messages should follow these guidelines: https://cbea.ms/git-commit/

Since this is the first project, I do not expect you to have commits, but in the future, please add a commit for every feature.

Logging

You should be logging every function in your application. This will help you understand your function call order. In production app, you'll likely be logging errors and crashes. You will also be tracking every user action.

NSLog(@"%@", NSStringFromSelector(_cmd));

- (void)viewDidLoad {
    [super viewDidLoad];
    NSLog(@"%@", NSStringFromSelector(_cmd));
}

I personally add my initials to my log messages on my personal projects because it makes it easy for me to filter because you will receive log messages from various places.

My log messages look like this:
NSLog(@":NC: %@", NSStringFromSelector(_cmd));

UITableViewDelegate

You could also use UITableViewDelegate to navigate to details screen instead of segues.

Step 1

Conform to the UITableViewDelegate

@interface MovieViewController () <UITableViewDataSource, UITableViewDelegate>

You'll also need to specify to the table view who the delegate is which is similar to how you specified to the table view who the data source was.

    self.tableView.dataSource = self;
    self.tableView.delegate = self;

Step 2

Implement didSelectRowAtIndexPath method of UITableViewDelegate interface.

- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath {
    
}

Step 3

Add a storyboard id for your details view controller

Step 4

You will instantiate your view controller from storyboard and push it with your navigation controller. Navigation Controller will be nil if you did not embed your view controller in a navigation controller in storyboard.

- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath {
    UINavigationController *navigationController = self.navigationController;
    MovieDetailsViewController *viewController = [self.storyboard instantiateViewControllerWithIdentifier:@"MovieDetailsViewController"];
    viewController.movie = self.movies[indexPath.row];
    [navigationController pushViewController: viewController animated:YES];
}