concretecms / concretecms

Official repository for Concrete CMS development

Welcome to the official repository for Concrete CMS development! Concrete CMS is an open source CMS built by people from around the world. Want to get involved? Check out our contributor guide for more info.

Documentation

If you're looking for Concrete CMS documentation, you'll want to navigate over to documentation.concretecms.org. If you see anything that needs more information or is just completely wrong, contributions are welcomed! Just log in to the documentation site with your community.concretecms.com account and edit away!

Installation

1. Clone the repository

    git clone https://github.com/concretecms/concretecms.git
    cd concretecms/
   

2. Use Composer to install the third party dependencies

    composer install
   

Community Channels

• Forums

Legacy

This repository is for Concrete CMS 9.0 and later. Looking for earlier versions?

• concrete5 8.x can be found in the 8.5.x branch.
• concrete5 5.7.x can be found in the 5.7.x branch.
• Looking for concrete5 5.6 and earlier? Head over to the concrete5-legacy repository.

(Note: Concrete CMS used to be called concrete5 – which hopefully explains the name of various GitHub repositories and projects.)

concretecms's Issues

URL generated for Dashboard Panel when on Dashboard Pages incorrect

It appears that the ajax request that gets made when you are on a dashboard page and you click the dashboard panel icon in the upper right hand corner is incorrect.

For example, when you are on/index.php/dashboard/sitemap/search Instead of generating /index.php/ccm/system/panels/dashboard, it generates /index.php/system/panels/dashboard which causes a 404 not found and bugs up being able to minimize the right panel when you are on a dashboard page and also causes the right panel to become greyed out.

can't install, table creation mistake

During install I get this:
An exception occurred while executing 'alter table QueueMessages add FOREIGN KEY (queue_id) REFERENCES Queues (queue_id) ON DELETE CASCADE ON UPDATE CASCADE': SQLSTATE[HY000]: General error: 1005 Can't create table 'c5_57.#sql-2848_41' (errno: 150)

195 tables are still created so I don't know why it just stops there

[Edit:]
Well aparently it was due to an older version of MysQL I believe. I updated and it installed past that error but now it blocks when installing blocks and throws this error:
An exception occurred while executing 'CREATE TABLE btContentLocal (bID INT UNSIGNED NOT NULL, content LONGTEXT DEFAULT NULL, PRIMARY KEY(bID)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB': SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'btcontentlocal' already exists

I know have 221 tables created

Dashboard Re-Skin: Reports > Logs

need to reskin for 5.7.

Dashboard Re-Skin: Users > Groups > Edit Group

PageType Composer rendering two sets of custom attributes

see attached

/concrete/core/legacy/loader.php missing package routing

needs package routing:

public static function helper($service, $pkgHandle = false) {
if($pkgHandle){
return Core::make('/packages/'.$pkgHandle.'/helper/' . $service);
}else{
return Core::make('helper/' . $service);
}
}

custom attributes do not render form.php, only method form();

Composer rendering of custom attributes seems to be ignoring form.php. form() method seems to work though.

Add jquery.min.map file

Adding in the jquery.min.map file to remove the pesky 404 for chrome users, also to potentially help with debugging future javascript issues.

Proposal to Improve/Fix block template loading and support package overrides

Originally from @pietschy

Hi all,

I've just been implementing a theme and wanted to provide template overrides for another package (in this case problog). This didn't work and the only option was to put them in /blocks/. This situation is pretty painful from the perspective of both the theme developer and end user so I decided to see if it was fixable.

In looking at the code I found that themes (in packages) could override custom block templates from other packages, but it's random chance and only happens if the theme is the last package searched by BlockViewTemplate->createView().

I implemented a quick fix to always search the package of the current theme last. This fixed the issue for custom templates.

Rather than stop there I tried to get my head around the rest of the code and I think it might be possible to for themes/packages to override the default view template as well (rather than just custom templates). It think it could also be made considerably DRYer with the use of a couple of standard design patterns.

I've created a gist (https://gist.github.com/pietschy/7241034) with my thoughts along, comments and findings before I go changing too much (I've already made the theme the last package to search). My code comments/notes are prefixed with 'AP: '.

Please Note: the gist is based on 5.6 but 5.7 looks the same except for the addition of the new asset handling (which would continue work as is in the approach I'm proposing).

I'd be happy to have a crack at this. Does anyone see any gotchas, snake holes or other reasons why I should run away???

btContentLocal table seems to be installing twice.

The install fails because btContentLocal is trying to be created in MySQL and it was already installed in the setup script.

Install concrete5
Version 5.7.0a3

An exception occurred while executing 'CREATE TABLE btContentLocal (bID INT UNSIGNED NOT NULL, content LONGTEXT DEFAULT NULL, PRIMARY KEY(bID)) DEFAULT CHARACTER SET utf8 COLLATE utf8_unicode_ci ENGINE = InnoDB': SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'btcontentlocal' already exists

Dashboard: Reskin Cache Settings Page

Use the following page:

/dashboard/system/basics/site_name

as an example.

Update Bootstrap to 3 to latest stable.

Would it be possible to make sure bootstrap 3 is up to the latest and greatest? For some reason I remember thinking that some stuff changed between 3.0 and 3.1.1 as far as some mixins re-factoring, but with this being the latest and greatest in c5, it would make sense for it to be on the most current version of bootstrap if that's possible without to much effort.

Package Custom Attribute Types needs love

• installer not seeing package custom attribute db.xml
• package helpers need help
• custom attributes do not seem to see and render form.php, only method form();

Dashboard Re-Skin: Reports > Surveys

There's no comp for this. Same advice in the Dashboard > Reports > Forms goes for this one.

Dashboard > Panel Minimizing

Minimizing the dashboard panel should make the content fill the entire area in a fluid fashion. Bringing it back should collapse the content back down (and not load the dashboard panel twice, which is what happens now.) This should make certain content-centric views like the file manager work really well in larger horizontal monitors.

Update jQuery to latest 1.X version

http://jquery.com/download/#jquery-1-x

Currently running jquery v1.9.1, latest is 1.11.0, also included in this request should be to include the jquery.min.map file to remove the 404 for chrome users, and to potentially improve debugging javascript in the future.

Exit Edit Mode - Help Interstitial

When exiting edit mode, we should add some help text explaining the difference between publish and save (save exits edit mode but it doesn't approve the version.) Here is a design for this.

This should use the existing help subsystem found in concrete/helpers/concrete/help.php (perhaps add a new help category in there for panel interstitials?)

Delete Member indicates success, but user remains

When I select "Delete" button on the individual member's page in the dashboard, I am told that the delete was successful, however the user remains in the database and still appears to be untouched.

Name casing issue? Fatal error in core/Foundation/ClassLoader.php line 51

Trying to install in root directory and am getting this error:

"Warning: Class '\Concrete\Core\Routing\URL' not found in /var/www/concrete/core/Foundation/ClassLoader.php on line 51"

Wondering if this is a name casing issue.

Seems to be causing the Javascript Enabled check to appear as though it's disabled.

Gathering Block - Style on Reload

When adding the gathering block to a page, it doesn't seem to take its styles into consideration until a reload of the page – although stylesheets SHOULD be injected by the AJAX reload of the block.

Dashboard Re-Skin: Reports > Forms

need to reskin for 5.7.

Blank page on index.php

I cloned the repo in a local directory called "c57". While trying to install, going to c57/index.php resulted in a blank page. If I go to c57/index.php/install, I was able to see the install page.

Reduce Padding for floating menus

Currently the box around the save and cancel is huge (30 px padding)
30px (current) screenshot: http://screencast.com/t/HsPPwBVNo
15px screenshot: http://screencast.com/t/d0ObTx0F
12px screenshot: http://screencast.com/t/LNL97YdK1
10px screenshot: http://screencast.com/t/FRkQJUzEK

Opinions on reducing the padding?

Page -> Design -> Custom -> Font Panel

There is a barebones font panel in the customize theme panel that we need to rework.

1. This should use underscore for any JavaScript templating that needs to take place.
2. 100% fidelity to this comp isn't required, but we do want the design to look updated, and to include the new fonts, etc...
3. Don't worry about including the color with the text. That's not necessary. The color can be handled by a different directive.

Rework old unit tests to work with 5.7.

Install fails when not connected to internet or with a proxy

Can not do a clean install unless you have valid connection to the internet. Seems like weird requirement.

You get a php error at Line 228 in file ../core/File/Service/File.php.

if (Config::get('HTTP_PROXY_HOST') != null) {

Installer not seeing package custom attribute db.xml

Custom Attribute Types db.xml not installing when attribute type is added.

Dashboard Re-Skin: Users > Community Points

need to reskin for 5.7.

Error adding a new layout: arLayoutColumnWidth doesn't have a default value

While trying to add a layout to an area I receive this error:

An exception occurred while executing
'insert into AreaLayoutCustomColumns (arLayoutColumnID) values (?)'
with params ["1"]:
SQLSTATE[HY000]: General error: 1364
Field 'arLayoutColumnWidth' doesn't have a default value

Dashboard Re-Skin: Users > Groups > Edit Group Permissions

Very minor button style issues in modal dialog

Dashboard Re-Skin: Reports > Statistics

need to reskin for 5.7.

Dashboard Re-Skin: Users > Groups > Move Group

Gathering Block - Remove Data Source

Data source tiles loaded from a removed gathering data source stay in the gathering block. Removing a data source should also removed the tiles it pulled in.

Invalid datetime format when updating users table

latest master version on MariaDB 5.5.31 gives me

An exception occurred while executing 'update Users set uLastIP = ?, uLastLogin = ?, uPreviousLogin = ?, uNumLogins = uNumLogins + 1 where uID = ?' with params [false, 1398363097, "0", "1"]: SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect integer value: '' for column 'uLastIP' at row 1

\Concrete\Core\Attribute\Set needs class use

needs:

use \Concrete\Core\Attribute\Set as AttributeSet;

Page -> Location Detail Panel -> Additional Page Paths Don't Save

Additional page paths are addable in the page properties location detail panel, but they don't save. This functionality needs to be added to the /concrete/controllers/panel/detail/page/location.php controller.

Page -> Preview Page as User

Currently, if you enable advanced permissions in 5.7.0-wip you'll get "Preview Page as User" in the lefthand page panel. This panel currently doesn't do anything. We need to do the following.

Create a route for a new sub-panel in config/routes.php, routing to a new controller: $rl->register('/system/panels/page/preview_as_user', 'PagePreviewAsUserPanelController::view');

Create a new controller panel for this.

Add a view for this panel at views/panels/page/preview_as_user.php that our controller is set up to use.

Make this panel actually contain the fields from the old preview as user dialog box.

Make this panel look like the other panels using the .ccm-panel-dark() mixin. Add CSS information to ccm_app/panels.less and ccm_app/panels/preview_as_user.less where necessary.

The timed permission list also still has to continue to work on this page.

Reference the existing preview panel detail view and modify it to accept optional date and time parameters.

Make sure the new request library is set up to honor passed-in datetimes as well as users.

Support for installation via the composer package management utility

Add a composer.json file to the main concrete5 repository so that it can be installed via composer.

recreating this since it was closed when when you were moving issues over to 5.7 and never re-opened.

After installation, fatal error on Fatal error: Class 'Concrete\Block\Autonav\NavItem' not found in autonav/controller.php on line 368

Finally was able to slog through the installation. After that, I was greeted with this error:

Fatal error: Class 'Concrete\Block\Autonav\NavItem' not found in /var/www/concrete/blocks/autonav/controller.php on line 368

Fatal Errors during installation

Fatal error: Class 'Concrete\Block\Form\Statistics' not found in /yada-yada/web/concrete/blocks/dashboard_site_activity/controller.php on line 38

Also, core/File/Service/Image.php lines 201 and 211: Imagick s/b '\Imagick'.

5.7.0a3 -- both Sample Content and Empty installs

Dashboard Re-Skin: Users > Groups > Group Sets

Need to reskin for 5.7 and actually make them work in the dashboard.

Modify Attribute Panel CSS to make it Readable

Currently the text in the Attribute Panel for pages is basically unreadable,

The CSS should be changed to make it lighter, and have rollover effects

Doublecheck Topic Permissions

Make sure that topic tree permission keys are right, that all of them are being set properly, and that they have sensible defaults. Doublecheck that we REALLY only need the view topic permission? (that doesn't seem right.)

Add automatic scrolling when moving block

It would be nice if when dragging a block towards the top of the page or towards the bottom of the page, the page would actually start to scroll. Right now the only way I've found to move a block somewhere off screen is to click and drag, and simultaneously use the mousewheel or keyboard to page up/down.

Page -> Design -> Custom -> Color Picker

Swap out the builtin jquery colorpicker library with the spectrum library: http://bgrins.github.io/spectrum/

Make sure that its files are registered in concrete/config/assets.php

Make sure the built-in color helper works with this library.
Customize the CSS to make it have a black background similar to this comp.

Don't worry about matching the comp 100% – we don't need the opacity slider to work exactly this way, etc... (although there is a setting in spectrum that works with opacity so lets include that option.)

Make sure that design panel works with this new javascript library.

Fix grunt build warnings in JS

Fix the issues with the JavaScript as raised by grunt in preparation for possible future JSHint integration

Port ancient block template SimpleTest unit tests to work with 5.7.

Conversations sort by rating doesn't work.

Choosing flat view - highest rated doesn't work.

ConversationMessageList::sortByRating doesn't exist.

Toolbar display changes

I know that due to trying to go with a more sleek, mobile friendly design, it was sort of decided to leave off the text on the buttons in the toolbar. However, I think using the bootstrap tooltips might be a good middle ground. This will certainly help desktop users get a good idea of what is what in their toolbar.

Sample: http://getbootstrap.com/javascript/#tooltips - thinking tooltip bottom

Integrate redactor 9.x

Redactor 8.x has a lot of editing bugs...