conjure-up / urwid-ubuntu

Standarized set of urwid widgets to use within Ubuntu Console Applications

ubuntui

Standarized set of urwid widgets to use within Ubuntu

urwid-ubuntu's Issues

YesNo widget (and by extension Selector) should accept "default"

You should be able to specify whether "yes" or "no" is selected by default for a YesNo widget (with the default presumably being None which would select neither).

Footer widget should accept buttons

Or there should be a ButtonBar widget that can be used as a footer. It should at least capture what conjure-up does in, e.g., SpellPickerWidget._build_footer, and ideally it would be able to handle the buttons in a somewhat generic way.

Build on top of universal API

urwid is only supported for Linux through series of low level fcntl calls.

  File "conjureup\app.py", line 18, in <module>
    from ubuntui.ev import EventLoop
  File "C:\Python36\lib\site-packages\ubuntui\ev.py", line 15, in <module>
    class EventLoop:
  File "C:\Python36\lib\site-packages\ubuntui\ev.py", line 22, in EventLoop
    'screen': urwid.raw_display.Screen(),
  File "C:\Python36\lib\site-packages\urwid\raw_display.py", line 89, in __init__
    fcntl.fcntl(self._resize_pipe_rd, fcntl.F_SETFL, os.O_NONBLOCK)
NameError: name 'fcntl' is not defined

This is not portable.

Add additional palettes for terminals that do not support 256 colors

We should add some fallback palette's for terminal that may not support 256 colors

YesNo widget confusion between "Yes" and True

I'm using a boolean input type in a conjure-up spell:

https://github.com/kwmonroe/spells/blob/feature/cdk-log-monitor/canonical-kubernetes/steps/05_logging/metadata.yaml#L8

That's the 'ol YesNo widget that takes "Yes" and "No" strings for initial values:

https://github.com/conjure-up/urwid-ubuntu/blob/master/ubuntui/widgets/input.py#L180

The problem is when you go to check the value() of that widget, it gets mangled into True|False:

https://github.com/conjure-up/urwid-ubuntu/blob/master/ubuntui/widgets/input.py#L160

It would be nice if there was consistent behavior -- either YesNo strings or True/False.

Needs screens

README.md would benefit fro some visual content,

TagMarkupException

https://sentry.io/canonical-pj/conjure-up/issues/305974052/

TagMarkupException: Invalid markup element: None
  File "conjureup/controllers/deploystatus/gui.py", line 19, in _refresh
    view.refresh_nodes(app.juju.client.applications)
  File "conjureup/ui/views/deploystatus.py", line 42, in refresh_nodes
    service_w = ServiceWidget(application.name, service)
  File "ubuntui/widgets/juju/service.py", line 20, in __init__
    w = UnitWidget(n, unit)
  File "ubuntui/widgets/juju/unit.py", line 18, in __init__
    self.PublicAddress = Text(unit.get('public-address', ''))
  File "urwid/widget.py", line 836, in __init__
    self.set_text(markup)
  File "urwid/widget.py", line 879, in set_text
    self._text, self._attrib = decompose_tagmarkup(markup)
  File "urwid/util.py", line 375, in decompose_tagmarkup
    tl, al = _tagmarkup_recurse(tm, None)
  File "urwid/util.py", line 416, in _tagmarkup_recurse
    raise TagMarkupException("Invalid markup element: %r" % tm)