GithubHelp home page GithubHelp logo

Comments (7)

luislavena avatar luislavena commented on August 17, 2024

Hello,

Please create a pull request instead, extra points if you do it using topic branches.

from rb-readline.

rocky avatar rocky commented on August 17, 2024

Pull request range updated.

from rb-readline.

Spakman avatar Spakman commented on August 17, 2024

I've added pull request 36, which I believe fixes this issue.

from rb-readline.

rocky avatar rocky commented on August 17, 2024

Comment added inside pull request 36.

from rb-readline.

luislavena avatar luislavena commented on August 17, 2024

Guys, appreciate the contributions, but you're driving me crazy :P

Can you guys exchange IM and coordinate bug reports or pull requests?

Asking this because have 3 open pull requests and several bug reports that deal with the same thing.

Thank you.

from rb-readline.

Spakman avatar Spakman commented on August 17, 2024

Hi luislavena!

I'm not sure what to suggest. I really want to make your life as the project maintainer as simple as possible.

I wanted to link my pull request (36) to this issue, but I couldn't find a way to do it in the GitHub interface. I did try to keep my pull request as simple as possible by making it a topic branch from upstream.

What would you like us to do to solve this? I can edit my pull request (which GitHub confusingly also calls an issue) to include the details of this issue and then you can close this issue if you like? Have you any other suggestions?

Perhaps some sort of contributer documentation would be useful to help us all avoid this sort of situation in the future.

from rb-readline.

luislavena avatar luislavena commented on August 17, 2024

Merged this as part of Pull #36 on commit 271d9f7

Thank you!

from rb-readline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.