not multi thread friendly about rb-readline

[rdp]

the offending code seems to be
class Win32API
...
@func = DL::CFunc.new(handle[func], TYPEMAP[export.tr("VPpNnLlIi", "0SSI")], func)
...
ret, = @func.call(args)

does this mean that win32api is the cause, i wonder?

[luislavena]

Can you provide a detailed use case? Please, I'm not expert on the code so need test cases to verify and investigate solutions.

[rdp]

certainly.

RbReadline::RB_READLINE_VERSION
=> "0.1.2"
Thread.new { loop { sleep 1; puts '.'; } }
=> #<Thread:0x29ed640 sleep>

Now dots from that thread should appear once per second--you'll notice that they don't. That's about it.

[luislavena]

Neither does a normal program until you do Thread#join.

Anyhow, this is related to the scan of events from the keyboard.

Can you test this over Linux/OSX? Tools like Highline and AFAIK GNU Readline suffered the same.

[rdp]

Interesting. Linux 1.8.7 with pure ruby seems to not have this problem. Linux 1.8.7 with gnu readline seems to not have it, either.

windows seems to have the problem with both gnu readline and pure ruby readline.

Thankfully it's not a problem that people really care about. I think it's more of a feature request for the win32api people [?]

[luislavena]

Actually is a known threading issue with Ruby and Windows. win32utils guys worked on a patch for Ruby's select() that never got integrated.

[rdp]

gotcha--it's a problem that select in doze by default can't handle stdin or what not. anyway I made the request to the win32 guys so it's up to them now.
Thanks!
-r

[rdp]

I believe this is more of a core problem

[luislavena]

Hello, is this still valid on current releases of RubyInstaller and master?

Please update this with your testing.

Going to close this if no update is given.

Thank you.

[luislavena]

Hello,

Latest rb-readline already support this:

require 'readline'

Thread.new { loop { sleep 1; print '.' } }

loop do
  line = Readline::readline('> ')
  Readline::HISTORY.push(line)
  puts "You typed: #{line}"
  break if line == 'quit'
end

Works properly.

Closing this out.