GithubHelp home page GithubHelp logo

Comments (3)

luislavena avatar luislavena commented on July 18, 2024

Hello @oTnTh and thank you for your report, however I don't have a Simplified Chinese Windows to test or fix this.

I would accept however a patch that correct this issue 😃

Thank you.

from rb-readline.

oTnTh avatar oTnTh commented on July 18, 2024

I didn't read whole sources of readline and rb-readline, so perhaps it's a stupid question. When input.c:rl_getc() returned 0xFE, caller should decied it's a normal character or something worng, but I cannot finger out why we should check READERR in readline_internal_charloop(), is it necessary?

from rb-readline.

phasis68 avatar phasis68 commented on July 18, 2024

The READERR check is for non Windows platform.

How about modifying
if (c == READERR)
to
if (RUBY_PLATFORM !~ /mswin|mingw/ && c == READERR)
?

from rb-readline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.