Comments (7)
Absolutely. We can close this ticket since it was just a discussion, and I'll send separate PRs for the tools I listed above.
from koji-containerbuild.
One other reason for merging these into koji-containerbuild is that eventually if kojiweb ever becomes pluggable, we could do things like "diff RPMs" in the kojiweb interface.
from koji-containerbuild.
Hi Ken,
That would be very nice to have! +1
Cc @twaugh @MartinBasti @rcerven
I am also wondering if we would be able to extend these in the future to find content based on cachito stored data.
from koji-containerbuild.
Hello, we discussed about this and the best solution seems to create a new repo within this namespace, called osbs-scripts
or osbs-tools
(name TBD)
koji command should stay minimal, this builds on top of current koji api so we should have it in different tool to not make mess in koji CLI itself.
There is also open question if we should:
- create a set of isolated scripts
- create one script with subcommands
from koji-containerbuild.
There is a discussion on koji-devel about moving some of the koji-tools scripts into koji
CLI sub-commands. That is why I think it could be useful to do that here.
Here are the specific reasons I wanted to build this into koji-containerbuild (or some common library):
-
When I am walking new team members through the process of building containers, it is already really difficult to understand dist-git, rpkg, kerberos, etc. If we add an entirely separate set tool on top of that, it raises the barrier to entry, which makes OSBS harder for users to understand and contribute.
-
In Ceph, we have internal tooling that already uses the logic I've written for
koji-container-signatures
. Ideally this container-signature-checking would be a library that other higher-level Python tools could call, rather than a standalone script. Also, there are other internal tools (MetaXOR) that would benefit from sharing methods likeparse_rpm_signatures()
if they were in a real library.
from koji-containerbuild.
OK, if this is a way how koji devs wants to handle such toolings, we can reevaluate that decision.
from koji-containerbuild.
We agreed to go with the same approach as koji then. Are you willing to contribute patches to koji-c for this?
from koji-containerbuild.
Related Issues (20)
- CI builds failing
- [packit] Propose update failed for release koji-containerbuild-0.7.20-1
- [packit] Propose update failed for release koji-containerbuild-0.7.20-1
- [packit] Propose update failed for release koji-containerbuild-0.7.20-1
- [packit] Propose update failed for release koji-containerbuild-0.7.20.1-1
- [packit] Propose update failed for release koji-containerbuild-0.7.20.1-1
- [packit] Propose update failed for release koji-containerbuild-0.7.20.1-1
- [packit] Propose update failed for release 0.7.21
- Lack of Dockerfile checkout for Flatpaks can bypass plugins HOT 2
- getTaskResult returns stringify'd ints for koji_builds HOT 1
- consider relaxing jsonschema 3.2.0 requirement HOT 3
- PyPI release HOT 5
- Check build result in createContainer
- Disable scratch builds until a proper solution is found HOT 3
- Use a different osbs config section for scratch builds HOT 1
- Add createContainer and buildContainer to method list at kojiweb task page HOT 1
- getBuild need add an argument 'strict=True' HOT 1
- is this deprecated? HOT 2
- Auto populate the container version based on a "primary rpm" version HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from koji-containerbuild.