GithubHelp home page GithubHelp logo

Comments (5)

MartinBasti avatar MartinBasti commented on June 26, 2024 1

It seems that koji package doesn't support plugins via entrypoints [1], and I'm not sure how to copy content of this package into another without it. Theoretically we could do namespace package [2] in koji-container build but it needs changes in repo and I'm not sure if it will work as expected.

This is where we do copy operations in RPM
https://github.com/containerbuildsystem/koji-containerbuild/blob/master/koji-containerbuild.spec#L116

[1] https://pagure.io/koji/blob/master/f/cli/koji#_65
[2] https://packaging.python.org/en/latest/guides/creating-and-discovering-plugins/

from koji-containerbuild.

MartinBasti avatar MartinBasti commented on June 26, 2024

Uploading it into pypi is easy, can be done instantly, but I assume you want to use it as CLI plugin koji container-build

In this case it will not work, because in RPM we copy CLI plugin into %{python3_sitelib}/koji_cli_plugins so we have to update setup.py somehow or if it's not working, we have to do some magic with entrypoints and koji.

I'll check

from koji-containerbuild.

MartinBasti avatar MartinBasti commented on June 26, 2024

sorry I haven't found an quick way how to do it and make it workable, this would require changes to both koji and koji-c codebases.

from koji-containerbuild.

Omeramsc avatar Omeramsc commented on June 26, 2024

Hi @MartinBasti , what kind of changes are required?
and what kind of copy do you do in the RPM? cli, hub and builder can perform separately?

from koji-containerbuild.

MartinBasti avatar MartinBasti commented on June 26, 2024

Or another way could be to copy it just as data_file, but it looks very hackish

setup(...
    data_files=[(os.path.join(sys.prefix,..., 'koji_cli_plugins'), ['plugins/cli_containerbuild.py'])],
    ...
)

from koji-containerbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.