cooljeanius / dawn_of_thunder

a Wesnoth UMC campaign; forked to clean up (originally by Paulomat4)

dawn_of_thunder

Fork of a Wesnoth UMC campaign that was originally for BfW 1.14. In this fork I am forward-porting it to BfW 1.16.

Follow Fiannon on a quest that will lead him farther than any elf has ever been.

Forum thread here: https://forums.wesnoth.org/viewtopic.php?f=8&t=39512

dawn_of_thunder's Issues

fixme requests on dialogues

• redundant space character
  ====================================================================
  1 scenarios/06_woodchoppers.cfg: 58
  2 scenarios/06_woodchoppers.cfg: 1495
  3 units/faeries/fallenfaerie.cfg:41

• incorrect(or maybe) spelling , capitalization & repetition of the same word
  ====================================================================
  4 scenarios/08_grand_meeting.cfg:561 greenwood --> Greenwood ?
  5 units/faeries/fallenfaerie.cfg:41 fightm --> fight
  6 units/humans-northguard/Northguard_Braveheart.cfg:19 lycantropy --> lycanthropy
  7 units/humans-northguard/Northguard_Warrior.cfg:19 "to fight fight" --> "to fight"
  8 units/humans/GoldenMage.cfg:123 "Gold Magi Magi are"
  9 utils/Special_notes.cfg:36 spell: tranform -> transform
  10 units/humans/GreyMage.cfg:80 "timen" --> "time" ? , "then their" --> "than their" ?
  11 scenarios/11_dwarvish_gratitude.cfg:223 "ambushed by by trolls"

• need a period character
  ====================================================================
  12 scenarios/08_grand_meeting.cfg:1657
  13 units/elves/ElvishHalverdier.cfg:32

• has no period character. Is it ok? (naration)
  ====================================================================
  14 scenarios/09_underground.cfg:480
  15 scenarios/09_underground.cfg:481

• Since this is an objective's line, period character is not usually used.
  ====================================================================
  16 scenarios/10_subterranean_crossfire.cfg:703

• 1,2,3,4,5$ -> 1,2,3,4,5 Gold ?
  ====================================================================
  17 utils/weapon_specials.cfg:91 text="" + _ "1$" + ""
  18 utils/weapon_specials.cfg:111 text="" + _ "2$" + ""
  19 utils/weapon_specials.cfg:131 text="" + _ "3$" + ""
  20 utils/weapon_specials.cfg:151 text="" + _ "4$" + ""
  21 utils/weapon_specials.cfg:171 text="" + _ "5$" + ""

• others
  ====================================================================
  22 scenarios/15_Wild_Steppe.cfg:321 name="Pelagius" ( --> name= _ "Pelagius" )
  23 scenarios/18_Illuvèn.cfg:105
  message= _ "God damn! Bah, who needs astral blades if you have maces..."
  ( "astral blade" is not used in this campaign :) ) (def. in "ageless era" ?).
  24 units/naga/Naga_Hunter.cfg:29 "TODO" ? （unfinished description?）
  25 utils/traits.cfg:28 description= _ "+5% defense and"
  "and" ... what? ... " MP +2" ?
  --
  That is all.

Feedback from Konrad2

See this post from @Konrad22 on the forums:
https://forums.wesnoth.org/viewtopic.php?p=682649#p682649

S18 3_behaviors of concern

3 behaviors

• "$unit.race" content is displayed in English, but probably cannot be translated in its current state.

• Fiannon's line:

  dawn_of_thunder/scenarios/18_Illuvèn.cfg

  Line 489 in ba69c92

  message= _ "Identify yourself $unit.race|! I am Fiannon, defender of Wesmere and the Ka'lian!"

• It should be clearly stated that Naia will "Close the Portal".

• objectives:

  dawn_of_thunder/scenarios/18_Illuvèn.cfg

  Line 586 in a85a8c1

  description= _ "Close the Portal"

• Even if the portal is not closed, it will end when the enemies are defeated.

Translatability updates

I should recheck strings to see where it might make sense to add translation comments...

`[interim_text]` displays too slowly

When I asked about it on Discord, @knyghtmare said it's from IftU, and that I should look into editing the lua file

TODO items from changelog.txt

changelog.txt has a TODO list in it; I should probably convert some of those into GitHub issues

Make Subterranean Crossfire easy enough for me to beat

I've been having a hard time with it

campaign is incomplete

last scenario (S18, Illuvèn) still needs some work before writing any new ones

Update maps to meet knyght's criteria for map quality

From wesnoth/wesnoth#7479, according to @knyghtmare, good maps should have:

1. More than 10 terrain types used.
2. Map is actually visually appealing to look at, i.e., not too plain (this one is still kind of subjective IMO)
3. Map appearance uses the campaign's lore properly.
4. Uses embellishments.

S17 What happens with surrounding Mal Lirak and what happens without surrounding.

If Mal Lirak is surrounded from three sides, Mal Lirak escapes at that point and the scenario ends with a victory.
If Mal Lirak is defeated without being surrounded from less than three sides, Mal Lirak will die. (Likewise, the scenario ends in victory.)
In either case, we cannot capture him. In other words, we can only let him escape or kill him.

( objective for win: Defeat all enemy leaders and Capture Mal Lirak )

theme files are obsolete

In 1.16 and above, both Cutscene and Cutscene-minimal themes are available in core.
These were from AtS but later mainlined so 1.10, 1.12, 1.14 add-ons should no longer have a need to keep duplicates.

Mine cart scenario: handle possibility where players try bringing cart back out the way they entered

see: https://forums.wesnoth.org/viewtopic.php?p=683847#p683847

missing music

later scenarios don't have any music added

Upload to BfW 1.16 add-on server

This involves getting the _server.pbl from Paulomat4... which he said he'd send to me, but I haven't heard from him since then...