coreh / hookshot Goto Github PK

GMT express deprecated res.send(status, body): 

Use res.status(status).send(body) instead at node_modules/hookshot/lib/index.js:33:9

Seems like an easy enough fix. I feel like your testing setup for webhooks is probably more ready-to-go than mine, but if you'd prefer a PR I can probably do one at some point.

GitHub lets you put a shared secret into a webhook, that the server can use to verify that it's really GitHub making the request.

hookshot should support this. I'll plan to do a PR, but putting this flag in the sand in case someone wants to beat me to it.

Since you're assuming that process.env.SHELL is set, which may or may not be the case on Windows.

But if/when it is available on Windows, then it's usually a unix-style path such as /bin/bash. This path isn't gonna work on Windows' cp.spawn() and will result in a error spawn ENOENT error.

Some possible (combinations of) solutions:

1. Just use cmd.exe on Windows.
2. Detect when we are running from within a "cygwin" environment and conver the "SHELL" env variable to a cygwin path. This should be relatively easy.
3. This would only really leave detecting git-bash and its path resolution, but that's not really important for us ATM.

I'll probably try to whip up a patch for 1+2.

As the title says, this repo has been stale for a long time. I had a PR and some other changes I wanted to implement and couldn't wait any longer. Would love issues and any new PR's placed there so we can continue development of this module.

Fork: https://github.com/ScottONeal/githooked
NPM: https://www.npmjs.com/package/githooked

I got a Error: request entity too large error on a push with a few hundred files. GitHub payloads can be large when you're doing large merges and PRs. I think Hookshot's maximum should be larger than the defaults. Ideally, it'd be easy to pass a flag into hookshot to raise the maximum beyond Hookshot's defaults, too.

How would you set up hookshot so it listens to changes on all of your branches instead of just refs/heads/master?

Any idea on how to improve this tool bypassing routing and NAT restriction?

It looks like GitHub is changing the way they deliver webhook payloads

EDIT, better link to the post
https://developer.github.com/changes/2014-10-21-deployment-webhook-payload-changes/

@coreh I want to execute a command only when a new git tag is pushed. Can I currently do that with hookshot or do we need to add a feature?