corinm / fairylights Goto Github PK

Most of the patterns involve fading a bulb from black/off to a colour and back again. I've found a warm white is RGB 90, 60, 9.

When fading this colour, as it gets closer to black, it becomes impossible to maintain the ratio of red:green:blue because there isn't much blue to play with.

At full the ratio of R:B is 10:1
Close to black, if R was 5 B would need to be either 1 or 0 - a ratio of 5:1 (too much blue) or 5:0 (no blue at all, making it more yellow).

This is only noticeable for the warm white, so not a big problem.

• Fade out consistently to stop (currently some bulbs reach 0 lum before others)
• Convert so it's independent of tick rate

• Needs to be easy and free e.g. github actions
• Needs to work with rpi only packages

Currently using the webpage UI you can set the lights to either cycle or a specific pattern for it to stay on. This feature would decouple choosing a pattern from whether it should cycle or stay on that pattern

• Red and yellow
• Red, yellow, green, blue (like off-the-shelf lights)
• Pink, green, cyan, orange (?)

• When generating a spread of analagous colours (e.g. yellow-orange-red or cyan-blue-), the effect varies depending on where in the spectrum the colour is.
• Blues and purples and harder to differentiate and look much more similar
• It may therefore look nicer to adjust how colours are selected based on where they are in the spectrum

• Adapt Twinkle to have optional minimum luminance

• Tidy up the API so that it's clearer what it does
• Update page so that it uses the new requests

Problem

• Currently the fairy lights update on each loop of a while True infinite loop. This means the speed of the fairy light animation varies based on CPU speed / contention
• This requires code changes when switching between devices (RPZ vs RP3B+)

Investigation

• https://www.construct.net/en/tutorials/delta-time-framerate-2

Currently the patterns FSM transitions through every state in turn, however it should skip the off/stopped state.

• One of the packages needs requires root permissions to work
• Can install from scratch via pipenv (may be able to use https://github.com/lukechilds/dockerpi to test)

Problem

• Currently the cycle effect starts with all bulbs on, however this is quite jarring when transitioning from other effects.

Possible solution

• Try out starting with all bulbs off then adding bulbs in one at a time, in time with the cycle. This will give an effect of the colours falling until all bulbs are on.
• When the effect is stopping it should continue to cycle but without looping the colours around, giving the effect of the colours falling until all bulbs are off.

• The current code works fine with up to ~300 LEDs, however with 1000 it becomes very slow
• Use the line_profiler tool to identify bottlenecks and investigate possible improvements

https://stackoverflow.com/questions/23885147/how-do-i-use-line-profiler-from-robert-kern

Total time: 0.003424 s
File: /home/pi/fairylights/src/patterns/twinkle/Twinkle.py
Function: tick at line 39

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
    39                                               def tick(self) -> List[Color]:
    40         1         10.0     10.0      0.3          now = time()
    41         1         13.0     13.0      0.4          timeDelta = self._getTimeDelta(now)
    42                                           
    43         1          6.0      6.0      0.2          if not self._stopping and now > self._timeToNextTwinkle:
    44         1        645.0    645.0     18.8              self._nextTwinkle()
    45         1          8.0      8.0      0.2              self._timeToNextTwinkle = now + self._timeBetweenTwinkles / self._numberOfBulbs / 50
    46                                           
    47         1          6.0      6.0      0.2          self._count += 1
    48                                           
    49       151        680.0      4.5     19.9          for bulb in self.shuffledBulbs.getBulbs():
    50       150       1501.0     10.0     43.8              bulb.incrementTimeDelta(timeDelta)
    51                                           
    52         1        536.0    536.0     15.7          colours: List[Color] = [bulb.getColour() for bulb in self.shuffledBulbs.getBulbs()]
    53                                           
    54         1          6.0      6.0      0.2          if self._stopping:
    55                                                       self._checkIfStopped(now, colours)
    56                                           
    57         1          8.0      8.0      0.2          self._time = time()
    58                                           
    59         1          5.0      5.0      0.1          return colours

When using the webpage to change the pattern it transitions but doesn't appear to change to the pattern chosen