corneliousjd / flux_led Goto Github PK

Can i apply this fix for only controller with v8 version? Other magic home controllers work like a charm out of box. If i apply this fix, other contollers stop working right - did not turn on by automatiation or stop working.

Light's white_value was deprecated in Home Assistant Core 2021.4 by PR #47720 and replaced by color mode white in Home Assistant Core 2021.7 by PR #51411.
This change broke Flux_Led integration.
I would like to know if there will be a fix for this change in HA.

Thanks

As you suspected there is a problem when different controllers coexist.
In my case i bought a bunch of White, RGB and RGBW controllers

All RGB are v8 and all White and RGBW are still v5

when i used YOUR code for RGB i had problems with others (turning on from HA did not work for RGBW and White)

So i looked in the code and i think i found a sollution just where you modified it
i added some code in turn_on function just AFTER your modification:

# if not self.is_on:
# self._bulb.turnOn()
if self._mode == MODE_RGBW and not self.is_on:
self._bulb.turnOn()
if self._mode == MODE_WHITE and not self.is_on:
self._bulb.turnOn()

Basicly it applies YOUR modified behaviour only for RGB, and for White and RGBW (with v5) it works as in standard integration.
Maybe it is worth to add this modification to your github.

If you have other ideas - i can test it.

Home assistant

Are we sure the scan interval setting is in seconds and not ms? The scan_interval suggested is way too aggressive to the point where it slowed not only HA but my whole network to a crawl as well as warnings about entities being slow to trigger in HA log etc.

I commented out the scan_interval and that brought everything back to normal. Polling seems to be unaffected.

Maybe this number needs to be revised?

Hello all, really thanks for your work, a couple of days ago (I not sure If I did an update) the controller stop working with HACS.

The same issue if I put your changes, or If I delete everything.

Using MagicLight everything works as expected, but as soon I start HASS with or without the Flux-led folder, the lights stop working.

I came back to see if you have updated something or whatever and the last time I put the files manually, this time I try HACS but its not picking the URL.

System Health

ERROR (MainThread) [homeassistant.loader] No 'version' key in the manifest file for custom integration 'flux_led'. As of Home Assistant 2021.6, this integration will no longer be loaded. Please report this to the maintainer of 'flux_led'

Hello CorneliousJD I've appreciated a lot your fix but today I see this message in home assistant log:
No 'version' key in the manifest file for custom integration 'flux_led'. As of Home Assistant 2021.6, this integration will no longer be loaded. Please report this to the maintainer of 'flux_led'
Can you fix this?
Thank you

Well thanks for this, it works! I saw things were going to be implemented in HA in the future that will fix those issues natively, good news.

When changing color, it jumps back to the last color instantly. I have to press the same color twice if I want the UI to update to the color I’ve clicked, I’m not sure if this has been reported before.

Thanks very much this worked for me also!

Can you submit to HA so it can be updated to the release? thanks

I have a single colour (monochrome) controller, and reporting and setting brightness does not work. It constantly reports the brightness as 0, and if I try to set the brightness in HA, no errors happen but it does not set the brightness. I suspect that it is because the "w" mode is trying to set the brightness via the white level rather than brightness itself.

I hacked around with the code a little, and managed to get the brightness reporting correctly and setting it if it is below 40%. If I try to adjust the brightness via HA above 40% it simply doesn't work. If I adjust it using the MagicHome app it works perfectly, and it reports the correct brightness to HA.

I got the brightness working by changing the code at approximately line 452-353:

if self._mode == MODE_WHITE:
            self._bulb.setRgbw(0, 0, 0, w=white, brightness=brightness)

and commenting out the following lines at approximately line

        # if self._mode == MODE_WHITE:
        #     return self.white_value

I am completely lost as to why the brightness cannot be set from within HA to higher than 40%.