Comments (3)
Hey there, SSDTTime's objective is to implement SSDT hot patches for a number of situations/hardware. In doing so, The DSDT is only leveraged for patching/naming references, and should not be injected via EFI -> OC -> ACPI
.
Any patches you have in config.plist -> ACPI -> Patch
are applied by OpenCore before any tables are injected, so if you intend to inject a patched DSDT, it must be manually patched first - and the ACPI -> Patch
es will not apply to it.
If I'm misunderstanding what you're saying, please let me know, but it sounds like SSDTTime is working as intended, you're just also injecting your DSDT which overrides the patches.
-CorpNewt
from ssdttime.
@corpnewt thanks for the clarification, now I probably understand the logic of ACPI processing in OpenCore.
It seems to me that this sequence/pipeline works differently in Clover.
I think this issue can be closed, but it would be cool if SSDT conducted a small heuristic analysis and, for example, if the path to DSDT.aml is selected as /EFI/OC/ACPI/DSDT.aml, then after generating patches, a notification was displayed in the terminal that when using custom DSDT patches must be implemented manually
from ssdttime.
The order should work the same in both boot managers - as the idea is that if you are injecting your own manually edited/created tables, they should not need the boot manager to also patch them. Patching them after injection would also break a number of current "tricks" used in SSDT hot patching.
SSDTTime's objective is explicitly for SSDT hotpatching - in which a patched DSDT is not used at all. As such, I don't think it's worth adding a warning or doing any extra path checking. If you intend to patch your DSDT, you can manually change anything that SSDTTime would normally generate patches for - as well as adding new devices, or making whatever other edits you intend. The two aren't designed to be used together. Though I still stand by the statement that a patched DSDT is quite heavy handed - and SSDT hot patching is a much more elegant approach overall.
-CorpNewt
from ssdttime.
Related Issues (20)
- Dump DSDT not found HOT 1
- Locating HPET's _CRS Method... - Could not locate HPET's _CRS! Aborting! HOT 2
- Missing "Dump DSDT" feature in macOS HOT 1
- Script exited with error core: 1 HOT 8
- SSDTTime.bat not running HOT 3
- [Feature Request] Add HyperV auto stuff HOT 1
- Fix-HPET Error (Could not locate HPET's _CRS! Aborting!) HOT 1
- ModuleNotFoundError: No module named 'Scripts' HOT 2
- Fix iasl issue
- an error occurred
- Oneeva trojan HOT 1
- AN ERROR OCCURRED HOT 1
- I keep getting this error HOT 1
- Return value for fake EC
- Problem with SSDTTime.bat HOT 5
- An error occurred , could not locate or download iasl HOT 2
- [Suggestion] Better Download Link for iasl for Windows
- Error: ModuleNotFoundError: No module named 'Scripts' HOT 4
- Windows10: No Dump DSDT option HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssdttime.