cosmos / amino-js

go-amino + GopherJS + TypeScript

ToC

• Purpose
• Whitepaper
• Crowdfund Plan
• Faq
• Chat

Disambiguation

This Cosmos is not related to the React-Cosmos project (yet). Many thanks to Evan Coury and Ovidiu (@skidding) for this Github organization name. As per our initial agreement, this disambiguation notice will stay here.

amino-js's Issues

marshalPubKeyMultisigThreshold sample request

Hi,

Can you give me a simple example of marshalizing multisig account object using marshalPubKeyMultisigThreshold() function? In the first place, I'm struggling to create json object of PubKeyMultisigThreshold that is one of the parametes of marshalPubKeyMultisigThreshold().

Todo: update Cosmos SDK and Tendermint types

While resolving #7, I noted that some file names and types in go/lib are out of sync with the versions of the SDK and Tendermint in use.

It's possible that this library's copies were based on the master repositories of the SDK and Tendermint at the time rather than the fixed version releases. I'll be going over the SDK @ 0.35.0 and Tendermint @ 0.31.7 in the fix-types branch to update.

This is also relevant to the work that needs to be done on #3. Figuring out a solution to automate this process might be in scope.

Yarn setup scripts throw errors after first use

The yarn:setup script as presented in the README worked during the initial project setup, but the ordering generates errors if the cmd is run again. I'm able to get around the errors by cherry-picking the functionality. Although these issues will likely be avoided if users only run yarn:setup once, the scripts may need to be updated to avoid confusion.

Scripts from package.json:

"clean":     "rm -rf ./dist/*",
"dirs":      "mkdir ./dist",
"dist:dev":  "yarn clean && yarn go && NODE_ENV=development yarn build",
"setup":     "yarn dirs && yarn dist:dev",

Cmd: yarn setup
Issue: yarn dirs makes ./dist dir before it's cleaned by yarn dist:dev
Result: mkdir: ./dist: File exists -> error Command failed with exit code 1.

Cmd: yarn clean
Issue: yarn clean doesn't remove ./dist dir
Result: Attempting to clean first before cherry-picking yarn dist:dev resulted in the same error as above. Was able to resolve by running rm -rf ./dist prior to yarn setup

amino-js fails to unmarshal a transaction

amino-js v0.4.4 fails to unmarshal (calling unmarshalTx()) this transaction https://www.mintscan.io/txs/7E523023AB564A2AC165503CE66EFA23AAE99D39E89A859BC905093864A8D4A1

The error message is Error: unmarshal to types.Tx failed after 17 bytes (error reading array contents: unrecognized prefix bytes 436F736D)

Here's the transaction in its amino/base64 encoded form (according to a GET /blocks/2567202 call to the Cosmos REST API):

uxfwYl3uCrAWtC1hTgofQ29zbW9zIEh1YiAzIFVwZ3JhZGUgUHJvcG9zYWwgRRLdFUZpZ21lbnQgTmV0d29ya3MgKGh0dHBzOi8vZmlnbWVudC5uZXR3b3JrKQoKLT0tPS0KCkZ1bGwgcHJvcG9zYWw6Cmh0dHBzOi8vaXBmcy5pby9pcGZzL1FtZkp5ZDY0c3JKU1g4MjRXb05uRjZCYnZGNHd2UEdxVkJ5blplTjk4Qzd5Z3EKCi09LT0tCgpfRGVjaXNpb25fCgpXZSBhcmUgc2lnbmFsbGluZyB0aGF0OgoKMS4gVGhlIEdhaWEgMi4wLjMgaW1wbGVtZW50YXRpb24gaXMgYWxpZ25lZCB3aXRoIHRoZSBsaXN0IG9mIGhpZ2gtbGV2ZWwgY2hhbmdlcyBhcHByb3ZlZCBpbiBDb3Ntb3MgSHViIDMgVXBncmFkZSBQcm9wb3NhbCBBLgoKMi4gV2UgYXJlIHByZXBhcmVkIHRvIHVwZ3JhZGUgdGhlIENvc21vcyBIdWIgdG8gY29zbW9zaHViLTMgYmFzZWQgdXBvbgoJYS4gQ29tbWl0IGhhc2g6IDJmNjc4M2UyOThmMjVmZjRlMTJjYjg0NTQ5Nzc3MDUzYWI4ODc0OWE7CgliLiBUaGUgc3RhdGUgZXhwb3J0IGZyb20gY29zbW9zaHViLTIgYXQgQmxvY2sgSGVpZ2h0IDI5MDIwMDA7CgljLiBHZW5lc2lzIHRpbWU6IDYwIG1pbnV0ZXMgYWZ0ZXIgdGhlIHRpbWVzdGFtcCBhdCBCbG9jayBIZWlnaHQgMjkwMjAwMC4KCjMuIFdlIGFyZSBwcmVwYXJlZCB0byByZWxhdW5jaCBjb3Ntb3NodWItMgoJYS4gSW4gdGhlIGV2ZW50IG9mOgoJCWkuIEEgbm9uLXRyaXZpYWwgZXJyb3IgaW4gdGhlIG1pZ3JhdGlvbiBwcm9jZWR1cmUgYW5kL29yCgkJaWkuIEEgbmVlZCBmb3IgYWQtaG9jIGdlbmVzaXMgZmlsZSBjaGFuZ2VzCgkJaWlpLiBUaGUgZmFpbHVyZSBvZiBjb3Ntb3NodWItMyB0byBwcm9kdWNlIHR3byAoMikgYmxvY2tzIGJ5IDE4MCBtaW51dGVzIGFmdGVyIHRoZSB0aW1lc3RhbXAgb2YgQmxvY2sgSGVpZ2h0IDI5MDIwMDA7CgliLiBVc2luZzoKCQlpLiBUaGUgc3RhcnRpbmcgYmxvY2sgaGVpZ2h0OiAyOTAyMDAwCgkJaWkuIFNvZnR3YXJlIHZlcnNpb246IENvc21vcyBTREsgdjAuMzQuNisgaHR0cHM6Ly9naXRodWIuY29tL2Nvc21vcy9jb3Ntb3Mtc2RrL3JlbGVhc2VzL3RhZy92MC4zNC4xMAoJCWlpaS4gVGhlIGZ1bGwgZGF0YSBzbmFwc2hvdCBhdCBleHBvcnQgQmxvY2sgSGVpZ2h0IDI5MDIwMDA7CgljLiBBbmQgd2lsbCBjb25zaWRlciB0aGUgcmVsYXVuY2ggY29tcGxldGUgYWZ0ZXIgY29zbW9zaHViLTIgaGFzIHJlYWNoZWQgY29uc2Vuc3VzIG9uIEJsb2NrIDI5MDIwMDEuCgo0LiBUaGUgdXBncmFkZSB3aWxsIGJlIGNvbnNpZGVyZWQgY29tcGxldGUgYWZ0ZXIgY29zbW9zaHViLTMgaGFzIHJlYWNoZWQgY29uc2Vuc3VzIG9uIEJsb2NrIEhlaWdodCAyIHdpdGhpbiAxMjAgbWludXRlcyBvZiBnZW5lc2lzIHRpbWUuCgo1LiBUaGlzIHByb3Bvc2FsIGlzIHZvaWQgaWYgdGhlIHZvdGluZyBwZXJpb2QgaGFzIG5vdCBjb25jbHVkZWQgYnkgQmxvY2sgSGVpZ2h0IDI4NTIyMDIuCgotPS09LQoKX0NvbnRleHRfClRoaXMgcHJvcG9zYWwgZm9sbG93cyBDb3Ntb3MgSHViIDMgVXBncmFkZSBQcm9wb3NhbCBEIChodHRwczovL2h1YmJsZS5maWdtZW50Lm5ldHdvcmsvY29zbW9zL2NoYWlucy9jb3Ntb3NodWItMi9nb3Zlcm5hbmNlL3Byb3Bvc2Fscy8xNikgYWthIFByb3AgMTYsIHdoaWNoIHBhc3NlZCBpbiB2b3RlLCBidXQgZmFpbGVkIGluIGV4ZWN1dGlvbiAoaHR0cHM6Ly9mb3J1bS5jb3Ntb3MubmV0d29yay90L2Nvc21vcy1odWItMy11cGdyYWRlLXBvc3QtbW9ydGVtLzI3NzIpLiBUaGlzIHByb3Bvc2FsIGlzIGludGVuZGVkIHRvIHN1Y2NlZWQgd2hlcmUgUHJvcCAxNiBmYWlsZWQuCgpUaGlzIHByb3Bvc2FsIGlzIGludGVuZGVkIHRvIHNpZ25hbCBhY2NlcHRhbmNlL3JlamVjdGlvbiBvZiB0aGUgcHJlY2lzZSBzb2Z0d2FyZSByZWxlYXNlIHRoYXQgd2lsbCBjb250YWluIHRoZSBjaGFuZ2VzIHRvIGJlIGluY2x1ZGVkIGluIHRoZSBDb3Ntb3MgSHViIDMgdXBncmFkZS4gQSBoaWdoIGxldmVsIG92ZXJ2aWV3IG9mIHRoZXNlIGNoYW5nZXMgd2FzIHN1Y2Nlc3NmdWxseSBhcHByb3ZlZCBieSB0aGUgdm90ZXJzIHNpZ25hbGxpbmcgdmlhIENvc21vcyBIdWIgMyBVcGdyYWRlIFByb3Bvc2FsIEE6Cmh0dHBzOi8vaHViYmxlLmZpZ21lbnQubmV0d29yay9jb3Ntb3MvY2hhaW5zL2Nvc21vc2h1Yi0yL2dvdmVybmFuY2UvcHJvcG9zYWxzLzEzCgpXZSBhcmUgcHJvcG9zaW5nIHRvIHVzZSB0aGlzIGNvZGUgaHR0cHM6Ly9naXRodWIuY29tL2Nvc21vcy9nYWlhL3JlbGVhc2VzL3RhZy92Mi4wLjMgdG8gdXBncmFkZSB0aGUgQ29zbW9zIEh1Yi4KV2UgYXJlIHByb3Bvc2luZyB0byBleHBvcnQgdGhlIGxlZGdlcuKAmXMgc3RhdGUgYXQgQmxvY2sgSGVpZ2h0IDIsOTAyLDAwMCwgd2hpY2ggd2UgZXhwZWN0IHRvIG9jY3VyIG9uIERlY2VtYmVyIDExLCAyMDE5IGF0IG9yIGFyb3VuZCAxNDoyNyBVVEMgYXNzdW1pbmcgYW4gYXZlcmFnZSBvZiA2Ljk0IHNlY29uZHMgcGVyIGJsb2NrLiBQbGVhc2Ugbm90ZSB0aGF0IHRoZXJlIHdpbGwgbGlrZWx5IGJlIGEgdmFyaWFuY2UgZnJvbSB0aGlzIHRhcmdldCB0aW1lLCBkdWUgdG8gZGV2aWF0aW9ucyBpbiBibG9jayB0aW1lLgoKV2UgYXJlIHByb3Bvc2luZyB0aGF0IHRoZSBDb3Ntb3MgSHViIDMgZ2VuZXNpcyB0aW1lIGJlIHNldCB0byA2MCBtaW51dGVzIGFmdGVyIEJsb2NrIEhlaWdodCAyLDkwMiwwMDAuCgotPS09LQoKQ28tb3JkaW5hdGlvbiBpbiBjYXNlIG9mIGZhaWx1cmUgd2lsbCBoYXBwZW4gaW4gdGhpcyBjaGFubmVsOiBodHRwczovL3Jpb3QuaW0vYXBwLyMvcm9vbS8jY29zbW9zX3ZhbGlkYXRvcnNfdGVjaG5pY2FsX3VwZGF0ZXM6bWF0cml4Lm9yZxgBIhQrv2OiyZYsAZ2+i0gazel9jlBW/ioRCgV1YXRvbRIIMTIwMDAwMDASFgoQCgV1YXRvbRIHMTQwMDAwMBDAmgwaagom61rphyECbBkcVpHNEJPxF+jExArw3TClQZuDf9VHGAb4d5HDAgoSQPptMTINbW5vADVyreOmURHGI69xIR2LHULPmoqQGxXJTmlSQ+kzkP51iMBxC1RK6N5+LTfQmrmXScUDFJVTvps=

How to make extension of the new type

Hi there,
Its really a fantastic project here for cosmos-sdk as js output! Let me introduce myself, I'm from QOS Group, a partner in cosmos ecosystem. Its quite new and suitable for us when there is blockchain QOS based on tendermint rather than cosmos itself.
I want to extend the specific type of qos tx as the same way of other cosmos types deployed.
Is there more detailed instruction than extend.md?
Thanks~

PS: you can also refer to our issue if you are interested: QOSGroup/qweb#22

Published TS declarations should not depend directly on source files

Currently index.d.ts exports everything from src/, which means other TS projects which use this library have to compile those source files. If the consumer's TS settings are different this leads to problems, e.g. this error which we've encountered:

../../node_modules/@tendermint/amino-js/src/util.ts:21:49 - error TS2304: Cannot find name 'window'.

21     ({ atob, btoa, TextDecoder, TextEncoder } = window);

Separate declaration files would ideally be generated from the source files, so that the library can be used by other TS projects regardless of differences in TS config.

Typescript Error: 'TextEncoder' does not exist on type 'Window'.

Using [email protected] and webpack 4.29.6, I get the following error message at compile time:

ERROR in [at-loader] ./node_modules/@tendermint/amino-js/src/util.ts:19:33 
    TS2339: Property 'TextEncoder' does not exist on type 'Window'.

Any idea how to solve? Thanks!

Fail to unmarshal tx data from a block

Using:
[email protected]
@tendermint/[email protected]
@tendermint/[email protected]

Trying to decode tx from block with:

import { decodeString, unmarshalTx } from '@tendermint/amino-js';
import { base64ToBytes } from '@tendermint/belt'; 

  decodeTx(txHash) {
    try {
      const decoded = base64ToBytes(txHash); 
      const unmarshaled = unmarshalTx(decoded);
      return decoded
    }
    catch (error) {
      console.log(error)
      return null
    }
  }

Throws this error on every tx data string from blocks:
For example:

3wEoKBapCluclZNGChRm0QXKCIrFakuLzpL0oqW3MHzH/RIUyTRRx8hJmGRpUL1G+yw8xXQRSHsaFE3H7L64W8UP7sICyw32yIwMNrM6IhMKBXVhdG9tEgoyMDQ5ODQ5MTQwEhAKCgoFdWF0b20SATEQgNMOGmoKJuta6YchAzpqNiIl4AIZl3rIYeUHLU10NyCNiEapGx3SKZ338sTwEkDgs/cND/XjaiNySQxrLQRGbgaLqhyyjozvYozBqvmAiEVxiG5W63DzhGm8UeMxXDh3zemjyMfkZB0XAGqcjs8V

at block 1416024

Error: unmarshal to types.Tx failed after 4 bytes (unrecognized prefix bytes 282816A9): 282816A90A5B9C9593460A1466D105C.....6A9C8ECF15