costas-basdekis / marlingcodedocumentation Goto Github PK

I suggest that these changes be made to stop this:

https://i.imgur.com/PHy8UU3.png

Change from:

/octoprint_marlingcodedocumentation/templates/marlingcodedocumentation.jinja2:81: Include from Marlin
/octoprint_marlingcodedocumentation/templates/marlingcodedocumentation.jinja2:85: Include from RepRap
/octoprint_marlingcodedocumentation/templates/marlingcodedocumentation.jinja2:89: Include from Klipper

Change to:

/octoprint_marlingcodedocumentation/templates/marlingcodedocumentation.jinja2:81: Marlin
/octoprint_marlingcodedocumentation/templates/marlingcodedocumentation.jinja2:85: RepRap
/octoprint_marlingcodedocumentation/templates/marlingcodedocumentation.jinja2:89: Klipper

End result:

https://i.imgur.com/DvBgBPH.png

While writing this, it occured to me that this setting might make more sense to bury in a settings page with other plugins. Perhaps some users with multiple printers might need to switch between documentation on the fly, but then just have an option to show/hide these on the console tab.

For command M120, the documentation says:

Enable endstops and keep them enabled when not homing

For command M121, the documentation says:

Disable endstops and keep them enabled when not homing

Notice that both commands say that the endstops will remain ENABLED when not homing. I THINK that for M121, it is supposed to read keep them disabled when not homing?

Manufacturers, such as Prusa, have their own specific commands. Can you add the most popular ones to this Documentation Plug-In?

I'm specifically thinking of the M601, M602 (Pause and Resume Print), which are now used in PrusaSlicer filament change routines.

https://www.help.prusa3d.com/en/article/prusa-specific-g-codes_112173
https://reprap.org/wiki/G-code#M601:_Pause_print
https://reprap.org/wiki/G-code#M602:_Resume_print

I am hoping for an option to turn off the "Are you sure you want to replace the current command?" box

When uninstalling, the terminal GCODE is still displayed in the style (css) given to it by MarlinGcodeDocumentation. This makes reading on a dark theme extremely difficult. I have both uninstalled and re-installed Themeify to try and fix the issue, with no luck.

I'm starting to use klipper for the first time and the plugin doesn't seem to recognise any of the commands.
I tried switching on plugin logging but the log shows nothing unusual. I also don't seem to find any errors in the inspect console.
Anything I should look into?

Hi,
I installed the latest 0.17.0 release and discovered following bug:
When I enter a gcode (e.g. G28), M-command or ?phrase I receive the error message Unknown Command, no matter which source I select.
The attached log file shows, that there is a problem with the plugin.
octoprint-13.log

Not sure why. I've moved up to Python 3 via the Octropi approved migration script.
Do I need to reboot?

First, let me thank you for this wonderful plugin that I learned to appreciate while using Marlin. Now that I begin experimenting with Klipper I noticed that most of the klipper entries seem broken where "traditional" gcode commangs are concerned and mostly missing when it comes to those klipper specific "human-readable" commands and macros.
As far as I understand the plugin scrapes the respective firmware's gcode documentation page for the supported commands. Klipper seems to describe a few of the supported commands in details and apparently refers to other pages for the rest. Some commands like G10 are just mentioned and end up without a brief description in the plugin.
Klipper also allows defining all kinds of additional makros that can be used like the predefined ones. It would be fantastic to have some kind of documentation for those.
Would it be feasable to have some additional way of adding or eve modifying the standard information source for the languages, maybe by means of some json file structured like what updater.py feeds into all_codes.js? This information could be a kind of overlay to the scraped data, augmenting it with missing information (e.g. missing brief description, etc) and additional macros.

Hi/
Plugin disabled after install.

Whenever I reload the OctoPrint interface my list of saved g-codes loads with all expanded. I then have to click the Collapse All button to see the full list (or more of the full list) like an index. I know, it's just another button press, but I want to be lazy. ;-)

This could be another item to put in the configuration window that I requested in issue #12.

Hi!

Let me first say this is very useful as it is. I use Klipper and many of the commands are not recognized, I was just wondering if someday there could be support for Klipper. Thanks!

DroneMang

If using Multi Line Terminal (0.1.3) plugin, this fine plugin fails to show GCode help.
Not sure what you can do to fix that tho as two or more lines might garble up the page.
Maybe add a ? to perform the actual info - I could live with that.
Thought about this some more - only offer help on last line!

The basic idea is great, since you get the documentation right there where you need it! Thank you for providing this. :-)

Some thoughts:

I think it would be better, if the tab or the frame showing the documentation, could be placed below the Terminal buttons (below the "Advanced options..." link).

Also some top and bottom padding between the lines, especially to the buttons, would slightly improve readability.

There should be an option or switch to disable the how to use box.

Since version 0.17.0 the whole display is below Octoprint and no longer in the #term tab where it was before.

Hi, I just updated the plugin from version 0.9.2 to 0.10.0 but Octoprint still says that the plugin isn't update to date. Using Octoprint version 1.4.2.

With both this plugin and autoscroll plugin installed, the "expand all" and "collapse all" buttons get over written to "now" and "now" after scrolling back in the terminal history. Not sure if this is a fault here or with autoscroll.

Having the check boxes for which documentation repositories are used on the main interface is getting really cluttered. I use consolidated tabs and all the selections don't fit so I can't see all of them:

It would be nice to move these to a configuration interface to reduce the clutter. Maybe have a quick link to the configuration page (like a pencil icon next to the expand and collapse buttons) instead of always having to find it in the OctoPrint configuration window.

I am running multiple instances of OctoPrint, in all of the instances, this plug in is not producing references for the commands. I have tried dozens of commands and nothing, all say Unknown Command, I have uninstalled the plugin, done data clean up, reinstalled... can't seem to get this to work.

• OP 0.15.1
• Python 3.7.3
• Plugin 0.11.0
• Terminal Messaging 0.1.0

Let ne know if you need anymore information!