fileno unimplemented about test-mockfile

[FGasper]

How would this work? The point of Test::MF is precisely that there is no underlying file descriptor.

[toddr]

Randomly pick a number above 30 and below 1024? Check via posix if it handle is open?

Sure, someone could come along and use it out from under you. But I suspect it would be unlikely to affect the test

[toddr]

The code just needs to be filled in here https://github.com/CpanelInc/Test-MockFile/blob/master/lib/Test/MockFile/FileHandle.pm#L350

[FGasper]

I suppose that would facilitate same-filehandle checks, so I could see that being useful. It still seems pretty edge-y and not unlikely to lead to misuse and/or confusion.

[toddr]

I can't come up with anything positive you might do with fileno that might not lead to side effects.

I might be ok with us dieing in strict mode if fileno is called as this is unsupported for anything mocked.

[FGasper]

Yeah I’d think die()ing. There is no file descriptor for these filehandles; if you need a “real” test filehandle, use File::Temp?

[toddr]

We could do File::Temp but let's do die first and then if people want it, we'll think about enabling File::Temp on-demand if people need fileno for tests. Honestly, fileno is kinda a rare call in most code bases.

[FGasper]

I meant that the caller could do File::Temp. Seems out of scope for this library.