creack / goproxy

GoProxy is a ReverseProxy / LoadBalancer helper for Golang

Hi there 👋

goproxy's Issues

Thread safety when update the registry

if err != nil {
        reg.Failure(serviceName, serviceVersion, endpoint, err)
        // Failure: remove the endpoint from the current list and try again.
        endpoints = append(endpoints[:i], endpoints[i+1:]...)
        continue
}

This is thread unsafe, the modification of the slice should be placed inside reg.Failure and be protected by lock.

Should DisableKeepAlives be set to true?

Hello,

I'm using your code and when I got the logic working for my service, I noticed that it would only connect to one of the nodes I wanted to proxy to and not switch. What I was hoping for was that it would switch between nodes on every connection. (FYI, I implemented a round-robin algorithm)

So, my question is: should DisableKeepAlives be set to true on the http.Transport variable created in NewMultipleHostReverseProxy? Or am I missing something? Perhaps this could be something that is set when you call the method?