creeperhost / modpacksch-serverdownloader Goto Github PK

When using serverinstall_80_225 to install the Endeavour modpack and install it in the current folder. The version.json will get the wrong permission: --w----r--, which means that the owner doesn't have permission to read the file.

If you instead enter a folder name to install the modpack, the folder will get the wrong permission: d-wxr----x which also means that the owner doesn't have read access to the folder.

I run a Linux server using AMP. AMP has everything built in to select and setup minecraft servers (vanilla, fabric, forge, etc.). Normally, I just use the AMP interface to setup the minecraft and forge versions required and then just copy up the mods, config and other pack folders needed.

With the current process, I'm now forced to download an installer instead. Would there be any way to just specify a pack download for servers similar to what I've used in the past on CurseForge?

Modpacks like Direwolf20 1.18 now have a run.bat script from the Forge install. That script is now used entirely to start the server and there is no more Forge jar directly in the root folder of the server. The start.bat script shipped by the server installer fails to find the jar, therefore it's never put in the script.

I would like to suggest implementing something where if run.bat is found, that run.bat script is renamed to start.bat.

This will standardize installers for our users and the change should be retroactively compatible with old packs.
People will also stop being confused about 2 batch scripts and see only one. I have it documented in the server procedure https://go.ftb.team/create-a-server for them already and point them towards it when that happens, but I think my suggestion could be better for users.

Everytime I mean batch script I also mean shell script,

Idea suggested by jikuja on the FTB Discord, which I agreed with, was a good idea!

Thanks for looking into it, if you need to reproduce it download Direwolf20 1.18 from the FTB site: https://feed-the-beast.com/modpack/95_ftb_presents_direwolf20_1_18/server-files, then try and run the start.bat script to start the server

According to FTBTeam/FTB-App#618, it looks like a server installation will leave a broken start script behind if the Forge install fails. This affects Linux but I've also seen it on Windows.

It looks like the Forge install fails if Java isn't installed on the system, though the server installer is in Portable Executable format, not jar format.

I believe this may be counter intuitive to some users and they assume PEs hold dependencies already so they should work OOTB.

I would like to suggest (which seems possible) to download the runtime like it's done right now and to use that runtime to call the Forge installation silently. This would result in success all* the time!

Thanks for considering my suggestion

* When network behaviors and domains are normal for users

When I install the update 1.11.0 on my server (v 1.7.0) the update removes the xnet mod.

steps to reproduce

install 1.0.0
updates 1.0.1 - 1.2.0
updates 1.4.1 - 1.5.0
update 1.7.0
update 1.11.0

When using the serverinstaller on linux. (build 22.530.1936).

The start.sh script incorrectly adds a "./" to the path to both the JVM when chosen to install with the server

.//data/jre/jdk-17.0.2+8-jre/bin/java -javaagent:log4jfix/Log4jPatcher-1.0.0.jar -XX:+UseG1GC -XX:+UnlockExperimentalVMOptions -Xmx6144M -Xms4096M @user_jvm_args.txt @libraries/net/minecraftforge/forge/1.18.2-40.1.25/unix_args.txt nogui

If you skip the JVM install you get:
./java -javaagent:log4jfix/Log4jPatcher-1.0.0.jar -XX:+UseG1GC -XX:+UnlockExperimentalVMOptions -Xmx6144M -Xms4096M @user_jvm_args.txt @libraries/net/minecraftforge/forge/1.18.2-40.1.25/unix_args.txt nogui

I noticed that it is now deleting the run.sh that is provided by Forge. But you can retain it by using the --noscript flag which produces a usable run.sh/bat that you can use to start the server.

Seems related to this change here:

Every update, I need to run the new Serverinstall.exe multiple times hoping that one of them will include all files - it's like rolling dice.

Yes, I am using the most up-to-date installer, and no, it is not running out of a cloud-based folder. I have attached a copy of the .exe I am using.

serverinstall_100_2328.zip

Hi,

Your Linux installer for ftb-revelation is broken. the download fails at [877/975] Downloaded 'forge-1.12.2-14.23.5.2846-installer.zip' to './' [-1 bytes]...

Is there any way to get this as a .gz or .zip file?

Is there a verbose mode or a log file, because I don't see one.

Can you help me get ftb-revelation 3.4 up and running, on my ubuntu 20.04 headless server?

3.3 downloads almost everything except the forge installer jar (why does it download it as a zip?)

However when I download the correct jar and rename it to a .zip, it give me a TON of exceptions in the server startup jar.

crash-2021-02-09_17.53.52-server.txt

FTBTeam/FTB-App#216

Log File:
https://pste.me/@/mz21CAv9VT8/

Using FTB Skies 1.0.7
Windows 10

FTBTeam/FTB-Modpack-Issues#3256

FTBTeam/FTB-App#326

Installer version:
modpacks.ch server downloader golang - build 21.429.1632-darwin-amd64
based on commit c44f43c

The problem:
Running e.g. serverinstall_20_102 20 102 --auto (FTB Infinity Evolved Skyblock) fails to download two mods:

Error downloading https://dist.modpacks.ch/jds/bibliowood/naturawood/1.5/BiblioWoods%255BNatura%255D%255Bv1.5%255D.jar: checksum mismatch
Error downloading https://dist.modpacks.ch/jds/bibliowood/forestrywood/1.7/BiblioWoods%255BForestry%255D%255Bv1.7%255D.jar: checksum mismatch

and we can clearly see that the filename is run through the URL encode process twice.

https://api.modpacks.ch/public/modpack/20/102 returns addresses with URL encoding and installer probably does encoding again and is the requesting BiblioWoods%5BNatura%5D%5Bv1.5%5D.jar instead of BiblioWoods[Natura][v1.5].jar

Because of this bug server downloaded misses all files containing at least character [ and ] and other defined as reserved on RFC 3986.