crelies / remoteimage

Swift package for a SwiftUI remote image view

Hi there, I'm Christian 👋

Buy me a ☕ coffee if you want to support me 😎

• 🔭 I’m currently working on ••• (can't say right now)

• 🌱 I’m currently working with TheComposableArchitecture

• 👯 I’m looking to collaborate on open source projects

• ⚡ Fun fact: I started with Microsoft Windows when I was very young 😛

• 🎁 My AppStore apps:

  • VoucherList (iOS + iPadOS, macOS & tvOS; uses my Swift packages: AdvancedList & Media)

• ✍️ My blog posts:

  • VIPER 🐍 Architecture Evolution for iOS
  • Learn & Master ⚔️ SwiftUI basic components in 10 minutes
  • Meet & Greet — Advanced Lists in SwiftUI
  • Learn & Master ⚔️ Type Erasure in 6 Minutes
  • Learn and Master Remote Image View in SwiftUI
  • Meet & Greet - List Pagination in SwiftUI

remoteimage's Issues

How to remove cache for specific image url after image was loaded?

As I can see in the source code, RemoteImage cache supported to remove cache by key:

RemoteImageService.cache.removeObject(forKey: url)

But I don't know how to clear cache immediately after the image was loaded,
How can I do that?

Exposing fetchImage to prefetch image

Hi,
My app need to prefetch image and store it in cache.
After that we display the image later.

I tried to

let url:String = "https://..../image.jpg"
let imageType = RemoteImageType.url(URL(string: url)!)
let service = RemoteImageServiceFactory.makeRemoteImageService()
service.fetchImage(ofType: imageType)

But xCode notice me:

'fetchImage' is inaccessible due to 'internal' protection level

Can we expose the fetchImage func without leading to any issue?

Message from debugger: Terminated due to memory issue

Version 2.0.3

So I am using your image plugin to load JSON images from a number of URLs all at the same time. It seems your plugin might not like that.

Because it might also not be your plugin causing this issue I have uploaded the latest copy of the app to GitHub if you could take a look and let me know if I need to do some memory cleaning that would be great.

The issue only seems to happen when changing views after clicking on images.
You will also notice that for some reason the Main View seems to reload the images - that causes it to crash too.

Also each image is 3000x3000 (min for Apple iTunes Podcast directory)

Update

So I am still getting memory leaks, however I coded a small script to resize the images to the size the images are in the app (100x100) The app has not crashed, however still got the warnings.

https://github.com/redimongo/Radio-Podcast-SwiftUI-app

Termination due to memory usage issue

Hey there!

Using RemoteImage in a project of mine in which I'm using the List view and RemoteImage together and getting Message from debugger: Terminated due to memory issue.

Do you have any suggestion on how to mitigate this issue?

Thanks!

Doesn't load the image when in a Button

I've got an image in a button I'm trying to present to my users (their avatar). I want it to be in a button (specifically the navigation bar items, like in the App Store, but this bug applies to all buttons), but the image doesn't seem to load while in a button. It works absolutely as-expected when outside of a button.

Any ideas? I'm still pretty new to SwiftUI, and I can't seem to work it out.

Rebuild code for use with asset

I restructured your code to use it with asset and not with asset.localidentifier.
If you want you can update your code with my code, which I attach below.
Sources.zip

Would you consider an open source license for the package?

I'm working on an app for the norwegian java user group. It has so far 4 dependencies via swift package manager - 3 have MIT license and RemoteImage I can't see what licence if any applies.

Wondering if you'd consider adding an open source license? Personal preference for me (as it would fit with both the other dependencies and also with other things we do in the group) would be MIT - but of course that would be your choice :)