crewjam / errset Goto Github PK

Frequently we have code like this:

func foobar() error {
	errs := errset.ErrSet{}
	if err := foo(); err != nil {
		errs = append(errs, err)
	}
	if err := bar(); err != nil {
		errs = append(errs, err)
	}
	return errs  // should be errs.ReturnValue()
}

The problem is that returning errs rather than errs.ReturnValue() provides a non-nil error when it shouldn't.

Making it so ErrSet does not implement error would mean that the compiler could catch this.