cristalhq / flagx Goto Github PK

The documentation contains this line

// The return value will be ErrHelp if -help or -h were set but not defined.

But package does not provide type ErrHelp

Not everything is covered with tests in flagx.go file. Test can be very simple.

Currently PrintDefaults is the same as flag.PrintDefaults which is ok but aliases are duplicated:

=== RUN   TestFlagSet
  -ids value
    	just a timeout (default 1,2,3)
  -offsets value
    	just a timeout (default 1,2,3)
  -t duration
    	just a timeout (default 10s)
  -timeout duration
    	just a timeout (default 10s)
--- PASS: TestFlagSet (0.00s)

Which is not horrible but can be better. Copy-pasting flag.PrintDefaults and adding alias support should be enough.