cristiannic / mdatp Goto Github PK

Great you created a module! Here are just some random remarks:

name: I would use a more descriptive name so people will quicker understand the awesomeness of this module: microsoft_defender_advanced_thread_protection is maybe a bit long, but you could do something like ms_defender_atp or ms_threat_protection or ..

file locations: please move everything from the mdatp folder to the root of the project (see all other MR modules)

field names: although its only internally used, I would name the database fields more descriptively than item1, item2. It might even be less work to use the names MS gives these fields (just make sure to lowercase them)

The current client script keeps appending to the file, to prevent this, I would replace

# Output data
echo "item1${SEPARATOR}$healthy" >> ${OUTPUT_FILE}

with

# Output data
echo "item1${SEPARATOR}$healthy" > ${OUTPUT_FILE}

(note the single > which overwrites the previous file)

The output from /usr/local/bin/mdatp --health looks actually quite machine-parseable so you could point MunkiReport to that file and take care of it on the server.