croudtech / croud-layout Goto Github PK

Reported by Matt

If my session has expired the supercroud dashboard won't redirect me to the login if I link directly to /supercroud/dashboard/journals.

Update the readme to show recent enhancements, including

• Echo websockets
• Navigation
• Notifications
• Layout slots

Reports of the web token reverting to the original user's after becoming a new user.

Investigate please

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Once you have installed CI on this repository, you’ll need to re-trigger Greenkeeper’s initial Pull Request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organiszation’s settings page, under Installed GitHub Apps.

Issue

Navigation items aren't appearing when loosely matched permissions are set for a user. Currently the permission check on the navigation performs an exact match comparison, so doesn't account for wildcard matches.

Example & Details

a user should may have the permission 'academy.submission.*. This should grant access to menu items restricted to academy.submission.manage`, but doesn't.

The reason is that the code performs the following check:

Object.values(this.permissions).indexOf(item.permission) !== -1

Instead it should check for the following conditions:

Object.values(this.permissions).indexOf(item.permission) !== -1 ||
Object.values(this.permissions).indexOf(item.permission.replace(/\.\w+$/, '.*')) !== -1 ||
Object.values(this.permissions).indexOf(item.permission.replace(/(\.\w+){2}$/, '.*.*')) !== -1

(this code was obtained from the security mixin)

Testing this locally simply by replacing the code works, though this could be abstracted for re-use. A temporary fix is to apply these explicit permissions, though the use of wildcards would reduce the number of permissions rules required.

Investigate and Fix

Axios's handling of base urls can't be escaped like in vue-resource. Add new axios instance for legacy requests.

This appears on all SPAs utilising Croud Layout

JIRA task: https://croudcontrol.atlassian.net/browse/CC-1083

Links that are currently attributed with the external-link class in mixins/navigation.js should open in a new window.