cruxinator / php-bitmask Goto Github PK

Please forgive me if this is stupid.
I had expected to be able to instantiate a BitMask from a compiled integer, ie so that new Bitmask(3) would later allow me to check if both the Enum with the value of 1 and the one with the value of 2 would be set. This doesn't appear to work.

namespace app\Bitmasks;
use Cruxinator\BitMask\BitMask;
class TestFlags extends BitMask
{
    const GROUPA = 1 << 0;
    const GROUPB = 1 << 1;
    const GROUPC = 1 << 2;
}`

Now I was expecting to be able to do this:

$x = new TestFlags(3);
$x->isGROUPA(); // expected true
$x->isGROUPB(); // expected true
$x->isGROUPC(); // expected false

Instead of my expectation I receive Uncaught UnexpectedValueException: Value '3' is not part of the enum app\Bitmasks\TestFlags

Am I missing something obvious?

It can be done in the code, but @c-harris has asked me to add the issue so he doesn't lose track of it.

I was wondering why the getKey function didn't properly return flags when I realized it apparently expects every single value to be represented in the range of bits in the mask (in addition to a "zero" dummy value at the end of it all).

For instance, a bitmask that defines values of 1, 4, 128, you won't ever get a proper array for anything but the 1 value.

I propose that since each value is supposed to represent a single-bit mask in the bitmask anyways, the function could be thus:

    public function getKey()
    {
        $value = $this->value;
        $f     = array_filter(static::toArray(), function ($key) use (&$value) {
            return  $value & $key;
        });
        return array_keys($f);
    }