Image resources rely to full qualified path about cryogen

[lacarmen]

I'm not entirely sure what you mean here. Can you provide a better example of the problem?

[jayp]

I believe @kremers is saying that a relative resource like img/pic01.png works from /blog/index.html but not from /blog/pages/about.html or /blog/posts/2014-12-03-hello-world.html.

Rewriting URL for resources may be needed.

[kremers]

Exactly.

[dl1ely]

I recommend using absolute URLs like /img/pic01.png. Cryogen works with a single common img resource directory in mind (or many of them, if you configure :resources like that in config.edn). But still, all resources are copied to public/resources/ and not its sub dirs, so having relative URLs in posts does not seem to sensible here.

[kremers]

@dl1ely doesn't work since things like /blog/img are configured and some configurations rely on reverse proxies / specific url's.

Absolute URLs (on server side) are a bad pattern anyway (think about image resources are migrated to a CDN).

Other systems like jekyll offer a {{ site.url }} placeholder that defaults to the current site url without resources such as "assets" or "img".

http://jekyllrb.com/docs/posts/#including-images-and-resources

If such a site url is put absolutely in every page, a change to templates/config.edn >> :blog-prefix will have no effect on the image. Resulting in 404 for all images.

So there are various options how to fix this. For example:

1. Offer a site.url placeholder
2. Dynamic image resource path rewriting
3. An own image syntax (comes down to option 2).

[dl1ely]

@kremers URL for images are given in the Markdown files. Cryogen renders them and does not touch the contents itself. Upfront, i think that is a good thing in terms of simplicity. That is why i personally dislike your options 2 and 3, to be honest.

But it should be easy to do option 1, i think. Selmer tags should survive md-to-html-string conversation fine, and could be substituted in Selmers render-file function. We just have to supply a placeholder there, constructed from the :site-url and :blog-prefix keys of config.edn

[yogthos]

+1 for option 1 here as well

[lacarmen]

I've added this function to the compiler. It should inject the blog prefix in front of links to local resources.

For example, if you want to add img/pic01.png to a post and your blog prefix is /blog, the markdown should be ![pic01](/img/pic01.png). (Note the leading slash, this is required.) When the post gets compiled, the respective html will be <img src="/blog/img/cryogen.png">

Ps. I've migrated the compiler into a library here

[kremers]

Thank you very much for adding this functionality! 👍