cryptosense / multipart-form-data

multipart/form-data (RFC2388) parser for OCaml

multipart/form-data (RFC2388) parser for OCaml

This is a parser for structured form data based on Lwt_stream in order to use it with cohttp. You can use it to send POST parameters.

There are two APIs:

• a high-level one: parse_stream and get_parts. It works for strings, but has some problems with files.
• a low-level one: parse. It works for well for both strings and files.

multipart-form-data's Issues

`find_common` can be made more efficient

The current implementation builds a list of prefixes every time and checks if any is a suffix. It is possible to be better, either by precomputing the list of prefixes, or by building a suffix list.

How to tell the size of the file?

Right now we can get the name of a File via Multipart.file_name, and the body via Multipart.file_stream file - how can I get the number of bytes in the file?

Implement multipart-form-data creation

Would be nice to also create multipart-form-data. This is sort of why I became aware of the project (since I first started my own, same-named one, and realized it is silly), so if you don't mind I'd offer to contribute the creation part of it.

How to get the `filename` of a file, rather than `name`?

Right now, Multipart.file_name file returns the name= portion of the Content-Disposition header, and not the filename portion. Is there a way to get both?

`parse_part` dropping any instance of `\r\n`

Took awhile to track this down, but our binary uploads may contain \r\n in the file bodies somewhere, and it looks like Multipart is stripping every instance, leading to invalid files being stored to disk.

It looks like it might be here https://github.com/cryptosense/multipart-form-data/blob/master/lib/multipart.ml#L163 where all of the lines, having been split on \r\n, are simply concatenated together as-is, not restoring the \r\n that was there beforehand (to be clear, we need the bytes 0d0a to be in the final filestream).

I tried a few different hacks, but I'm not very familiar with Lwt_stream, and couldn't quite figure out how best to get it to interpose the streams I need. Any hints on how to make it work?

Make a release?

Would be great to cut a first release on opam, so that ocaml/opam-repository#7981 could be merged :-)

Thanks!