The ocaml-zxcvbn from cryptosense

ocaml-zxcvbn's People

Stargazers

Watchers

Forkers

khady

ocaml-zxcvbn's Issues

Memory corruption

The following piece of code generates errors in valgrind:

let random_char () =
  Char.chr (1 + Random.int 126)

let random_pass () =
  String.init 10 (fun _ -> random_char ())

let check_random_pass () =
  let s = random_pass () in
  let (guesses, _) = Zxcvbn.matches s in
  Printf.printf "%S: %f\n%!" s guesses

let () =
  while true do
    check_random_pass ()
  done

(I can send you a PR with that as a test ~exec:false executable if you'd like)

More precisely:

Invalid read of size 1
   at 0x18455E: ZxcvbnMatch (zxcvbn.c:1635)
   by 0x1829BD: zxcvbn_match_caml (zxcvbn_stubs.c:60)
   by 0x142153: camlFuzz__check_random_pass_1203 (fuzz.ml:9)
   by 0x1421D6: camlFuzz__entry (fuzz.ml:14)
   by 0x13F838: caml_program
   by 0x19D853: ???
   by 0x19DBD4: caml_main (startup.c:145)
   by 0x13F4CB: main (main.c:37)
 Address 0x5f9434b is 0 bytes after a block of size 11 alloc'd
   at 0x4C2BBEF: malloc (vg_replace_malloc.c:299)
   by 0x184442: ZxcvbnMatch (zxcvbn.c:1604)
   by 0x1829BD: zxcvbn_match_caml (zxcvbn_stubs.c:60)
   by 0x142153: camlFuzz__check_random_pass_1203 (fuzz.ml:9)
   by 0x1421D6: camlFuzz__entry (fuzz.ml:14)
   by 0x13F838: caml_program
   by 0x19D853: ???
   by 0x19DBD4: caml_main (startup.c:145)
   by 0x13F4CB: main (main.c:37)

This seems to be fixed in recent versions of zxcvbn-c, since upgrading to master solves this problem.

Thanks!

Recommend Projects