Comments (4)
I agree, but my domain knowledge is not sufficient enough to come up with all the possible values. If one can provide me a list of common usecases I'd be glad to add them. Also, if a specific implementation would like to use an own notification message, it would be best practice to discuss it with this community so other implementations could reuse it.
from ocm-api.
If there is a user for some other values then the process should go via the spec. Leaving it to implementations would not standardize much.
As said here #34 (comment)
I'm also not really happy with the current state of "notifications". I also wonder if, from a API point of view, such a collection with completely independent actions is better than dedicated calls like /shares/{id}/unshare
?
from ocm-api.
If one can provide me a list of common usecases I'd be glad to add them.
In order to be feature complete with Nextcloud I see following missing actions which could all be a "notification" or dedicated end-points. As said, I'm not sure what's better...
- unshare
- accecpt/reject a share
- permission change
- ask owner back to reshare the resource
- revoke re-shared file (from the owner to the person who re-shared it or the other way arround so that he can remove it from the shares list)
- exchange auth token (used for syncing user lists across trusted servers for auto completion)
from ocm-api.
I'm also not really happy with the current state of "notifications".
I think the intention of the notifications endpoint is not quite clear. I agree that this endpoint conflicts with strict API contracts between client and server and it is not a best practice if you just provide a public API. In this case however, we are trying to come up with a flexible model to let different implementations communicate with each other. Imho there should be a clear separation of the 'convenience calls' (e.g. /notifications
) and 'system calls' (which are required to make sharing possible at all). If permission communication is essential for OCM to work, then it should never rely on the /noticiations
endpoint. Therefore I think it's so important to do use a compact list of enumerated values which are allowed with /notifications
and maintain them within this project.
I also wonder if, from a API point of view, such a collection with completely independent actions is better than dedicated calls like /shares/{id}/unshare ?
Because /shares/{id}/unshare
requires a effort from the receiving party, while it is the complete responsibility of the sharing party. The sharing party can not rely on the receiving party to actual delete the share or change permissions, other than just informing the receiver that something changed.
from ocm-api.
Related Issues (20)
- updating shares HOT 1
- Server alias HOT 1
- Does OCM-API have any roadmap or plans for future development? HOT 4
- Deployment: preview of changes in API in a web HOT 1
- Are notifications allowed to have side-effects? HOT 3
- Activate GitHub Pages feature on this repo HOT 4
- [chore] Staging area for open PRs HOT 1
- NewShare field 'permission' is required but not defined HOT 1
- Document meshProvider field in NewShare HOT 3
- Endpoint discovery through https://example.com/ocm-provider/ HOT 4
- Group-owned shares and invites to/from groups HOT 3
- RFE: make invitation workflow symmetric HOT 1
- Cannot specify options per protocol in create share endpoint
- "protocol" or "protocols", which should implementers use? HOT 6
- Describe how "sharedSecret" may be used in WebDAV protocol HOT 3
- Do we want to support more than one protocol at a time? HOT 7
- Apply for funding to help develop Open Cloud Mesh within this community HOT 9
- Backwards compatibility HOT 5
- Document current translation that happens for webdav HOT 13
- support sub-shares? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ocm-api.