csc207-uoft / course-project-codemonkeys Goto Github PK

More command needed
Discord plug-in

Is it necessary to have a getId method in the Identifiable class or it's ok to just use user.id to get the id of the user

On our Division of labour, Jack and Charlie both write AssetManager.
Please resolve this conflict and get one person to write it.

Please consider adding a new command in the command parser so that the save process will be executed only when it's needed, to avoid unnecessary saves that possibly cost a significant amount of time

I suspect it is related to the latest pull request this afternoon.

see details in:
https://github.com/CSC207-UofT/course-project-codemonkeys/runs/4327305767?check_suite_focus=true

Title. This would eliminate the need to instantiate a new Execution checker and dataAccessInterface everytime we need to calculate the voting power.

@RaymondZhang24

Should it change or remain unchanged?

On our Division of labour, Tammy and Langson both write Upvote class.
Please resolve this conflict and get one person to write it.

When creating an ordinary user(with no authorities), create a CommonUser object.
When granting ban authority to a user, do user = new BanAuthority(user).
It is the same when granting control vote authority.

In addition, a Check_Authority method has been added. One can use it to check if the user has a certain authority.
For example, user.Check_Authority("Ban") returns true if the user has ban authority, and returns false otherwise.

The usage of Users in higher layers needs to be changed. Please feel free to contact me if you have any concerns/suggestions.

The Yahoo finance API is needed for commands such as check price, buy and sell, upvote and downvote.
How can we get the API or can we create a YahooFinaceApi instance in command?

The initiator of a vote can be any user instead of only common user

After reviewing our current codebase, I found that identifiable is an abstract class, not an interface. Would it be better if we change identifiable to an interface?

In the portfolio class, there are add and subtraction methods for a list of transactions, votes, and assets. The code can be refactored in future time.

Please delete the branch after you merged it.

Why:
Currently our Commands have no way of returning information to the client other than to hardcode it. For example, the "Help" command can print out a string to the terminal in IntelliJ, but then it cannot send that string to be printed in a discord server. So the purpose of ClientInterface is to serve as an extra layer between our UI, whether it's a command line or discord bot, and our actual business logic. This way, Commands can do tasks and return meaningful information without worrying about where to output that information. The "where" logic can be handled by new classes that implement ClientInterface, which in my opinion makes our program a lot more flexible and clean.

Responsibilities:

• To provide a method of returning information to the client

Implementation:

• input() method which handles any information passed from the client to our program
• output() method which handles any information passed from our program to the client
• Example: DiscordClientInterface allows inputs and outputs from Discord via the API
• Example: CommandLineClientInterface (or just CommandLine) allows inputs from the terminal, and outputs via system.out.println()

If this is to be implemented, then we need to change CommandParser and Command to take an extra parameter which is ClientInterface. Essentially, this allows our program to know what is coming in and*where it is coming in from.