csm10495 / cnvme Goto Github PK

Do these checks in checkForChanges() in ControllerRegisters. That way it can be handled immediately after the change occurs. Also we can modify ValidSubmissionQueues via that flow as well.

This will be interesting because technically a user can move the admin queue at runtime. Fancy.

Bring controller up to RDY == 1 then send a command. Check that the SQHD was 0. Then send one more, make sure SQHD was 1.

Controller::checkForChanges() should update via setIndex at the end of processing. We should use a while loop to pass all commands in the delta to processCommandAndPostCompletion().

Right now it only does on command max per check and will skip over all but one here.

Probably a good place to chance to possibly update Queue to have a head/tail field. The idea would be that the head would move up one command at a time until it == tail.

Also have it actually stop program execution in place. Release builds should have it stop, while debug should have it throw (or something like that).

Spec violation: currently the Controller is thinking of ACQS and ASQS as being 1-based. Should be 0-based.

Phase tag should be flipped by the controller after wrapping around.

Right now the math seems like it would be duplicated sooner or later.