ctchanandy / moodle-mod_advmindmap Goto Github PK

Hello,

Thanks for maintaining this very useful plugin! However, there are a couple of usability issues which have caused lost work from our observations. It's very easy to overlook the little "disk" icon, and loser one's mind map drawing after exiting the page. This has happened numerous times to us.

It would be very helpful if Mind map would give an alert dialog or something to prompt users to save changes before they exit the mind map canvas page.

Also, tooltips on toolbar icons and a "Save Changes" button under the canvas might also be Moodle-consistent ways to help users use the plugin and avoid losing their work.

Thank you!

Fatal error: Class 'backup_advmindmap_activity_task' not found in backup/util/factories/backup_factory.class.php on line 107

I believe that's there is a typo in

classes/event/course_module_instances_list_viewed.php

where the class is defined without the "s" and this causes a fatal php error in index.php line 44.

I want to join the post. A couple of errors.

1. Why do some shows an error that no students. If you go on this link, then you get on any site Moodle, where he also says that there is no information about the error.
2. When you press the "Continue" button, then dumped in general and of course you get to the general menu Bibliokluba.

The intro text must be pre-processed to get the links to images or video embedded resolved to a real link, otherwise the link contains only @@PluginFile@@

The view.php around line 258 should be changed as follow:

if (!empty($advmindmap->intro)) {
echo $OUTPUT->box(format_module_intro('advmindmap', $advmindmap, $cm->id), 'generalbox', 'intro');
}

There's a bunch of lines that are too legacy into view.php, along the students searching. Using the hardcoded value 5 to get all the students in a course, is not valid anymore in new setups of moodle.
The suggestion is to change the code as follow (diff raw)

--- a/view.php
+++ b/view.php
@@ -454,14 +454,11 @@ if (has_capability('mod/advmindmap:viewother', $context)) {
echo $OUTPUT->footer();
die;
}

•        // Get all students in the course
  

•        // Get all students in the course able to view mindmaps
       $context = context_course::instance($course->id);
  

•        $params = array($context->id, 5);
  

•        $sql = "SELECT u.id
  

•                FROM {role_assignments} AS a, {user} AS u 
  

•                WHERE contextid = ? AND roleid = ? AND a.userid = u.id
  

•                ORDER BY u.lastname ASC";
  

•        if ($students = $DB->get_records_sql($sql, $params)) {
  

•   $students = get_enrolled_users($context);
  

•        if (count($students) > 0) {
           $students = array_keys($students);
       } else {
           notice(get_string('errornostudentincourse', 'advmindmap'));
  

In line 58 the string should be corrected as follow:

$string['notavailable'] = 'Not available yet';

Hi,
Not really an issue, but it coul'd be interesting to have releases or tagged versions in the Git. Like this we could automatised update plugin from Git for Moodle installations. It's sometimes a prerequisite for plugin installation autorisation like in my organisation :-(

Cheers

Hello,

Will this plugin support moodle 3.3 and 3.5? @ct

Hello,

When advanced mindmap is enabled and I navigate to site administration -> grades -> scaIes, I see an empty page. If I disable that plugin, the scales page shows fine. this is the error I found in the error log of Apache:

PHP Fatal error: Call to undefined function record_exists() in /var/www/elo/html/mod/advmindmap/lib.php on line 324, referer: https://elo.ictmbo.nl/admin/modules.php?show=advmindmap&sesskey=lkuA2VM52o