GithubHelp home page GithubHelp logo

ctreatma / beer_bot Goto Github PK

View Code? Open in Web Editor NEW
2.0 2.0 1.0 124 KB

A Sinatra-based Slack integration for fetching tap lists from PhillyTapFinder

Home Page: https://beermebot.herokuapp.com

License: MIT License

Ruby 100.00%

beer_bot's People

Contributors

ctreatma avatar

Stargazers

 avatar  avatar

Watchers

 avatar

Forkers

edkozek

beer_bot's Issues

Allow searching without punctuation

I think this requires setting up a crawler to ingest PhillyTapFinder data and building a custom API to serve the ingested data, rather than hitting PTF directly.

Add fallback data sources

If results aren't found in PTF, fall back to searching elsewhere. "Elsewhere" will probably be Untappd, although that likely requires some notification that the listed beers may not be drafts.

Include beers in search results

beer_bot is currently limited to searching bars, in an attempt to keep responses from growing too large. Instead, beers should be included in search results, and users will need to search carefully.

Beers that belong to events but not tap lists display incorrectly

PhillyTapFinder shows Russian River Consecration as available at 0 bars and 2 events, but BeerBot reports that it is at 2 bars and 2 events:

Beers

  1. Russian River Consecration (Sour/Wild-Fermented Ale; Santa Rosa, CA) is on tap at 2 bars and 2 events
  • Isaac Newton's () as of Last Updated: 01/15/15
  • Brü Craft & Wurst () as of Last Updated: 01/15/15
  • Russian River on 01/31/2015 at Isaac Newton's (18 South State St., ...)
  • Sour Bowl on 01/25/2015 at Brü Craft & Wurst (1316 Chestnut St.)

Add instructions to readme

There should be instructions for setting up a beer_bot instance, and maybe even one of those nifty "Deploy to Heroku" buttons.

Bar names, etc., are combined in beer listings

Beer search results list bars incorrectly when a beer is available at multiple bars:

Beers

  1. Russian River Consecration (Sour/Wild-Fermented Ale; Santa Rosa, CA) is on tap at 2 bars and 2 events
  • Isaac Newton'sBrü Craft & Wurst (18 South State St., ...1316 Chestnut St.) as of Last Updated: 01/15/15Last Updated: 01/15/15

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.