cuducos / whiskyton Goto Github PK

views.py

• instead of this string concatenation:

wlist = '['
for whisky in whiskies:
wlist = wlist + '\n "' + whisky.distillery + '",'
wlist = wlist[:-1] + '\n]'

• use the json module:

import json
...
wlist = json.dumps([whisky.distillery for whisky in whiskies])

You could also look into using an IDE that has PEP-8 validation built-in. Personally, I use PyCharm 3, but there is tons of other choices.

http://stackoverflow.com/questions/1471994/what-is-setup-py

Basically, when some search fails, we have to do two tasks:

• Save whatever users are looking for (and not finding)
• Offer a close option (something like http://www.smashingmagazine.com/2014/08/12/a-better-404-page/)

In app/views.py:
Lines 39-44 query for the “best” correlations, while line 48-50 use the ID from the first query to get whisky data of each whisky.

I can't find any reference to a whisky named Craigganmore, but Cragganmore certainly exists, and is missing from your database.

I have no idea about how to start it. I'm open to pair programming tutors (;

… but I'm no graphic designer. Feel free to get in touch if interested to contribute with some design (;

You should use abort(404) instead of redirect('/404') when you can't find a page. The "problem" with that redirect is that it doesn't throw an HTTP error code 404 as you should when you can't find a page, it just returns 200 OK. You can still have a custom error page with abort, look at this page in the Flask doc.

http://flask.pocoo.org/docs/patterns/errorpages/

Not possible: no use of getattr() in templates

Example: when typing "Glen” there's no indication that there are more than five matches

Make a correlations table (and query) that avoid duplicate correlations (e.g. correlation between whisky=19 and ref=32 could be the same row of whisky=32 and ref=19)