GithubHelp home page GithubHelp logo

Comments (4)

jacobmealey avatar jacobmealey commented on June 18, 2024 1

Hmmm it looks like something in url api may have changed in the recent curl release? If I build trurl against an older version the tests pass but when I build against 8.3.0 the tests fail in the same way described by @abbbi and our github actions use a pretty old version of curl so that's why it wasn't caught earlier.

from trurl.

emanuele6 avatar emanuele6 commented on June 18, 2024 1

It is simply getting a different error message.
Since errors for those tests now differ in different versions of libcurl, and the exact errors do not matter, you could just change the stderr expectation for those tests to true:

diff --git a/tests.json b/tests.json
index 8222c14..fe48b6c 100644
--- a/tests.json
+++ b/tests.json
@@ -1488,7 +1488,7 @@
                 }
             ],
             "returncode": 9,
-            "stderr": "trurl error: No host part in the URL []\ntrurl error: Try trurl -h for help\n"
+            "stderr": true
         }
     },
     {
@@ -1744,7 +1744,7 @@
         "expected": {
             "stdout": "emanuele6://curl.se/trurl\nhttps://example.org/\n",
             "returncode": 0,
-            "stderr": "trurl note: No host part in the URL []\n"
+            "stderr": true
         }
     },
     {

This is already supported by the test runner, and will be satisfied if the command results in anything being written to stderr instead of exactly "trurl error: No host part in the URL []\ntrurl error: Try trurl -h for help\n". (it will only not be satisfied if nothing is written to stderr)

from trurl.

abbbi avatar abbbi commented on June 18, 2024

the changed behavior is caused by following commit in curl url api:

curl/curl@b664b00

fix for:

curl/curl#11714

reverting this one in libcurl and linking trurl against shields the old behavior:

./trurl: /home/abi/trl/curl/lib/.libs/libcurl.so.4: no version information available (required by ./trurl)
[
  {
    "url": "ftp://example.org/",
    "parts": {
      "scheme": "ftp",
      "host": "example.org",
      "path": "/"
    }
  }
]
trurl error: No host part in the URL []
trurl error: Try trurl -h for help

from trurl.

abbbi avatar abbbi commented on June 18, 2024

@emanuele6 thanks, i just added this patch to the debian package for now. PR (#240)

from trurl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.