Comments (4)
Hmmm it looks like something in url api may have changed in the recent curl release? If I build trurl against an older version the tests pass but when I build against 8.3.0 the tests fail in the same way described by @abbbi and our github actions use a pretty old version of curl so that's why it wasn't caught earlier.
from trurl.
It is simply getting a different error message.
Since errors for those tests now differ in different versions of libcurl, and the exact errors do not matter, you could just change the stderr
expectation for those tests to true
:
diff --git a/tests.json b/tests.json
index 8222c14..fe48b6c 100644
--- a/tests.json
+++ b/tests.json
@@ -1488,7 +1488,7 @@
}
],
"returncode": 9,
- "stderr": "trurl error: No host part in the URL []\ntrurl error: Try trurl -h for help\n"
+ "stderr": true
}
},
{
@@ -1744,7 +1744,7 @@
"expected": {
"stdout": "emanuele6://curl.se/trurl\nhttps://example.org/\n",
"returncode": 0,
- "stderr": "trurl note: No host part in the URL []\n"
+ "stderr": true
}
},
{
This is already supported by the test runner, and will be satisfied if the command results in anything being written to stderr
instead of exactly "trurl error: No host part in the URL []\ntrurl error: Try trurl -h for help\n"
. (it will only not be satisfied if nothing is written to stderr
)
from trurl.
the changed behavior is caused by following commit in curl url api:
fix for:
reverting this one in libcurl and linking trurl against shields the old behavior:
./trurl: /home/abi/trl/curl/lib/.libs/libcurl.so.4: no version information available (required by ./trurl)
[
{
"url": "ftp://example.org/",
"parts": {
"scheme": "ftp",
"host": "example.org",
"path": "/"
}
}
]
trurl error: No host part in the URL []
trurl error: Try trurl -h for help
from trurl.
@emanuele6 thanks, i just added this patch to the debian package for now. PR (#240)
from trurl.
Related Issues (20)
- Construct and build URLs from JSON HOT 5
- Tests fail with out IDN HOT 7
- Using `--iterate foo='bar baz'` and `--set foo='rab'` at the same time is not an error HOT 4
- trurl's checksrc.pl is outdated
- Add more options for configuring curl_url_set() HOT 6
- `trurl --trim scheme`? HOT 3
- Query params values in JSON output have NUL replaced by . HOT 4
- Shell Mode Feature HOT 1
- Test fails on windows because of different null device name HOT 4
- Please support zero-sized fragment and query HOT 9
- unable to selectively remove query parameters with asterisk in them HOT 5
- Invalid characters in scheme give wrong error HOT 2
- new version release with recent fixes? HOT 1
- About the release scheme HOT 6
- Components with control characters don't appear in `--json` output, and non-urlencoded `--get` fails HOT 3
- [FR] allow JSON input in the same form as JSON parts output HOT 3
- incorrect decode of %3d as = character in query string leads to out of bound reads
- incorrect decode of %00 in query string leads to out of bound reads when printing the param key HOT 2
- incorrect handling of strings with null characters in memdupdec causes out of bounds write to adjacent memory region HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trurl.