cvrebert / lmvtfy Goto Github PK

View Code? Open in Web Editor NEW

315.0 315.0 32.0 58.74 MB

LMVTFY: Let Me Validate That For You

License: MIT License

Scala 99.64% Shell 0.36%

lmvtfy's People

Contributors

Stargazers

Watchers

lmvtfy's Issues

For a pen http://codepen.io/dongepulango/pen/lufdb/
It should canonicalize to http://s.codepen.io/dongepulango/fullpage/lufdb?
And it looks like we need to spoof a Referer of http://codepen.io/dongepulango/full/lufdb/

X-Ref: twbs/bootstrap#14300

Needs documentation

Try to make PlainText a case class

Catch unlikely-but-possible exceptions that validator might throw

See FIXME comments in the code.

LiveExample: refactor to avoid repeating same path construction

Ignore <img> missing `alt` attribute

This is an accessibility problem, not a core markup validity problem.
Example: twbs/bootstrap#13896 (comment)

Allow /lmvtfy/ (with trailing slash) to work too

Ignore extra title in Bootply's head

X-Ref: twbs/bootstrap#13980 (comment)

There's currently an extra, empty <title> in Bootply's render view. I tweeted at Bootply, but we might want to ignore the following erros until they fix that.

"Element title not allowed as child of element head in this context. (Suppressing further errors from this subtree."
"Element title must not be empty."

Integrate scoverage and/or Coveralls

https://github.com/scoverage/sbt-scoverage
https://github.com/scoverage/sbt-coveralls

subdomain support?

I wanted to run lmvtfy at 'lmvtfy.mydomain.com' but it appears this is not supported. also tried to have it run next to apache2 (as vhost) but this also didnt work.

Listen for PR comments too

Refs twbs/bootstrap#14015

Find a way to move the config file outside of the JAR

Having to rebuild the JAR when making a config change is annoying.
Also, I'm paranoid that I'm going to accidentally commit the production login credentials at some point. If it's a separate file, I can put it in gitignore.

Implement extraction of HTML from Markdown code blocks

Using https://github.com/sirthias/pegdown ?

Actor error recovery

New actors need to be spawned if the main ones somehow die.

Add tests for examples associated with user accounts

Their URLs differ in some cases; will need more canonicalization logic.

Integrate with Bootlint

Set Content-Type: text/html; charset=UTF-8
POST the HTML to /
Load the JSON. Schema: [{id: string, message: string}]

JS Fiddle checking broken

Ignore bad <meta> that JS Fiddle is now including

<meta http-equiv="edit-Type" edit="text/html; charset=utf-8" />

Refs twbs/bootstrap#14681

meta charset within first 512 bytes of a file

JS Bin recently started putting a big comment before the opening html tag, so the validator will now report an error which the user has no influence on. See twbs/bootstrap#14028 (comment) and as an example this Bin.

<!--
Created using http://jsbin.com

Copyright (c) 2014 by hnrch02 http://jsbin.com/voleso/1/edit

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the “Software”), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-->
<html>
  <head>
    <meta charset="utf8">
  </head>
  <body>
  </body>
</html>

Add link to GitHub repo at end of generated comments

Use proper templating system for generating the comment

stop lmvtfy from hitting google up about facebook

I've noticed that akka? lmvtfy is making outbound requests to google, searching for facebook... any way to stop this? also notice java.io.IOExceptions too...

[DEBUG] [06/30/2014 06:28:29.588] [on-spray-can-akka.actor.default-dispatcher-1208] [akka://on-spray-can/user/IO-HTTP/listener-0/233] TcpConnection terminated, stopping
[DEBUG] [06/30/2014 06:31:29.253] [on-spray-can-akka.actor.default-dispatcher-1208] [akka://on-spray-can/system/IO-TCP/selectors/$a/0] New connection accepted
[DEBUG] [06/30/2014 06:31:29.258] [on-spray-can-akka.actor.default-dispatcher-1216] [akka://on-spray-can/user/IO-HTTP/listener-0/234] Dispatching GET request to http://www.google.com/search?btnG=1&filter=0&start=0&q=facebook.com to handler Actor[akka://on-spray-can/system/IO-TCP/selectors/$a/237#-1409863182]
[DEBUG] [06/30/2014 06:31:29.263] [on-spray-can-akka.actor.default-dispatcher-1208] [akka://on-spray-can/user/IO-HTTP/listener-0/234] Connection was PeerClosed, awaiting TcpConnection termination...
[DEBUG] [06/30/2014 06:31:29.263] [on-spray-can-akka.actor.default-dispatcher-1208] [akka://on-spray-can/user/IO-HTTP/listener-0/234] TcpConnection terminated, stopping
[DEBUG] [06/30/2014 07:40:23.963] [on-spray-can-akka.actor.default-dispatcher-1215] [akka://on-spray-can/system/IO-TCP/selectors/$a/0] New connection accepted
[DEBUG] [06/30/2014 07:40:24.020] [on-spray-can-akka.actor.default-dispatcher-1221] [akka://on-spray-can/system/IO-TCP/selectors/$a/238] Closing connection due to IO error java.io.IOException: Connection reset by peer
[DEBUG] [06/30/2014 07:40:24.020] [on-spray-can-akka.actor.default-dispatcher-1220] [akka://on-spray-can/user/IO-HTTP/listener-0/235] Connection was ErrorClosed(Connection reset by peer), awaiting TcpConnection termination...
[DEBUG] [06/30/2014 07:40:24.021] [on-spray-can-akka.actor.default-dispatcher-1220] [akka://on-spray-can/user/IO-HTTP/listener-0/235] TcpConnection terminated, stopping
[DEBUG] [06/30/2014 07:51:05.358] [on-spray-can-akka.actor.default-dispatcher-1220] [akka://on-spray-can/system/IO-TCP/selectors/$a/0] New connection accepted
[DEBUG] [06/30/2014 07:51:05.364] [on-spray-can-akka.actor.default-dispatcher-1225] [akka://on-spray-can/user/IO-HTTP/listener-0/236] Dispatching GET request to http://www.google.com/search?btnG=1&filter=0&start=0&q=facebook.com to handler Actor[akka://on-spray-can/system/IO-TCP/selectors/$a/239#725631304]
[DEBUG] [06/30/2014 07:51:05.368] [on-spray-can-akka.actor.default-dispatcher-1220] [akka://on-spray-can/user/IO-HTTP/listener-0/236] Connection was PeerClosed, awaiting TcpConnection termination...
[DEBUG] [06/30/2014 07:51:05.368] [on-spray-can-akka.actor.default-dispatcher-1220] [akka://on-spray-can/user/IO-HTTP/listener-0/236] TcpConnection terminated, stopping

twbs/bootstrap#13834 (comment)
lmvtfy/src/main/scala/com/chrisrebert/lmvtfy/validation/MessagePart.scala

Line 21 in 4094485

object SpellingErrorCorrector {

<script>
  start({"html":"...the Bin's HTML is here...","css":"","javascript":"","url":"http://jsbin.com/kegunocasoye"}, {...}, this, document);
</script>

And edit pages continue to work after Bin expiration.

Try to have only one instance of the validator

Try to reuse one instance of the validator instead of creating a new one for every validation request. More efficient obviously.

cvrebert / lmvtfy Goto Github PK

lmvtfy's People

Contributors

Stargazers

Watchers

Forkers

lmvtfy's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs