cyclopsmc / integratedterminals Goto Github PK
View Code? Open in Web Editor NEWTerminals for managing and overviewing Integrated Dynamics networks
License: MIT License
Terminals for managing and overviewing Integrated Dynamics networks
License: MIT License
When attempting to auto craft a display panel from integrated dynamics inside of a storage terminal the terminal would hang at the crafting plan screen showing the message "Calculating crafting plan..." and would never craft the item.
I was able to reproduce this bug in a fresh instance of minecraft and a fresh world.
I built a storage terminal and connected it to a chest.
I placed a crafting table with a crafting interface on top of it and connected it to the network.
I then made all the recipe cards that are required to craft a display screen and put them into the crafting interface.
I filled the chest with everything it needed to craft a display screen.
When I tried to autocraft a display screen from the storage terminal it hung at the crafting plan menu.
So far I've seen this happen with the display panel and the storage terminal when trying to autocraft them.
Note: If you don't have the required items to craft the display panel then the crafting plan screen works normally and shows you what you are missing.
What normally happens with other recipes is it shows that it has all of the components to craft the item and then you can press the craft button to craft it. If it does not have all the components to craft the item then it shows you what you are missing so you can add it to the network and then try again.
If you go to extract items from a terminal with your mouse cursor, you can end up clicking between slots in your player inventory, returning the items to the system.
https://i.imgur.com/eLM2dkR.png
Expected behaviour is no gap when mouse-overing slots.
https://i.imgur.com/x8CYl7K.png
Integrated Terminals: 1.0.1
whenever a valid recipe is made in the crafting tab of a terminal and viewed, the same item will appear in the player's 2x2 inventor recipe grid
attempting to take the item will cause it to dissapear
i expected that it wouldn't do that
I.Terminals & Tunnels sais it requires Intergrated Dynamics vers 1.0.9 or higher, but as yet no such version exists, is this an Error or ?
When I boot up my game and enter my world I open up my crafting terminal and click sort by item count and it crashes.
I just open my storage terminal and click the sort by item count button then it freezes for a bit then the game window completely closes.
It used to sort by item count just fine? But now it crashes every time without fail.
Most Blocks from the GregTech Community Edition are invisible when viewed from the terminal.
all blocks are shown
Game crashes occasionally when opening terminal
____Terminal Open
When using a terminal with JEI synchronization disabled, the search box text updates if the JEI search box is updated
If JEI synchronization is disabled, the search box should not update
When doing a large craft in the crafting terminal it doesn't let you use more than 64 ingredients in the craft. For example if you want to do 100 plank crafts (which comes out to 400 planks) it can't do it because in the crafting plan menu it will say 64 logs stored and below it will say missing 36 logs and it will be unable to craft.
To reproduce you can just make a new world and setup an autocrafting system and start an autocraft that will require the system to use more than 64 ingredients during the craft.
I expected it to use all my logs to craft any number of planks I tell it to.
https://pastebin.com/FrvQzdDB
(I don't think this log will help? There was no error when the craft failed.)
Even though I implemented this before, storage updates are not being updated instantly after interaction with the terminal.
auto complete certain recipes from jei
unable to pull certain recipes from jei even though the items are in the system
i will give 1 item as an example, the world block exporter
it should auto complete the recipe because you have a diamond pick in your system
Sometimes, shift clicking items while in the terminal makes it go into the crafting grid on the crafting tab
Is the terminal meant to have this slowish lag to it? ergo, I pull an item out and a second later it is removed.
Is there something I can change to make it not?
1: pressing the mouse wheel multiple times should take more of that item out of the storage, instead of just putting it in and out
2: scrolling the mouse wheel should allow you to select a specific amount to take (scroll down should "select" more of that item to transfer and scroll up should "unselect" more of said item)
3:shift+middle click should take 1 of the selected item directly into/out of the selected inventory each time.
Hello,
I found 2 issues with mousetweaks :
1st issue :
When you input multiple items in the terminal with mouse tweaks, aka holding shift and left click and moving the mouse over all the items in your inventory you, the first item/stack on wich you started shift clicking doesn't go in (you have to go over it a second time)
2nd issue :
the items inserted that way don't go in the storage, they directly go in the crafting tab
Here's a video that might help you understand what I mean by that :
https://streamable.com/c8ztm
Items should go in the storage just like when you shift click one item slot at the time. :)
when on the crafting tab of terminal, any recipe you have makes the terminal assume you actually have it with JEI recipe auto-completion
it should highlight the missing items [e.g. sticks] instead of showing a successful autocomplete.
When attempting to access the Crafting Terminal, it caused a server crash.
Note: This crash occurred twice on stream (can provide link, if desired), but was not reproduceable in single player
Expected behavior was to open Crafting Terminal without issue. We know now that because there was no Storage Terminal attached to the system, it wouldn't have done anything, but we did not expect it to crash the server.
When the storage terminal is removed with wrench, the item in the crafting grid will drop.
This will copy items.
Items in the crafting grid should not be dropped when the storage terminal is removed with wrench, because they are already stored in the NBT of the storage terminal.
When holding backspace in a search box in the terminal UI it would be convenient for the text to incrementally delete. Currently deletion requires repeatedly pressing backspace.
When taking an item stack out of the terminal while the terminal is set to sort on item amount, and dragging with the left or right mouse button, after letting go the items left in the cursor switch with another one.
Item picked up should stay the same item.
When viewing the progression of a complicated crafting job in the Crafting Terminal, the client sometimes crashes when one of the subjobs completes.
I'm not sure if the issue is 100% reproducible, but I know that it did happen when crafting Actually Additions Phantomfaces from scratch (crash happened when the subjob for Diamatine Crystals finished).
The client shouldn't crash when a subjob completes.
Attempting to craft a stack of "Block of Crystalized menril" causes the server to hang for > 30 seconds.
Setup:
A chest, a mechanical squeezer, mechanical drying basin, a drawer controller and ~50 drawers connected in a network (Terminal says ~8.5k items in storage).
Profiler while server was hanging (crafting 33 blocks, which was "fast" enough to not cause the server watchdog to trigger):
[10:16:04] [EntityProfiler/INFO] [TickProfiler]:
TPS: 13.894211
Single Entity | Time/Tick | %
monster.EntityZombie -47,16,119:0 | 0.152 | 1.442
PlantInteractorTile {37,65,26}:0 | 0.131 | 1.241
item.EntityItem 52,26,81:0 | 0.089 | 0.838
monster.EntityZombie -31,62,-82:0 | 0.073 | 0.695
passive.EntitySheep 121,69,31:0 | 0.067 | 0.630
Chunk | Time/Tick | %
0: 7, 2 | 2.069 | 19.575
0: 8, 2 | 0.557 | 5.269
0: 2, 1 | 0.460 | 4.356
0: 3, 0 | 0.325 | 3.077
0: 4, -2 | 0.266 | 2.521
All Entities of Type | Time/Tick | %
passive.EntitySheep | 1.695 | 16.034
monster.EntityZombie | 1.613 | 15.266
entity.EntityFrog | 1.156 | 10.934
passive.EntityCow | 1.141 | 10.797
monster.EntitySkeleton | 1.015 | 9.603
Average Entity of Type | Time/tick | Calls
PlantInteractorTile | 0.051 | 2502
monster.EntityZombie | 0.051 | 26548
TileMechanicalDryingBasin | 0.050 | 834
tile.TileContOreT1 | 0.044 | 834
monster.EntitySkeleton | 0.042 | 19932
Sampler, from when attempting to craft a full stack:
serverhang.zip
Spark profiler, from when attempting to craft a full stack:
https://sparkprofiler.github.io/#wPmAbJSSzR
crash-2019-08-25_20.41.50-client.txt
Minecraft crashes after requesting a big recipe
If you have "Auto-refill crafting grid" disabled, it still refills the grid after you craft something, even though it is set to disabled.
Integrated Terminals: 1.0.6
Currently, if you have previously used the storage terminal in a session and re-open it, it remembers which tab you were viewing. However, on world load, it currently doesn't default to a tab - it would be nice if this could pick a tab to open on by default, should the tab be available.
issue type: bug
when a server restarts integrated networks become corrupted, all integrated tunnels interfaces/importers/exporters cease to work, and integrated terminals will crash the server due to a ticking player. attached is the crash log for the server, networks become un-corrupted after all connectors of every integrated dynamics/addons are pulled up and placed down again
integrated dynamics version: 1.0.3
integrated terminals version: 1.0.1
integrated tunnels version: 1.6.2
crash-2019-02-20_19.37.22-server.txt
(i have no idea how to use github, sorry if i missed any info)
When i pull an item or a stack of items from my terminal and try to place it in an inventory slot that already contains other items, the first item or stack of items disappears.
1.pull an item from your terminal and place it in your inventory in a slot that already contains items
the new item should occupy the slot in the inventory and the item that was there should end up in your cursor , just like pulling an item from a chest and doing the same thing.
IntegratedTerminals-1.12.2-1.0.6
Minecraft 1.12.2
Forge 14.23.5.2781
when you put a predicate filter in the slot, all crafting recipes will be shown, regardless of if they are valid via the predicate
recipes should respect the predicate inserted
Display the history of a synthetic article in the crafting job terminal
In the crafting job terminal, you can lock the quantity of a synthetic history record, and keep the locked items in the network no less than the set value
When opening the controls menu, Minecraft crashes with a NullPointerException. Removing Integrated Terminals fixes this issue.
Expected to open up the controls menu to change my auto-jump setting.
Railcraft Creosote Bottles are magically transformed into whatever fits into your fluid storage when shift-clicking them into the storage terminal's fluid tab. I tried this with a max-upgraded metal drum from "Barrels, Drums, Storage & More"
Also, if I click Creosote Oil fluid and then click an empty bottle, it takes 100 buckets of Creosote Oil out instead of 1.
Picking up an empty or filled bottle and clicking it into the terminal works as expected (i.e. transfers only 1)
I'd assume the same issue arises with Railcraft's other bottle, the Steam Bottle.
I expect Creosote Bottles to be worth exactly 1 bucket of Creosote Oil.
Not 100 and certainly not between 32768 and infinity :)
Other related mods:
$ md5sum {Integrated,Barrels,railcraft}*.jar
c1aff93e2ddcedda892e338dd1cc0950 *IntegratedCrafting-1.12.2-1.0.8.jar
82b15eaa0c2b4421408db074ff464374 *IntegratedDynamics-1.12.2-1.1.0.jar
66f8eef05a5347180992a58adcc3e878 *IntegratedTerminals-1.12.2-1.0.11.jar
4dcb9b2079097ca6ae15cd723f071f94 *IntegratedTunnels-1.12.2-1.6.10.jar
948d49b065fd9f07cc046111d93b0700 *BarrelsDrumsStorageAndMore-0.0.24.jar
b6f0592e8f5c24d07fe065f1c97c8fda *railcraft-12.0.0.jar
Hey suggestion to add a config that reverse the button to clear the crafting grid. so when you normally click it goes in too storage and if you shift click it goes too the player
a mode for the crafting job terminal that can give an exact count of what's missing and what's available for an uncraftable task in a straight list instead of a tree
when trying to put a recipe into the crafting grid using JEI while holding shift when pressing the button puts the wrong items in the wrong spots
this is what happens when trying to craft a chest (grid was empty before):
try crafting any recipe when holding shift while pressing the + button in JEI
it should act the same as if you were not holding shift
When scrolling through a crafting plan in a crafting job terminal, the scroll bar gets reset to the top every second. In the GIF below, I am never manually scrolling up or re-expanding the sections.
Your scroll position should remain the same when the gui updates. It should only scroll back up if the crafting plan becomes shorter such that your current scroll height would be out of the new scroll area. Collapsed sections should also remain collapsed.
Auto-fill crafting grid will full stack of items if those items already exist in the system, and only refill the items if there is none of them instead of refilling them every time.
It allows a faster crafting process as it requests lesser requests from the system, as the crafting is a bit slow when crafting a large amount due to the need of pulling necessary items every time an item is crafted. If possible, caching the recipe like what FastWorkbench did can help as well.
Some mods like Simple Storage Network and Crafting Station from Tinkers Construct are able to mimic the vanilla crafting table, and thus able to use what FastWorkbench provides to speed up the crafting speed. Maybe they can be a good reference.
Send back items to the network on default when calling a new recipe from JEI.
I found that most of the time items are pulled from the network instead of player inventory, so it would make more sense that those items should be back to the network on default. It will be great if it is configurable by either mob config or GUI.
Related to #39
Thanks for the great mod. Finally, I can get rid of the bits based storage system like AE and RS.
It would be nice if previous storage terminal settings (tab selected, JEI sync mode, sort mode etc) could be persisted - saving the settings on exit and loading again when loading the world back.
Using an Actually Additions Player Interface and a Storage Terminal, you can dupe any stackable item as long as you have more than half a stack of it.
No dupe :)
Other related mods:
$ md5sum {Integrated,Act}*.jar
c1aff93e2ddcedda892e338dd1cc0950 *IntegratedCrafting-1.12.2-1.0.8.jar
82b15eaa0c2b4421408db074ff464374 *IntegratedDynamics-1.12.2-1.1.0.jar
fa9588c185bb9de5a725c1486ed3f57d *IntegratedTerminals-1.12.2-1.0.12.jar
4dcb9b2079097ca6ae15cd723f071f94 *IntegratedTunnels-1.12.2-1.6.10.jar
5b619cf05cc827426f80df4b716092f5 *ActuallyAdditions-1.12.2-r150.jar
a button added to the left column that changes how many rows of inventory the GUIs can display (similar to refined storage)
whenever you put a predicate in the terminal, the scroll bar isn't reset.
the scroll bar should be reset to the top position whenever it is disabled (and possibly set back to original position once re-enabled)
All kinds of things will be put in the box. When I check the storage terminals, although the items show the total number, they are not necessarily all in one box. This makes it impossible for me to simply know the total number of some of my projects to specify the production plan.
This machine can:
the terminal seems to grab the wrong textures for certain items while scrambling them in the process, resulting in mismatches and outright missing textures
IT 1.0.3
forge 2808
How to do it?
https://media.giphy.com/media/kaNEErcd8RaStFJgmB/giphy.gif
Tested on:
Added a peanut butter sandwich as a craft recipe, looked at the storage terminal to craft said sandwhich and see a broken texture.
should see texture of item
When the crafting grid is empty, dropping items on the output slot of the crafting terminal destroys them.
We should be able to drop items into the output slot of the crafting tab. Moreover, they should never disappear.
I checked the bug with only these mods installed.
I was asked for my gripes with the terminals on discord and was told to post them on github so here we go
Terminals have a habit of forgetting your sorting settings. They'll reset sorting and JEI preferences and that's really annoying. Also mentioned in #28
Putting items into the terminal is funny. It doesn't behave like a normal inventory, so you can't insert swaths of items using mouse tweaks or inventory tweaks features. You're left to insert them one stack at a time. If you try, one stack might go into the system, but the rest will either go into the crafting grid (even if you're on the storage tab) or act like there isn't an inventory at all. Maybe behind the scenes the terminal could have a small internal buffer of its own that you put items into, then it distributes said items to the appropriate locations. Said buffer would also be visible by the system so you still have access while they're in flux. Just a thought.
Shift-clicking items out of the terminal moves ALL of the items into your inventory. So if I have like fifty stacks of cobble and only need the one stack, I can't just shift click it into my inventory or my pockets will fill entirely with cobble. When I'm shift clicking items out of a terminal, I almost always just want the one stack not all the stacks.
The crafting grid clear button behavior should be reversed. Or at least there should be a button to reverse it. I very VERY rarely actually want the grid to empty into my inventory. For the main system, I would prefer the excess items just go into the system instead. It's mainly useful for items to pop into your inventory instead when you're using a terminal as a debug tool, like I did for my salt producer. Furthermore, when you have stuff in the crafting grid and you load up a new recipe, all of the items that were in the grid go into your inventory instead of the system.
[ ] When you right-click the search bar, it selects the text instead of just clearing it like you'd expect. Though this is probably an issue with integrated dynamics as a whole since I've had that happen with the logic programmer too. It's pretty much universal at this point that in minecraft, if you right-click a search bar, it clears it. Just selecting it seems like a weird half-step to that that serves no apparent purpose.
JEI only recognizes the system's inventory for auto-filling recipes. It does not recognize items in your own inventory.
Steps to reproduce:
Make a small network, with 2 Item Interfaces, set one of them to Interface Channel 1.
put oak logs in the channel 0 interface attached storage.
put something else in the channel 1 attached storage.
place a crafting interface, put a recipe for oak planks in it.
Place a storage terminal.
You will not be able to see the craftable recipe when the terminal is in "All" mode, switching to channel 0 will cause it to appear.
https://imgur.com/z6iwa8M :All
https://imgur.com/IkenWs8 :Channel 0
https://imgur.com/ppiqsTm :Channel 1
Forge: 14.23.5.2837
Integrated Terminals: 1.0.8
Dynamics: 1.0.14
Tunnels: 1.6.9
Crafting: 1.0.7
when first starting up the game and joining a map, the terminal will start out with no tab selected, when then hovering over an item in the player inventory and pressing R to show its recipe the game crashes
the recipe shows
portable terminals. a short ranged one can be made with a terminal and a mono-directional connector and a long/multidimensional one with a omni-directional connector. they could be linked to a network via another omni/mono-directional connector on the network itself.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.