d-rickyy-b / python-blackjackbot

A Telegram bot written in Python to play the game BlackJack alone or with your friends

Python-BlackJackBot

This is the code for my Telegram Bot with which you can play the game Black Jack. You can find the hosted version of it here: https://telegram.me/BlackJackBot

Setup

This project is really easy to set up. No matter which of the following ways you'll use, you'll always need a config file. To create one, simply copy the existing config.sample.py file and name it config.py. Enter your bot token and make your changes accordingly.

Then you're left with several ways to run this bot.

1.) Cloning the repo

If you want to run this code from source, you can just git clone this repo. It's recommended to create a new virtual environment (python3 -m venv /path/to/venv). This bot uses the python-telegram-bot framework to make Telegram API calls. You can install it (and potential other requlrements) like that:

pip install -r requirements.txt

Afterwards just run python3 bot.py and if done right, you'll be left with a working bot.

2.) Docker

This project also contains a Dockerfile as well as a pre-built Docker image hosted on the official Docker Hub.

You will also find the docker-compose.yml file with which you can easily set up your own instance of the bot. Just specify the path to your config etc. in said docker-compose file.

python-blackjackbot's Issues

Implement improved comment feature

The current comment feature is a bit buggy.

1. check if a player is currently playing a game
2. if yes: tell them that they can't send a comment at the moment & exit
   2.1 clear commenting state
3. if no: request their comment + Inline cancel button + store message ID
4. if game is started for that chat, edit message: "commenting during game is not possible" + remove keyboard + exit
   4.1 clear commenting state
5. Wait for any kind of text and forward to the admins
   5.1 clear 'commenting' state

Add /rule command to show the rules

Join method is conflicted with multiplayer join method

This could be fixed with a GUI menu in SP

Canceling comments is not working

When using /comment, it's not possible to cancel the action.

Create tests for the bot & include them in Travis

Keybord keeps being displayed when multiplayer-in-chat is finished

1. Play a in-chat multiplayer game
2. After it ends the keyboard stays

Language selection pops up each time someone joins a group

In-game money

• Users can get money, if they play once per day
• player class needs variable for the user's bet
• in evaluation money needs to be given to the winners
• new field in database

Automatic deploy to VPS

Some automated way to deploy the code to the VPS with travis should be used in order to keep stuff automated.

A script on the server side should be called to automatically switch user, git pull and systemctl restart bot.

I would need to implement a way to drain the bot, so that playing users are not kicked out of their current game, but instead get noticed, that the bot is going down for maintenance.

---

https://gist.github.com/jesgs/7815f791c98ea2f3e82c51f5c66b6ce1

Add GUI as bot inline menu

Some nice inline buttons can help configuring the bot

Everyone in a group can start the game via inline button

Can't start new game

I started a new game, after few previous.In this new game i had 21 and Dealer had 25 from the start.
I can't stop the game I also can't start new game.
Look like a bug.

Use Properties

https://stackoverflow.com/questions/6618002/python-property-versus-getters-and-setters

Credits command to display all the helpers/translators

More feedback from bot

E.g. when trying to create a multiplayer game which cannot be established because of any reason, there should be a feedback from the bot to the user.

Other cases:

• When trying to join a mp game
• When trying to end/start games

Hide one of the two cards of the dealer in the beginning

Build inline menu

https://github.com/python-telegram-bot/python-telegram-bot/wiki/Code-snippets#build-a-menu-with-buttons

Implement timer for multiplayer games to skip AFK players

In multiplayer games it can be frustrating when dealing with AFK players. To prevent that from happening, there should be a timer that skips players who are not participating. Default value of the timer: 30 seconds.

After the timer ends, the player will be skipped. It's basically the same as if they just chose to "stand".

Display error when no bot token is provided

Display cards of dealer at the beginning in group chats

Users are not getting a keyboard after starting a game via inline buttons

The bot uses selective keyboards so that not every player receives an annoying keyboard. When using inline buttons to join/start, the user won't receive a keyboard.

Steps to reproduce

1. Start a new game in a group
2. Have someone join the game via inline button

Expected result

Each player receives their keyboart to take part in the round

Actual result

The person starting/joining the game via inline button does not get a keyboard because there is no message to reply to

Use Python index function for getting indices

Python-BlackJackBot/gamehandler.py

Line 23 in f1161f5

def get_index_by_chatid(self, chat_id):

Multiplayer with strangers (without group)

• Matching mechanism
• Unique game-room IDs
• Join a game-room via ID
• Game room class with list of user IDs
• Game rooms can be private
• Normal blackjack class can be used, but chat ID must be replaced by game room id, so that messages can be sent to all the players via private message

Create database when no database is present

On the first turn of a player, check if his cards are >= 21

Otherwise users can take another card when having 21

Dependabot couldn't authenticate with https://pypi.python.org/simple/

Dependabot couldn't authenticate with https://pypi.python.org/simple/.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

View the update logs.

Search for other players which created a public game room

That way users could open game rooms and play with strangers

Statistics for won/lost games

Statistics for won/lost games.
Saved in a database for every user separately.

Implement message dispatcher for multiplayer "direct" games

Currently the bot can only send messages via PM or groups (via update.message.reply_text from PTB). This is a limiting factor for "direct multiplayer" games.

Implement joining for groups

Players in group games need the ability to join games!

Suggestions

1. "Stop" button is a bit confusing. Sometimes people exchange it as the "No more card" button.

2. Instead of a double /start command to play, maybe there should be a /new command for a new game and /start command to start the game.

3. Replace the X in: "✖️Players who busted" with ❌.

Stop cmd doesn't work when lobby is created but game isn't started yet.

1. Press /start in group
2. Let someone /join the game

You can't stop the lobby

Add sample config file

Inline keyboard to take card & no more card

Localized commands don't work

/start command in spanish (/iniciar) doesn't work

Create multiple blackjack classes

One for groups, one for private, one for mobile with strangers

Avoid usage of send_message

Use the framework method sendMessage instead

One is not able to stop an in-chat multiplayer game

1. Start a /multiplayer game
2. Try to /stop the game

Take language ID from Telegram API

The Telegram API sends a language ID which can be taken to identify where a user comes from

Leave channels as soon as added

If the bot receives an update from a channel, it should leave it instantly.

Otherwise there will be an error happening at:

Python-BlackJackBot/main.py

Lines 97 to 107 in 1f7c49d

	def game_commands(bot, update):
	if update.message is None:
	logger.warning("game_commands error happened again! Update: {}".format(update))
	text = update.effective_message.text
	chat_id = update.effective_message.chat_id
	user = update.effective_user
	user_id = user.id
	first_name = user.first_name
	last_name = user.last_name
	username = user.username

Since channel updates don't have the user object.

Add typing to methods

Make inline keyboards game-bound

Inline keyboards from a previous message should not work for the current game.

Example: When you are mid game and there are "hit" and "stand" buttons, then you choose to /stop the game, you should not be able to use them for your current game again.

Hide function is not working

Possibility for group admin to end current game

Add join_id to player object

Implement help command

No implementation yet.

Should explain all commands -> localized

Inline "New Game" button for 'evaluation' message

Instead of a new message, which only adds to the spam, send the "new Game" button directly with the last evaluation message.

Implement timer for a freshly created game

When a multiplayer game is being created and there are not enough players after 5 minutes it should be stopped.
If there are enough players, the game will be started.

Admin functions: Add 'answer to comment' function

As an admin i cannot answer to comments

Move to next player, when player got 21/blackjack on first move