Comments (6)
I'd rather move forward to node-canvas@2; the change is minor:
diff --git a/test/render-world b/test/render-world
index fbc4fc4..45a79cd 100755
--- a/test/render-world
+++ b/test/render-world
@@ -10,10 +10,10 @@ if (!/^[a-z0-9]+$/i.test(projectionName)) throw new Error;
var fs = require("fs"),
topojson = require("topojson-client"),
- Canvas = require("canvas"),
+ {createCanvas} = require("canvas"),
d3 = Object.assign({}, require("d3-geo"), require("../"));
-var canvas = new Canvas(width, height),
+var canvas = createCanvas(width, height),
context = canvas.getContext("2d");
var world = require("world-atlas/world/50m.json"),
but the idea is to keep in sync with d3-geo and d3-geo-projection, so I'd like to ask @mbostock for his opinion first.
from d3-geo-polygon.
(From memory) I think it's because the tests involve node-canvas@1 and would have to be rewritten to use node-canvas@2, with its slightly different API.
from d3-geo-polygon.
If tests are only concern here than maybe dropping this constraint is an option as short time fix. Adding preinstall step could keep local installs within a 6.x - 10.17.0 range while allowing npm usages.
from d3-geo-polygon.
A simpler solution at #41 (comment)
from d3-geo-polygon.
Related: #37
from d3-geo-polygon.
fixed by #41
from d3-geo-polygon.
Related Issues (20)
- Use clipPolygon for geoInterrupted HOT 2
- Multiple broken links in examples HOT 6
- d3.geoVoronoi() is not (yet) existing? HOT 1
- MultiPolygon clipping HOT 3
- Easier usage with d3.geoProject? HOT 2
- named imports fail in webpack build. HOT 2
- planar polygon clipping HOT 2
- South aspect of Leeβs conformal projection in a tetrahedron is all black HOT 4
- polygon clipping errors HOT 15
- use robust-predicates?
- clipping bug
- Markley HOT 3
- Inverse clipping on d3.geoClipPolygon HOT 2
- Tetrahedral Lee: Inverse broken? HOT 2
- deltoidal hexecontahedron projection HOT 6
- rhombic dodecahedron test produces weird results probably something i am missing HOT 4
- is it possible to only draw some of the faces? HOT 6
- Tried adding parents to TetrahedralLee HOT 7
- geoDesic HOT 18
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3-geo-polygon.