Comments (3)
Hey @ChrisB9 thanks for your input. Great idea! A quality analysis tool is on our roadmap (like you, we also always end up in a "yoast-comparing" discussion 😄).
The idea would be to add a colored (red, orange, green) badge-tab to the right of the tab-panel:
Beside the two checks you've already mentioned, we also want to have some semantic checks. In summary:
- Title
- Description
- Headline Count in Element (loop object by fielddefinition and documents by elements and filter
wysiwyg
,input
elements) - Keyword/Keyphrase Density
- Performance
- ...
Technically all those "Modules" should be available as configurable and self-sustainable elements like the integrators already are. I think about a tagged symfony service and also a corresponding extjs object, for example:
Service
SeoBundle\MetaData\Analysis\TitleDescriptionAnalyser:
tags:
- {name: seo.meta_data.analyser, identifier: title_description }
Php Class
<?php
namespace SeoBundle\MetaData\Analysis;
class TitleDescriptionAnalyser implements AnalyserInterface
{
/**
* {@inheritdoc}
*/
public function analyse(array $elements, array $context)
{
return [];
}
}
Extjs Module
pimcore.registerNS('Seo.MetaData.Analysis.TitleDescriptionAnalyser');
Seo.MetaData.Analysis.TitleDescriptionAnalyser = Class.create(Seo.MetaData.Analysis.AbstractAnalyser, {
buildPanel: function () {
return fields;
},
getRanking: function () {
return 0;
}
});
Controller
<?php
namespace SeoBundle\Controller\Admin;
class MetaDataController extends AdminController
{
public function analyseElement(Request $request)
{
$data = [];
$element = null; // @todo
foreach($this->analysisManager->getAnalysers() as $name => $analyser) {
$data[$name] = $analyser->analyse($element);
}
return $this->json([
'data' => $data,
'score' => $this->analysisManager->calculateScore($data)
]);
}
}
But I'm not sure if we need a php class at all, since the analysis should work in real-time and with unpublished content. We should do some benchmark tests and POC first (change listener on all inputs could be a performance issue in extjs but also
watching the iframe element in document context could be a tricky one.)
However, this is just a rough idea how we could achieve this. For now, we should implement the basic structure + your suggested title/description module. There is no active sprint for this feature therefor we need to discuss this internally first.
from pimcore-seo.
Yea, yoast did put up a really good tool for clients :D
But thats very promising and looks like a good direction.
I could imagine a two-path analysis:
- you already have a word-count, this could be extended with an condition, if number in range then green. This should normally not be too performance heavy
- Then the semantic check, as you mentioned, should be analyzed with php because of easier extensibility.
Would it performance-wise make sense, to put all the data into the localstorage on-edit and then the sementic checker pulls it from there asynchronosly on-change:localstorage [element-id] -> semantic check. This should then remove your iframe issue. I am doing the same thing with my PageBuilder-Bundle and it currently seems to work without major speed-implications
Do you need any help with building that feature?
from pimcore-seo.
Is this still planned? :)
from pimcore-seo.
Related Issues (20)
- Add Permissions
- Preview based on user locale
- NewsBundle collision
- Pimcore X compatibility HOT 4
- Incompatibility with Pimcore Portal Engine Bundle HOT 1
- Adding a schema via SEO panel and via a custom extractor does not output JSON HOT 4
- bug: duplicate tabs HOT 2
- Does not use BundleManagerEvents HOT 1
- XLIFF Export/Import Support HOT 5
- Bug: can't link image to og:image tag HOT 2
- Preview image (og:image, twitter:image) not shown if asset path contains spaces HOT 1
- [Title & Description Integrator]: Add noindex option and rename to "General Integrator" HOT 8
- Tab duplicated HOT 1
- Respect Pimcore fallback languages HOT 4
- Umlauts in markup HOT 1
- Pimcore 11 Support HOT 6
- Seo Document Editor Support HOT 3
- Error when adding a thumbnail HOT 2
- ElementMetaDataManager::getElementData(): Argument #2 ($elementId) must be of type int, null given HOT 3
- Questions and suggestions SEO Bundle HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pimcore-seo.