dailystruggle / glide Goto Github PK

I noticed some incompatibilities with other plugins that use player.setGliding() to do things. Would you mind if I put a pull request in over the next few days to provide compatibility with SurvivalMechanics? I am familiar with RealisticSwimming's and Elytra's codes and already know how I can fix this (I'll put pull requests into their devs to handle it on their end), and I own a copy of SurvivalMechanics and they have API, so I'm sure I can figure it out and send you a PR for SurvivalMechanics compatibility.
Thanks for your hard work!

I noticed when using slow falling potions at the same time you fall "extra slow" or while using the new fall feature you added it sometimes creates a glitchy looking animation, especially when combined with ChickenGlide, which uses this potion effect to do the gliding. Perhaps run a check
player.hasPotionEffect(PotionEffectType.SLOW_FALLING) before activating on fall or using the command? I dunno.

Got this NPE today when I first joined.

https://pastebin.com/JJULj8t1

Guess just do a quick check for null in case the player has not fully loaded or something.