dalperin / remix-redis-session Goto Github PK

View Code? Open in Web Editor NEW

27.0 27.0 6.0 72 KB

License: MIT License

TypeScript 100.00%

remix-run

remix-redis-session's People

Contributors

Stargazers

Watchers

Forkers

yaameen huangc28 yadyn tamcgoey fjgo knox-grammar

remix-redis-session's Issues

Error when using expires

Redis expects the expires value to be an integer, however the expiresToSeconds function returns values with a decimal value. As such, we get errors like this:

ReplyError: ERR value is not an integer or out of range
    at parseError (C:\Source\__rp\payments-web\node_modules\redis-parser\lib\parser.js:179:12)
    at parseType (C:\Source\__rp\payments-web\node_modules\redis-parser\lib\parser.js:302:14) {
  command: {
    name: 'set',
    args: [
      'KEY GOES HERE',
      '{ DATA GOES HERE }',
      'EX',
      '1199.999' <-- This is the problem argument
    ]
  }
}

I believe the fix is to simply wrap the return with Math.round.

Fails when `maxAge` is too large

Hi! 👋

Firstly, thanks for your work on this project! 🙂

When I tried setting a maxAge that is sufficiently large, Redis complains that the expiry duration needs to be in [integer] seconds. I believe the problem is due to the use of floating point numbers. This patch fixed it for me, so it'll be great if you can apply this or similar to the code.

diff --git a/node_modules/remix-redis-session/dist/index.js b/node_modules/remix-redis-session/dist/index.js
index eefa741..a2b73d4 100644
--- a/node_modules/remix-redis-session/dist/index.js
+++ b/node_modules/remix-redis-session/dist/index.js
@@ -25,7 +25,7 @@ const expiresToSeconds = (expires) => {
     const now = new Date();
     const expiresDate = new Date(expires);
     const secondsDelta = (expiresDate.getTime() - now.getTime()) / 1000;
-    return secondsDelta < 0 ? 0 : secondsDelta;
+    return secondsDelta < 0 ? 0 : Math.round(secondsDelta);
 };
 function createRedisSessionStorage({ cookie, options }) {
     let redis;

This issue body was partially generated by patch-package.

Example use? `(0 , sessions_1.createSessionStorage) is not a function` error

I was looking for an equivalent to express-session and connect-redis for Remix and remix-auth. Is that what you're aiming for? If so, would you share a working example?

I tried replacing the createCookieSessionStorage call with createRedisSessionStorage and that doesn't seem to be enough. I'm getting the following error:

/home/xxx/yyy/node_modules/remix-redis-session/dist/index.js:40
    return (0, sessions_1.createSessionStorage)({
                                               ^
TypeError: (0 , sessions_1.createSessionStorage) is not a function
    at createRedisSessionStorage (/home/xxx/yyy/node_modules/remix-redis-session/dist/index.js:40:48)
    at Object.<anonymous> (/home/xxx/yyy/src/remix/app/auth/session.server.ts:9:29)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:75:12)
    at internal/main/run_main_module.js:17:47

dalperin / remix-redis-session Goto Github PK

remix-redis-session's People

Contributors

Stargazers

Watchers

Forkers

remix-redis-session's Issues

Error when using expires

Fails when `maxAge` is too large

Example use? `(0 , sessions_1.createSessionStorage) is not a function` error

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs